[dpdk-dev,v1] i40e: highlight change to flexible payload for RSS config

Message ID 1509722663-29971-1-git-send-email-john.mcnamara@intel.com
State Accepted, archived
Headers show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Mcnamara, John Nov. 3, 2017, 3:24 p.m.
Add deprecation notice to highlight a future change in the
default configuration behavior for flexible payload for RSS.

Signed-off-by: John McNamara <john.mcnamara@intel.com>
---
 doc/guides/rel_notes/deprecation.rst | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Chilikin, Andrey Nov. 4, 2017, 7:41 p.m. | #1
> -----Original Message-----
> From: Mcnamara, John
> Sent: Friday, November 3, 2017 3:24 PM
> To: dev@dpdk.org
> Cc: Rybalchenko, Kirill <kirill.rybalchenko@intel.com>; Chilikin, Andrey
> <andrey.chilikin@intel.com>; Mcnamara, John <john.mcnamara@intel.com>
> Subject: [PATCH v1] i40e: highlight change to flexible payload for RSS config
> 
> Add deprecation notice to highlight a future change in the
> default configuration behavior for flexible payload for RSS.
> 
> Signed-off-by: John McNamara <john.mcnamara@intel.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index a93c3e1..9e9caa6 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -67,3 +67,9 @@ Deprecation Notices
> 
>  * librte_meter: The API will change to accommodate configuration profiles.
>    Most of the API functions will have an additional opaque parameter.
> +
> +* i40e: The default flexible payload configuration which extracts the first 16
> +  bytes of the payload for RSS will be deprecated starting from 18.02. If
> +  required the previous behavior can be configured using existing flow
> +  director APIs. There is no ABI/API break. This change will just remove a
> +  global configuration setting and require explicit configuration.
> --
> 2.7.5

Acked-by: Andrey Chilikin <andrey.chilikin@intel.com>
Thomas Monjalon Nov. 14, 2017, 11:29 p.m. | #2
> > Add deprecation notice to highlight a future change in the
> > default configuration behavior for flexible payload for RSS.
> > 
> > Signed-off-by: John McNamara <john.mcnamara@intel.com>
> 
> Acked-by: Andrey Chilikin <andrey.chilikin@intel.com>

It is a specific driver behaviour change notice.
So applied with only one ack, thanks.

Patch

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index a93c3e1..9e9caa6 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -67,3 +67,9 @@  Deprecation Notices
 
 * librte_meter: The API will change to accommodate configuration profiles.
   Most of the API functions will have an additional opaque parameter.
+
+* i40e: The default flexible payload configuration which extracts the first 16
+  bytes of the payload for RSS will be deprecated starting from 18.02. If
+  required the previous behavior can be configured using existing flow
+  director APIs. There is no ABI/API break. This change will just remove a
+  global configuration setting and require explicit configuration.