From patchwork Tue Oct 24 13:19:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luca Boccassi X-Patchwork-Id: 30798 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 819581B801; Tue, 24 Oct 2017 15:19:15 +0200 (CEST) Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id 0337E1B807 for ; Tue, 24 Oct 2017 15:19:11 +0200 (CEST) Received: by mail-wm0-f68.google.com with SMTP id t69so15686431wmt.2 for ; Tue, 24 Oct 2017 06:19:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=cAY3Gh+QPnwBt8XVKInRY2ysYrn1Lld8VBeQWQaj1SU=; b=o+s8CeNn1J2WN9FskzczPH/jLjuxFG1v6jB+iGlR4T+TC4egctHx4pOzM+/0Wq2mmI 6DKltaGXZEDPv6kjPHHCwGmEF7LXsmWqRmI79IeIQqNlhTpMP/Ftg1DGGQsaOOs98YbH ie6duWvXUYIWKvCBhyMiXgfUNwKFu3I9a+AXP9705jBiylxlzYwGZfuKiZcDIWORbwfn st0s64p65Skwm6BQpEIq5OQTVU1+FxjEegzojX2eMxs8CIYSF+vyMdelLan0K4hPJuT9 0jWAGVA/9Ki2oOTwrPsf1eqLmdC7FdFd9QE2/uISVE7KvSep7qgg8pXnUfyyoCyGqThY VgOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=cAY3Gh+QPnwBt8XVKInRY2ysYrn1Lld8VBeQWQaj1SU=; b=E++CQBxlFiYfuRVVHrL9Ym55z0Jwhf6rzSS8JNF8uBwWv5KGYhMvpmyuKY19ywGyZA DJ4JUH03gW8yf36G7sx0m2rllLS+LhEbctVKp4umBNltqA/TVZRCpx/JhwRt3+Cuy35l 1j3Nq/kVgGJBchAMN1WqUKfDerNBuKAmGA6SeuHtAYrzUKBh7VPcwFIizUEgcS3MWdWJ txbxD2ky3bnjL1MTpr0xM77Ub/XZs2IGu9z1hlTqcYSD3jU/VPKH7utQF/ofedYVso2L eRTJe9ZpBqYZFyzMwf6i3axBX0k4ljsUpyqWoZR6EIljbAUWrowTE2xWaf8vTRXGWE4f 9Prg== X-Gm-Message-State: AMCzsaXsOYnOUCkpgItNsw3V0icK7UwnaNrJb6VVHz9EzC27/jrNSDis 9wGcjlSuHJl2Zp/klVkuOx555iusux0= X-Google-Smtp-Source: ABhQp+QUDN2O+ZzPrYij5ujaDlxJYm0Pgq08gixr2X8FbvbIfsTN5ZwqZDEDZyy+IJXJdNcPx4159g== X-Received: by 10.80.214.71 with SMTP id c7mr20013265edj.271.1508851150461; Tue, 24 Oct 2017 06:19:10 -0700 (PDT) Received: from localhost ([213.251.34.151]) by smtp.gmail.com with ESMTPSA id p7sm174693edj.5.2017.10.24.06.19.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 24 Oct 2017 06:19:09 -0700 (PDT) From: luca.boccassi@gmail.com To: dev@dpdk.org Cc: wenzhuo.lu@intel.com, wei.dai@intel.com, remy.horton@intel.com, thomas@monjalon.net, Luca Boccassi Date: Tue, 24 Oct 2017 14:19:05 +0100 Message-Id: <20171024131905.17917-2-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171024131905.17917-1-luca.boccassi@gmail.com> References: <20171024110312.24029-1-luca.boccassi@gmail.com> <20171024131905.17917-1-luca.boccassi@gmail.com> Subject: [dpdk-dev] [PATCH v3 2/2] ethdev: document new error code for reset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Luca Boccassi When VF reset will be supported by drivers, the API will most likely have to return -EAGAIN to avoid blocking when the VF cannot be reset because the PF is down. Document it immediately even if it's not yet supported, so that users and developers can already take into account about this use case, and thus avoid an API-incompatible change later on. This is based on real-world production usage and customer escalations, using earlier patches from Intel. Signed-off-by: Luca Boccassi Acked-by: Thomas Monjalon --- lib/librte_ether/rte_ethdev.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index 697f6b2e0..2a0129a2a 100644 --- a/lib/librte_ether/rte_ethdev.h +++ b/lib/librte_ether/rte_ethdev.h @@ -2277,6 +2277,7 @@ void rte_eth_dev_close(uint16_t port_id); * - (-EPERM) if not ran from the primary process. * - (-EIO) if re-initialisation failed. * - (-ENOMEM) if the reset failed due to OOM. + * - (-EAGAIN) if the reset temporarily failed and should be retried later. */ int rte_eth_dev_reset(uint16_t port_id);