[dpdk-dev,v3,1/2] ethdev: document error codes of reset
diff mbox

Message ID 20171024131905.17917-1-luca.boccassi@gmail.com
State Accepted, archived
Delegated to: Ferruh Yigit
Headers show

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Luca Boccassi Oct. 24, 2017, 1:19 p.m. UTC 
From: Luca Boccassi <bluca@debian.org>

This new function returns 0 on success and various error codes on
different failures. Attempt to document them.

Signed-off-by: Luca Boccassi <bluca@debian.org>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
---
 lib/librte_ether/rte_ethdev.h | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Ferruh Yigit Oct. 24, 2017, 8:41 p.m. UTC | #1 
On 10/24/2017 6:19 AM, luca.boccassi@gmail.com wrote:
> From: Luca Boccassi <bluca@debian.org>
> 
> This new function returns 0 on success and various error codes on
> different failures. Attempt to document them.
> 
> Signed-off-by: Luca Boccassi <bluca@debian.org>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>

Series applied to dpdk-next-net/master, thanks.
Luca Boccassi Oct. 25, 2017, 12:01 p.m. UTC | #2 
On Tue, 2017-10-24 at 13:41 -0700, Ferruh Yigit wrote:
> On 10/24/2017 6:19 AM, luca.boccassi@gmail.com wrote:
> > From: Luca Boccassi <bluca@debian.org>
> > 
> > This new function returns 0 on success and various error codes on
> > different failures. Attempt to document them.
> > 
> > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > Acked-by: Thomas Monjalon <thomas@monjalon.net>
> 
> Series applied to dpdk-next-net/master, thanks.

Thanks!

Will it make it into 17.11-rc2?
Ferruh Yigit Oct. 25, 2017, 4:08 p.m. UTC | #3 
On 10/25/2017 5:01 AM, Luca Boccassi wrote:
> On Tue, 2017-10-24 at 13:41 -0700, Ferruh Yigit wrote:
>> On 10/24/2017 6:19 AM, luca.boccassi@gmail.com wrote:
>>> From: Luca Boccassi <bluca@debian.org>
>>>
>>> This new function returns 0 on success and various error codes on
>>> different failures. Attempt to document them.
>>>
>>> Signed-off-by: Luca Boccassi <bluca@debian.org>
>>> Acked-by: Thomas Monjalon <thomas@monjalon.net>
>>
>> Series applied to dpdk-next-net/master, thanks.
> 
> Thanks!
> 
> Will it make it into 17.11-rc2?

Most probably, next-net not pulled yet, it will be pulled for rc2. Unless has
been removed while merged into main tree, will be in rc2.

Patch
diff mbox 

diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index b773589d6..697f6b2e0 100644
--- a/lib/librte_ether/rte_ethdev.h
+++ b/lib/librte_ether/rte_ethdev.h
@@ -2269,6 +2269,14 @@  void rte_eth_dev_close(uint16_t port_id);
  *
  * @param port_id
  *   The port identifier of the Ethernet device.
+ *
+ * @return
+ *   - (0) if successful.
+ *   - (-EINVAL) if port identifier is invalid.
+ *   - (-ENOTSUP) if hardware doesn't support this function.
+ *   - (-EPERM) if not ran from the primary process.
+ *   - (-EIO) if re-initialisation failed.
+ *   - (-ENOMEM) if the reset failed due to OOM.
  */
 int rte_eth_dev_reset(uint16_t port_id);