From patchwork Tue Sep 5 20:51:58 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luca Boccassi X-Patchwork-Id: 28390 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 4C7625323; Tue, 5 Sep 2017 22:52:57 +0200 (CEST) Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id CD52E37B0 for ; Tue, 5 Sep 2017 22:52:55 +0200 (CEST) Received: by mail-wm0-f65.google.com with SMTP id e64so3866916wmi.2 for ; Tue, 05 Sep 2017 13:52:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=eLd2G+IKqTuX45G6agMttC1zOYyEG8BG56exofTUANM=; b=daJ+ZVqSSS/u+h0nTZhaU9D0SbTFHZ8+DPbVff5FMA88b+LYhYDS3Ew3jF+rhKf2Og Zs4YPYeUgUm+FRaWR2TztDassr59o0tHoXsTQCxNhwrh0MGw8Zr9VT5GRZiTeATNSJKt oCjtyP4TFtxyI/ej9wDrEhqbatWnnXoThFkVTQvr9qo9nLbktop39ZmxfYMF1xAF5OKW CvdMQDYuMr0fpSgMEWIu4Y+3yvnA0NWtqJGWrIjW610alMPCATtKi/ZDb1iM4Kobrqnt FYhW4oVLdDwm6qo82opK4GUZEWlkMVW05J/poLJv4oJsLWQv5kyWmTCOBhmPnQQTe9IV EJ/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=eLd2G+IKqTuX45G6agMttC1zOYyEG8BG56exofTUANM=; b=mdXyfK/fEfspk3bTpIcmovJwf41oQ/7aVcw/iqd1vYtIv4kT0iYVhBCvinwwXaafR5 T1OOA70vYKJn9MXUfxTH55SZK8H0ykbKnS6aU0WPiAJfTDIotqZwzmMgEWAIQGwH9M0V cjMzVtPzpIfwJPfIqFO5AIa/RtmuDsC2aO+LNk2MolNFw8vo1D6uqYNccMDjvTUdgul7 kthAZM/4yQptdMnayYhw0L9dt48fmjssrFDj/oNqKxofnb5DaA2RR5e6pY10n4kO9ijN EDpdAhTOcLucFercnGhSaq4+8aNzCS3pPhwoMfeHglo+W5NYzwyDdIQJAmpAbrBpzDbF T5Ow== X-Gm-Message-State: AHPjjUizf/zmwgueq1fN1VkS3PWRM3cmtuSYkRM6QQaYxTmtP3wzHDDD bp6JOE1IU2qlFzM/Gkk= X-Google-Smtp-Source: ADKCNb6vcQeq7EZHMMhny6uIQbN9/nt1CE8WpG9LNSn83Btjg8VRSj8Cs1I5+QhHaib/fF98rdANsA== X-Received: by 10.28.214.212 with SMTP id n203mr154465wmg.10.1504644775247; Tue, 05 Sep 2017 13:52:55 -0700 (PDT) Received: from localhost ([2a00:23c5:bef3:400:4a51:b7ff:fe0b:4749]) by smtp.gmail.com with ESMTPSA id 25sm2008427wrv.8.2017.09.05.13.52.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Sep 2017 13:52:54 -0700 (PDT) From: luca.boccassi@gmail.com To: dev@dpdk.org Cc: ferruh.yigit@intel.com, Luca Boccassi Date: Tue, 5 Sep 2017 21:51:58 +0100 Message-Id: <20170905205159.8606-6-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170905205159.8606-1-luca.boccassi@gmail.com> References: <20170905205159.8606-1-luca.boccassi@gmail.com> Subject: [dpdk-dev] [PATCH v7 5/6] mk: sort object files when building deps lists X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Luca Boccassi In order to achieve reproducible builds, always use the same order when listing object files to build dependencies lists. Signed-off-by: Luca Boccassi --- mk/rte.app.mk | 4 ++-- mk/rte.hostapp.mk | 4 ++-- mk/rte.shared.mk | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/mk/rte.app.mk b/mk/rte.app.mk index c25fdd9f5..c5b8c1ead 100644 --- a/mk/rte.app.mk +++ b/mk/rte.app.mk @@ -270,8 +270,8 @@ LDLIBS_NAMES += $(patsubst -Wl$(comma)-l%,lib%.a,$(filter -Wl$(comma)-l%,$(LDLIB # list of found libraries files (useful for deps). If not found, the # library is silently ignored and dep won't be checked -LDLIBS_FILES := $(wildcard $(foreach dir,$(LDLIBS_PATH),\ - $(addprefix $(dir)/,$(LDLIBS_NAMES)))) +LDLIBS_FILES := $(sort $(wildcard $(foreach dir,$(LDLIBS_PATH),\ + $(addprefix $(dir)/,$(LDLIBS_NAMES))))) # # Compile executable file if needed diff --git a/mk/rte.hostapp.mk b/mk/rte.hostapp.mk index 5cb4909cb..f58173c31 100644 --- a/mk/rte.hostapp.mk +++ b/mk/rte.hostapp.mk @@ -69,9 +69,9 @@ O_TO_EXE_DO = @set -e; \ -include .$(HOSTAPP).cmd # list of .a files that are linked to this application -LDLIBS_FILES := $(wildcard \ +LDLIBS_FILES := $(sort $(wildcard \ $(addprefix $(RTE_OUTPUT)/lib/, \ - $(patsubst -l%,lib%.a,$(filter -l%,$(LDLIBS))))) + $(patsubst -l%,lib%.a,$(filter -l%,$(LDLIBS)))))) # # Compile executable file if needed diff --git a/mk/rte.shared.mk b/mk/rte.shared.mk index 87ccf0ba4..4e680bc03 100644 --- a/mk/rte.shared.mk +++ b/mk/rte.shared.mk @@ -85,8 +85,8 @@ LDLIBS_NAMES += $(patsubst -Wl$(comma)-l%,lib%.a,$(filter -Wl$(comma)-l%,$(LDLIB # list of found libraries files (useful for deps). If not found, the # library is silently ignored and dep won't be checked -LDLIBS_FILES := $(wildcard $(foreach dir,$(LDLIBS_PATH),\ - $(addprefix $(dir)/,$(LDLIBS_NAMES)))) +LDLIBS_FILES := $(sort $(wildcard $(foreach dir,$(LDLIBS_PATH),\ + $(addprefix $(dir)/,$(LDLIBS_NAMES))))) # # Archive objects in .so file if needed