diff mbox

[dpdk-dev,v3,4/8] mk: sort list of files in examples.dox

Message ID 20170623184153.24488-5-lboccass@brocade.com (mailing list archive)
State Superseded, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Luca Boccassi June 23, 2017, 6:41 p.m. UTC 
  From: Luca Boccassi <luca.boccassi@gmail.com>

The result of find might not be stable depending on external
conditions.
Pipe it through LC_ALL=C sort to ensure reproducible results when
generating examples.dox.

Signed-off-by: Luca Boccassi <luca.boccassi@gmail.com>
---
 mk/rte.sdkdoc.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

John McNamara June 26, 2017, 2:48 p.m. UTC | #1 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of lboccass@brocade.com
> Sent: Friday, June 23, 2017 7:42 PM
> To: dev@dpdk.org
> Cc: Luca Boccassi <luca.boccassi@gmail.com>
> Subject: [dpdk-dev] [PATCH v3 4/8] mk: sort list of files in examples.dox
> 
> From: Luca Boccassi <luca.boccassi@gmail.com>
> 
> The result of find might not be stable depending on external conditions.
> Pipe it through LC_ALL=C sort to ensure reproducible results when
> generating examples.dox.
> 
> Signed-off-by: Luca Boccassi <luca.boccassi@gmail.com>

Acked-by: John McNamara <john.mcnamara@intel.com>
John McNamara June 26, 2017, 2:56 p.m. UTC | #2 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Mcnamara, John
> Sent: Monday, June 26, 2017 3:49 PM
> To: lboccass@brocade.com; dev@dpdk.org
> Cc: Luca Boccassi <luca.boccassi@gmail.com>
> Subject: Re: [dpdk-dev] [PATCH v3 4/8] mk: sort list of files in
> examples.dox
> 
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of
> > lboccass@brocade.com
> > Sent: Friday, June 23, 2017 7:42 PM
> > To: dev@dpdk.org
> > Cc: Luca Boccassi <luca.boccassi@gmail.com>
> > Subject: [dpdk-dev] [PATCH v3 4/8] mk: sort list of files in
> > examples.dox
> >
> > From: Luca Boccassi <luca.boccassi@gmail.com>
> >
> > The result of find might not be stable depending on external conditions.
> > Pipe it through LC_ALL=C sort to ensure reproducible results when
> > generating examples.dox.
> >
> > Signed-off-by: Luca Boccassi <luca.boccassi@gmail.com>
> 
> Acked-by: John McNamara <john.mcnamara@intel.com>
> 

P.S. Could you mark the older versions of this patchset as Superseded in Patchwork. Thanks.

http://dpdk.org/dev/patchwork/project/dpdk/list/?submitter=566
diff mbox

Patch

diff --git a/mk/rte.sdkdoc.mk b/mk/rte.sdkdoc.mk
index c0eaa3502..de31b78cf 100644
--- a/mk/rte.sdkdoc.mk
+++ b/mk/rte.sdkdoc.mk
@@ -93,7 +93,7 @@  $(API_EXAMPLES): api-html-clean
 	$(Q)mkdir -p $(@D)
 	@printf '/**\n' > $(API_EXAMPLES)
 	@printf '@page examples DPDK Example Programs\n\n' >> $(API_EXAMPLES)
-	@find examples -type f -name '*.c' -printf '@example %p\n' >> $(API_EXAMPLES)
+	@find examples -type f -name '*.c' -printf '@example %p\n' | LC_ALL=C sort >> $(API_EXAMPLES)
 	@printf '*/\n' >> $(API_EXAMPLES)
 
 guides-pdf-clean: guides-pdf-img-clean