[dpdk-dev,v3,2/8] mk: fix excluding .doctrees when installing docs
diff mbox

Message ID 20170623184153.24488-3-lboccass@brocade.com
State Accepted, archived
Headers show

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Luca Boccassi June 23, 2017, 6:41 p.m. UTC
From: Luca Boccassi <luca.boccassi@gmail.com>

The --exclude parameter must be passed before the input directory to
tar, otherwise it's silently ignored and the .doctrees directory is
installed by make install-doc.

Signed-off-by: Luca Boccassi <luca.boccassi@gmail.com>
---
 mk/rte.sdkinstall.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mcnamara, John June 26, 2017, 2:46 p.m. UTC | #1
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of lboccass@brocade.com
> Sent: Friday, June 23, 2017 7:42 PM
> To: dev@dpdk.org
> Cc: Luca Boccassi <luca.boccassi@gmail.com>
> Subject: [dpdk-dev] [PATCH v3 2/8] mk: fix excluding .doctrees when
> installing docs
> 
> From: Luca Boccassi <luca.boccassi@gmail.com>
> 
> The --exclude parameter must be passed before the input directory to tar,
> otherwise it's silently ignored and the .doctrees directory is installed
> by make install-doc.
> 
> Signed-off-by: Luca Boccassi <luca.boccassi@gmail.com>


Nice fixes.

Acked-by: John McNamara <john.mcnamara@intel.com>

Patch
diff mbox

diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk
index dbac2a277..4e97feff9 100644
--- a/mk/rte.sdkinstall.mk
+++ b/mk/rte.sdkinstall.mk
@@ -162,7 +162,7 @@  install-sdk:
 install-doc:
 ifneq ($(wildcard $O/doc/html),)
 	$(Q)$(call rte_mkdir, $(DESTDIR)$(docdir))
-	$(Q)tar -cf -      -C $O/doc html --exclude 'html/guides/.*' | \
+	$(Q)tar -cf -      -C $O/doc --exclude 'html/guides/.*' html | \
 	    tar -xf -      -C $(DESTDIR)$(docdir) --strip-components=1 \
 		--keep-newer-files
 endif