diff mbox

[dpdk-dev] bnxt: Add new device ids

Message ID 20170425215315.6167-1-ajit.khaparde@broadcom.com (mailing list archive)
State Superseded, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Ajit Khaparde April 25, 2017, 9:53 p.m. UTC 
  Add support for new device ids.

Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
 drivers/net/bnxt/bnxt_ethdev.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Ferruh Yigit April 26, 2017, 8:52 a.m. UTC | #1 
On 4/25/2017 10:53 PM, Ajit Khaparde wrote:
> Add support for new device ids.

Hi Ajit,

Is NIC documentation (doc/guides/nics/bnxt.rst) needs to get updated for
these new devices?

Also if http://dpdk.org/doc/nics needs update please send another web patch.

Thanks,
ferruh

> 
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> ---
>  drivers/net/bnxt/bnxt_ethdev.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
> index 5dc3ff0..7805221 100644
> --- a/drivers/net/bnxt/bnxt_ethdev.c
> +++ b/drivers/net/bnxt/bnxt_ethdev.c
> @@ -60,6 +60,8 @@ static const char bnxt_version[] =
>  
>  #define PCI_VENDOR_ID_BROADCOM 0x14E4
>  
> +#define BROADCOM_DEV_ID_STRATUS_NIC 0x1614
> +#define BROADCOM_DEV_ID_57414_VF 0x16c1
>  #define BROADCOM_DEV_ID_57301 0x16c8
>  #define BROADCOM_DEV_ID_57302 0x16c9
>  #define BROADCOM_DEV_ID_57304_PF 0x16ca
> @@ -94,6 +96,8 @@ static const char bnxt_version[] =
>  #define BROADCOM_DEV_ID_57416_MF 0x16ee
>  
>  static const struct rte_pci_id bnxt_pci_id_map[] = {
> +	{ RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_STRATUS_NIC) },
> +	{ RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57414_VF) },
>  	{ RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57301) },
>  	{ RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57302) },
>  	{ RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57304_PF) },
>
Ajit Khaparde April 26, 2017, 6:41 p.m. UTC | #2 
On Wed, Apr 26, 2017 at 3:52 AM, Ferruh Yigit <ferruh.yigit@intel.com>
wrote:

> On 4/25/2017 10:53 PM, Ajit Khaparde wrote:
> > Add support for new device ids.
>
> Hi Ajit,
>
> Is NIC documentation (doc/guides/nics/bnxt.rst) needs to get updated for
> these new devices?
>
​Yes. It will need a small change. Do you want me to ​resend this patch
along with that?
Otherwise I will just send the update to bnxt.rst

Thanks

>
> Also if http://dpdk.org/doc/nics needs update please send another web
> patch.
>
> Thanks,
> ferruh
>
> >
> > Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> > ---
> >  drivers/net/bnxt/bnxt_ethdev.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_
> ethdev.c
> > index 5dc3ff0..7805221 100644
> > --- a/drivers/net/bnxt/bnxt_ethdev.c
> > +++ b/drivers/net/bnxt/bnxt_ethdev.c
> > @@ -60,6 +60,8 @@ static const char bnxt_version[] =
> >
> >  #define PCI_VENDOR_ID_BROADCOM 0x14E4
> >
> > +#define BROADCOM_DEV_ID_STRATUS_NIC 0x1614
> > +#define BROADCOM_DEV_ID_57414_VF 0x16c1
> >  #define BROADCOM_DEV_ID_57301 0x16c8
> >  #define BROADCOM_DEV_ID_57302 0x16c9
> >  #define BROADCOM_DEV_ID_57304_PF 0x16ca
> > @@ -94,6 +96,8 @@ static const char bnxt_version[] =
> >  #define BROADCOM_DEV_ID_57416_MF 0x16ee
> >
> >  static const struct rte_pci_id bnxt_pci_id_map[] = {
> > +     { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM,
> BROADCOM_DEV_ID_STRATUS_NIC) },
> > +     { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM,
> BROADCOM_DEV_ID_57414_VF) },
> >       { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57301) },
> >       { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57302) },
> >       { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM,
> BROADCOM_DEV_ID_57304_PF) },
> >
>
>
Ferruh Yigit April 26, 2017, 7:01 p.m. UTC | #3 
On 4/26/2017 7:41 PM, Ajit Khaparde wrote:
> 
> On Wed, Apr 26, 2017 at 3:52 AM, Ferruh Yigit <ferruh.yigit@intel.com
> <mailto:ferruh.yigit@intel.com>> wrote:
> 
>     On 4/25/2017 10:53 PM, Ajit Khaparde wrote:
>     > Add support for new device ids.
> 
>     Hi Ajit,
> 
>     Is NIC documentation (doc/guides/nics/bnxt.rst) needs to get updated for
>     these new devices?
> 
> ​Yes. It will need a small change. Do you want me to ​resend this patch
> along with that?
> Otherwise I will just send the update to bnxt.rst

Please resend this patch to have document update.

Is a separate web patch also required?

> 
> Thanks
> 
> 
>     Also if http://dpdk.org/doc/nics needs update please send another
>     web patch.
> 
>     Thanks,
>     ferruh
> 
>     >
>     > Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com
>     <mailto:ajit.khaparde@broadcom.com>>
>     > ---
>     >  drivers/net/bnxt/bnxt_ethdev.c | 4 ++++
>     >  1 file changed, 4 insertions(+)
>     >
>     > diff --git a/drivers/net/bnxt/bnxt_ethdev.c
>     b/drivers/net/bnxt/bnxt_ethdev.c
>     > index 5dc3ff0..7805221 100644
>     > --- a/drivers/net/bnxt/bnxt_ethdev.c
>     > +++ b/drivers/net/bnxt/bnxt_ethdev.c
>     > @@ -60,6 +60,8 @@ static const char bnxt_version[] =
>     >
>     >  #define PCI_VENDOR_ID_BROADCOM 0x14E4
>     >
>     > +#define BROADCOM_DEV_ID_STRATUS_NIC 0x1614
>     > +#define BROADCOM_DEV_ID_57414_VF 0x16c1
>     >  #define BROADCOM_DEV_ID_57301 0x16c8
>     >  #define BROADCOM_DEV_ID_57302 0x16c9
>     >  #define BROADCOM_DEV_ID_57304_PF 0x16ca
>     > @@ -94,6 +96,8 @@ static const char bnxt_version[] =
>     >  #define BROADCOM_DEV_ID_57416_MF 0x16ee
>     >
>     >  static const struct rte_pci_id bnxt_pci_id_map[] = {
>     > +     { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM,
>     BROADCOM_DEV_ID_STRATUS_NIC) },
>     > +     { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM,
>     BROADCOM_DEV_ID_57414_VF) },
>     >       { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM,
>     BROADCOM_DEV_ID_57301) },
>     >       { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM,
>     BROADCOM_DEV_ID_57302) },
>     >       { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM,
>     BROADCOM_DEV_ID_57304_PF) },
>     >
> 
>
Ajit Khaparde April 26, 2017, 7:02 p.m. UTC | #4 
On Wed, Apr 26, 2017 at 2:01 PM, Ferruh Yigit <ferruh.yigit@intel.com>
wrote:

> On 4/26/2017 7:41 PM, Ajit Khaparde wrote:
> >
> > On Wed, Apr 26, 2017 at 3:52 AM, Ferruh Yigit <ferruh.yigit@intel.com
> > <mailto:ferruh.yigit@intel.com>> wrote:
> >
> >     On 4/25/2017 10:53 PM, Ajit Khaparde wrote:
> >     > Add support for new device ids.
> >
> >     Hi Ajit,
> >
> >     Is NIC documentation (doc/guides/nics/bnxt.rst) needs to get updated
> for
> >     these new devices?
> >
> > ​Yes. It will need a small change. Do you want me to ​resend this patch
> > along with that?
> > Otherwise I will just send the update to bnxt.rst
>
> Please resend this patch to have document update.
>
> Is a separate web patch also required?
>
​No Ferruh. It is not required.
​

>
> >
> > Thanks
> >
> >
> >     Also if http://dpdk.org/doc/nics needs update please send another
> >     web patch.
> >
> >     Thanks,
> >     ferruh
> >
> >     >
> >     > Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com
> >     <mailto:ajit.khaparde@broadcom.com>>
> >     > ---
> >     >  drivers/net/bnxt/bnxt_ethdev.c | 4 ++++
> >     >  1 file changed, 4 insertions(+)
> >     >
> >     > diff --git a/drivers/net/bnxt/bnxt_ethdev.c
> >     b/drivers/net/bnxt/bnxt_ethdev.c
> >     > index 5dc3ff0..7805221 100644
> >     > --- a/drivers/net/bnxt/bnxt_ethdev.c
> >     > +++ b/drivers/net/bnxt/bnxt_ethdev.c
> >     > @@ -60,6 +60,8 @@ static const char bnxt_version[] =
> >     >
> >     >  #define PCI_VENDOR_ID_BROADCOM 0x14E4
> >     >
> >     > +#define BROADCOM_DEV_ID_STRATUS_NIC 0x1614
> >     > +#define BROADCOM_DEV_ID_57414_VF 0x16c1
> >     >  #define BROADCOM_DEV_ID_57301 0x16c8
> >     >  #define BROADCOM_DEV_ID_57302 0x16c9
> >     >  #define BROADCOM_DEV_ID_57304_PF 0x16ca
> >     > @@ -94,6 +96,8 @@ static const char bnxt_version[] =
> >     >  #define BROADCOM_DEV_ID_57416_MF 0x16ee
> >     >
> >     >  static const struct rte_pci_id bnxt_pci_id_map[] = {
> >     > +     { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM,
> >     BROADCOM_DEV_ID_STRATUS_NIC) },
> >     > +     { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM,
> >     BROADCOM_DEV_ID_57414_VF) },
> >     >       { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM,
> >     BROADCOM_DEV_ID_57301) },
> >     >       { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM,
> >     BROADCOM_DEV_ID_57302) },
> >     >       { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM,
> >     BROADCOM_DEV_ID_57304_PF) },
> >     >
> >
> >
>
>
diff mbox

Patch

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 5dc3ff0..7805221 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -60,6 +60,8 @@  static const char bnxt_version[] =
 
 #define PCI_VENDOR_ID_BROADCOM 0x14E4
 
+#define BROADCOM_DEV_ID_STRATUS_NIC 0x1614
+#define BROADCOM_DEV_ID_57414_VF 0x16c1
 #define BROADCOM_DEV_ID_57301 0x16c8
 #define BROADCOM_DEV_ID_57302 0x16c9
 #define BROADCOM_DEV_ID_57304_PF 0x16ca
@@ -94,6 +96,8 @@  static const char bnxt_version[] =
 #define BROADCOM_DEV_ID_57416_MF 0x16ee
 
 static const struct rte_pci_id bnxt_pci_id_map[] = {
+	{ RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_STRATUS_NIC) },
+	{ RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57414_VF) },
 	{ RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57301) },
 	{ RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57302) },
 	{ RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57304_PF) },