[dpdk-dev] ixgbe: initialize link status on initialization

Message ID 20141227094135.680f211a@urahara (mailing list archive)
State Accepted, archived
Headers

Commit Message

Stephen Hemminger Dec. 27, 2014, 5:41 p.m. UTC
  The link_status variable is not set when device is initialized.
This can lead to problems with link never being reported as up
if using some SFP modules where the link is instantly on.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
  

Comments

Thomas Monjalon Jan. 27, 2015, 12:10 p.m. UTC | #1
> The link_status variable is not set when device is initialized.
> This can lead to problems with link never being reported as up
> if using some SFP modules where the link is instantly on.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Applied

Thanks
  

Patch

--- a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
+++ b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
@@ -1314,6 +1314,8 @@ 
 	err = ixgbe_check_link(hw, &speed, &link_up, 0);
 	if (err)
 		goto error;
+	dev->data->dev_link.link_status = link_up;
+
 	err = ixgbe_get_link_capabilities(hw, &speed, &negotiate);
 	if (err)
 		goto error;