[dpdk-dev,v4,04/17] net/avp: add PMD version map file
Checks
Commit Message
Adds a default ABI version file for the AVP PMD.
Signed-off-by: Allain Legacy <allain.legacy@windriver.com>
Signed-off-by: Matt Peters <matt.peters@windriver.com>
---
drivers/net/avp/rte_pmd_avp_version.map | 4 ++++
1 file changed, 4 insertions(+)
create mode 100644 drivers/net/avp/rte_pmd_avp_version.map
Comments
On 3/13/2017 7:16 PM, Allain Legacy wrote:
> Adds a default ABI version file for the AVP PMD.
>
> Signed-off-by: Allain Legacy <allain.legacy@windriver.com>
> Signed-off-by: Matt Peters <matt.peters@windriver.com>
> ---
> drivers/net/avp/rte_pmd_avp_version.map | 4 ++++
> 1 file changed, 4 insertions(+)
> create mode 100644 drivers/net/avp/rte_pmd_avp_version.map
>
> diff --git a/drivers/net/avp/rte_pmd_avp_version.map b/drivers/net/avp/rte_pmd_avp_version.map
> new file mode 100644
> index 0000000..af8f3f4
> --- /dev/null
> +++ b/drivers/net/avp/rte_pmd_avp_version.map
> @@ -0,0 +1,4 @@
> +DPDK_17.05 {
> +
> + local: *;
> +};
>
Hi Allain,
Instead of adding files per patch, may I suggest different ordering:
First add skeleton files in a patch, later add functional pieces one by
one, like:
Merge patch 1/17, 3/17, this patch (4/17), 6/17 (removing SYMLINK), into
single patch and make it AVP first patch. This will be skeleton patch.
Second patch can be introducing public headers (2/17) and updating
Makefile to include them.
Third, debug log patch (5/17)
Patch 7/17 and later can stay same.
What do you think?
> -----Original Message-----
> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
> Sent: Thursday, March 16, 2017 10:53 AM
<..>
> Hi Allain,
>
> Instead of adding files per patch, may I suggest different ordering:
> First add skeleton files in a patch, later add functional pieces one by one, like:
>
> Merge patch 1/17, 3/17, this patch (4/17), 6/17 (removing SYMLINK), into
> single patch and make it AVP first patch. This will be skeleton patch.
>
> Second patch can be introducing public headers (2/17) and updating Makefile
> to include them.
>
> Third, debug log patch (5/17)
>
> Patch 7/17 and later can stay same.
>
> What do you think?
Sure, I can give that a go and see what it looks like.
new file mode 100644
@@ -0,0 +1,4 @@
+DPDK_17.05 {
+
+ local: *;
+};