[dpdk-dev] mk: remove default toolchain prefix for ThunderX

Message ID 1485162957-2497-1-git-send-email-thomas.monjalon@6wind.com
State Accepted, archived
Headers show

Checks

Context Check Description
ci/Intel compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Thomas Monjalon Jan. 23, 2017, 9:15 a.m.
The environment variable CROSS must be set when using a cross-toolchain.
However it is counter intuitive to set a default value, considering
the toolchain required to build this architecture is well known.
It is especially weird when using a native toolchain and requiring to
unset this variable on the command line.

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
 mk/machine/thunderx/rte.vars.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jerin Jacob Jan. 23, 2017, 9:39 a.m. | #1
On Mon, Jan 23, 2017 at 10:15:57AM +0100, Thomas Monjalon wrote:
> The environment variable CROSS must be set when using a cross-toolchain.
> However it is counter intuitive to set a default value, considering
> the toolchain required to build this architecture is well known.
> It is especially weird when using a native toolchain and requiring to
> unset this variable on the command line.
> 
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Reviewed-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

> ---
>  mk/machine/thunderx/rte.vars.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mk/machine/thunderx/rte.vars.mk b/mk/machine/thunderx/rte.vars.mk
> index 81da1b4..ad5a379 100644
> --- a/mk/machine/thunderx/rte.vars.mk
> +++ b/mk/machine/thunderx/rte.vars.mk
> @@ -47,7 +47,7 @@
>  #
>  
>  # ARCH =
> -CROSS ?= aarch64-thunderx-linux-gnu-
> +# CROSS =
>  # MACHINE_CFLAGS =
>  # MACHINE_LDFLAGS =
>  # MACHINE_ASFLAGS =
> -- 
> 2.7.0
>
Thomas Monjalon Jan. 29, 2017, 2:51 p.m. | #2
2017-01-23 15:09, Jerin Jacob:
> On Mon, Jan 23, 2017 at 10:15:57AM +0100, Thomas Monjalon wrote:
> > The environment variable CROSS must be set when using a cross-toolchain.
> > However it is counter intuitive to set a default value, considering
> > the toolchain required to build this architecture is well known.
> > It is especially weird when using a native toolchain and requiring to
> > unset this variable on the command line.
> > 
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> 
> Reviewed-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

Applied

Patch

diff --git a/mk/machine/thunderx/rte.vars.mk b/mk/machine/thunderx/rte.vars.mk
index 81da1b4..ad5a379 100644
--- a/mk/machine/thunderx/rte.vars.mk
+++ b/mk/machine/thunderx/rte.vars.mk
@@ -47,7 +47,7 @@ 
 #
 
 # ARCH =
-CROSS ?= aarch64-thunderx-linux-gnu-
+# CROSS =
 # MACHINE_CFLAGS =
 # MACHINE_LDFLAGS =
 # MACHINE_ASFLAGS =