From patchwork Mon Jan 23 03:32:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Zhao1, Wei" X-Patchwork-Id: 19865 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id F37F55424; Mon, 23 Jan 2017 04:37:23 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 851E94CC5 for ; Mon, 23 Jan 2017 04:37:21 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 22 Jan 2017 19:37:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos; i="5.33,272,1477983600"; d="scan'208"; a="1086097060" Received: from dpdk1.bj.intel.com ([172.16.182.84]) by orsmga001.jf.intel.com with ESMTP; 22 Jan 2017 19:37:19 -0800 From: Wei Zhao To: dev@dpdk.org Cc: zhao wei Date: Mon, 23 Jan 2017 11:32:20 +0800 Message-Id: <1485142340-49032-1-git-send-email-wei.zhao1@intel.com> X-Mailer: git-send-email 2.5.5 Subject: [dpdk-dev] [PATCH v1] net/ixgbe: add more check in n-tuple filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add more check on the mask of src_addr, dst_addr and next_proto_id in n-tuple filter rule pattern parser.If do not add such check, it maybe cause error in pattern parser. Signed-off-by: zhao wei --- drivers/net/ixgbe/ixgbe_flow.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c index 82aceed..8f78eee 100644 --- a/drivers/net/ixgbe/ixgbe_flow.c +++ b/drivers/net/ixgbe/ixgbe_flow.c @@ -331,7 +331,10 @@ cons_parse_ntuple_filter(const struct rte_flow_attr *attr, ipv4_mask->hdr.packet_id || ipv4_mask->hdr.fragment_offset || ipv4_mask->hdr.time_to_live || - ipv4_mask->hdr.hdr_checksum) { + ipv4_mask->hdr.hdr_checksum || + !ipv4_mask->hdr.next_proto_id || + !ipv4_mask->hdr.dst_addr || + !ipv4_mask->hdr.src_addr ||) { rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ITEM, item, "Not supported by ntuple filter");