[dpdk-dev,v2] net/mlx5: lift Rx RSS indirection table size limit
diff mbox

Message ID 20170118003929.35295-1-yskoh@mellanox.com
State Accepted, archived
Delegated to: Ferruh Yigit
Headers show

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel compilation success Compilation OK

Commit Message

Yongseok Koh Jan. 18, 2017, 12:39 a.m. UTC
The size of Rx RSS indirection table was limited by 256, but it is not
required anymore for all Mellanox NICs. However, the librte_ether still
limits the size by 512.

Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
---
 drivers/net/mlx5/mlx5.c      | 5 +++--
 drivers/net/mlx5/mlx5_defs.h | 3 ---
 2 files changed, 3 insertions(+), 5 deletions(-)

Comments

Adrien Mazarguil Jan. 20, 2017, 4:57 p.m. UTC | #1
On Tue, Jan 17, 2017 at 04:39:29PM -0800, Yongseok Koh wrote:
> The size of Rx RSS indirection table was limited by 256, but it is not
> required anymore for all Mellanox NICs. However, the librte_ether still
> limits the size by 512.
> 
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> ---
>  drivers/net/mlx5/mlx5.c      | 5 +++--
>  drivers/net/mlx5/mlx5_defs.h | 3 ---
>  2 files changed, 3 insertions(+), 5 deletions(-)

Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Ferruh Yigit Jan. 20, 2017, 6:42 p.m. UTC | #2
On 1/20/2017 4:57 PM, Adrien Mazarguil wrote:
> On Tue, Jan 17, 2017 at 04:39:29PM -0800, Yongseok Koh wrote:
>> The size of Rx RSS indirection table was limited by 256, but it is not
>> required anymore for all Mellanox NICs. However, the librte_ether still
>> limits the size by 512.
>>
>> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
>> ---
>>  drivers/net/mlx5/mlx5.c      | 5 +++--
>>  drivers/net/mlx5/mlx5_defs.h | 3 ---
>>  2 files changed, 3 insertions(+), 5 deletions(-)
> 
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

Applied to dpdk-next-net/master, thanks.

Patch
diff mbox

diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index 7d40b2445..109d9572d 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -557,8 +557,9 @@  mlx5_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)
 		priv->ind_table_max_size = exp_device_attr.rx_hash_caps.max_rwq_indirection_table_size;
 		/* Remove this check once DPDK supports larger/variable
 		 * indirection tables. */
-		if (priv->ind_table_max_size > (unsigned int)RSS_INDIRECTION_TABLE_SIZE)
-			priv->ind_table_max_size = RSS_INDIRECTION_TABLE_SIZE;
+		if (priv->ind_table_max_size >
+				(unsigned int)ETH_RSS_RETA_SIZE_512)
+			priv->ind_table_max_size = ETH_RSS_RETA_SIZE_512;
 		DEBUG("maximum RX indirection table size is %u",
 		      priv->ind_table_max_size);
 		priv->hw_vlan_strip = !!(exp_device_attr.wq_vlan_offloads_cap &
diff --git a/drivers/net/mlx5/mlx5_defs.h b/drivers/net/mlx5/mlx5_defs.h
index beabb7037..e91d2454a 100644
--- a/drivers/net/mlx5/mlx5_defs.h
+++ b/drivers/net/mlx5/mlx5_defs.h
@@ -54,9 +54,6 @@ 
  */
 #define MLX5_TX_COMP_THRESH 32
 
-/* RSS Indirection table size. */
-#define RSS_INDIRECTION_TABLE_SIZE 256
-
 /*
  * Maximum number of cached Memory Pools (MPs) per TX queue. Each RTE MP
  * from which buffers are to be transmitted will have to be mapped by this