[dpdk-dev] net/qede: correct function declaration syntax

Message ID 1484509884-16148-1-git-send-email-emmanuel.roullit@gmail.com
State Accepted, archived
Delegated to: Ferruh Yigit
Headers show

Checks

Context Check Description
ci/Intel compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Emmanuel Roullit Jan. 15, 2017, 7:51 p.m.
clang reports this error message:
error: this function declaration is not a prototype
[-Werror,-Wstrict-prototypes]

Signed-off-by: Emmanuel Roullit <emmanuel.roullit@gmail.com>
---
 drivers/net/qede/qede_eth_if.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ferruh Yigit Jan. 16, 2017, 9:06 a.m. | #1
Hi Emmanuel,

On 1/15/2017 7:51 PM, Emmanuel Roullit wrote:
> clang reports this error message:
> error: this function declaration is not a prototype
> [-Werror,-Wstrict-prototypes]

What is the clang version?

Thanks,
ferruh
Ferruh Yigit Jan. 16, 2017, 1 p.m. | #2
On 1/15/2017 7:51 PM, Emmanuel Roullit wrote:
> clang reports this error message:
> error: this function declaration is not a prototype
> [-Werror,-Wstrict-prototypes]
> 
> Signed-off-by: Emmanuel Roullit <emmanuel.roullit@gmail.com>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Ferruh Yigit Jan. 16, 2017, 1:17 p.m. | #3
On 1/16/2017 1:00 PM, Ferruh Yigit wrote:
> On 1/15/2017 7:51 PM, Emmanuel Roullit wrote:
>> clang reports this error message:
>> error: this function declaration is not a prototype
>> [-Werror,-Wstrict-prototypes]
>>
>> Signed-off-by: Emmanuel Roullit <emmanuel.roullit@gmail.com>
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Fixes: 5cdd769a26ec ("qede: add L2 support")

CC: stable@dpdk.org

Applied to dpdk-next-net/master, thanks.

Patch

diff --git a/drivers/net/qede/qede_eth_if.h b/drivers/net/qede/qede_eth_if.h
index 33655c3..74e17f8 100644
--- a/drivers/net/qede/qede_eth_if.h
+++ b/drivers/net/qede/qede_eth_if.h
@@ -171,7 +171,7 @@  struct qed_eth_ops {
 
 extern const struct qed_common_ops qed_common_ops_pass;
 
-const struct qed_eth_ops *qed_get_eth_ops();
+const struct qed_eth_ops *qed_get_eth_ops(void);
 
 int qed_configure_filter_rx_mode(struct ecore_dev *edev,
 				 enum qed_filter_rx_mode_type type);