From patchwork Sun Jan 8 15:42:00 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Elad Persiko X-Patchwork-Id: 19005 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id AE704F6D2; Sun, 8 Jan 2017 16:42:47 +0100 (CET) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id F248CD586 for ; Sun, 8 Jan 2017 16:42:33 +0100 (CET) Received: from Internal Mail-Server by MTLPINE1 (envelope-from eladpe@mellanox.com) with ESMTPS (AES256-SHA encrypted); 8 Jan 2017 17:42:29 +0200 Received: from r-aa-dragon21.mtr.labs.mlnx (r-aa-dragon21.mtr.labs.mlnx [10.209.68.158]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id v08FgTjs007965; Sun, 8 Jan 2017 17:42:29 +0200 Received: from r-aa-dragon21.mtr.labs.mlnx (localhost [127.0.0.1]) by r-aa-dragon21.mtr.labs.mlnx (8.14.7/8.14.7) with ESMTP id v08FgTVb004910; Sun, 8 Jan 2017 15:42:29 GMT Received: (from eladpe@localhost) by r-aa-dragon21.mtr.labs.mlnx (8.14.7/8.14.7/Submit) id v08FgTrZ004909; Sun, 8 Jan 2017 15:42:29 GMT From: Elad Persiko To: dev@dpdk.org Cc: Elad Persiko Date: Sun, 8 Jan 2017 15:42:00 +0000 Message-Id: <1483890123-4854-2-git-send-email-eladpe@mellanox.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1483890123-4854-1-git-send-email-eladpe@mellanox.com> References: <1483890123-4854-1-git-send-email-eladpe@mellanox.com> Subject: [dpdk-dev] [PATCH 2/5] net/mlx5: remove unessecary goto label X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" use_dseg label can be deleted as it happens without goto. Signed-off-by: Elad Persiko Reviewed-by: Ferruh Yigit --- drivers/net/mlx5/mlx5_rxtx.c | 24 +++++++++++------------- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c index be38aed..1560530 100644 --- a/drivers/net/mlx5/mlx5_rxtx.c +++ b/drivers/net/mlx5/mlx5_rxtx.c @@ -505,7 +505,6 @@ if ((uintptr_t)dseg >= end) dseg = (volatile rte_v128u32_t *) txq->wqes; - goto use_dseg; } else if (!segs_n) { goto next_pkt; } else { @@ -523,19 +522,18 @@ dseg = (volatile rte_v128u32_t *) ((uintptr_t)wqe + (3 * MLX5_WQE_DWORD_SIZE)); ds = 3; -use_dseg: - /* Add the remaining packet as a simple ds. */ - addr = htonll(addr); - *dseg = (rte_v128u32_t){ - htonl(length), - txq_mp2mr(txq, txq_mb2mp(buf)), - addr, - addr >> 32, - }; - ++ds; - if (!segs_n) - goto next_pkt; } + /* Add the remaining packet as a simple ds. */ + addr = htonll(addr); + *dseg = (rte_v128u32_t){ + htonl(length), + txq_mp2mr(txq, txq_mb2mp(buf)), + addr, + addr >> 32, + }; + ++ds; + if (!segs_n) + goto next_pkt; next_seg: assert(buf); assert(ds);