[dpdk-dev] eal: fix remaining checks for other 64bits architectures
Commit Message
RTE_ARCH_X86_64 can not be used as a way to determine if we are building for
64bits cpus. Instead, RTE_ARCH_64 should be used.
Signed-off-by: David Marchand <david.marchand@6wind.com>
---
lib/librte_eal/linuxapp/eal/eal.c | 2 +-
lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
Comments
Quoting David Marchand <david.marchand@6wind.com>:
> RTE_ARCH_X86_64 can not be used as a way to determine if we are building for
> 64bits cpus. Instead, RTE_ARCH_64 should be used.
>
> Signed-off-by: David Marchand <david.marchand@6wind.com>
> ---
> lib/librte_eal/linuxapp/eal/eal.c | 2 +-
> lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_eal/linuxapp/eal/eal.c
> b/lib/librte_eal/linuxapp/eal/eal.c
> index f9517c7..e321524 100644
> --- a/lib/librte_eal/linuxapp/eal/eal.c
> +++ b/lib/librte_eal/linuxapp/eal/eal.c
> @@ -450,7 +450,7 @@ eal_parse_base_virtaddr(const char *arg)
> return -1;
>
> /* make sure we don't exceed 32-bit boundary on 32-bit target */
> -#ifndef RTE_ARCH_X86_64
> +#ifndef RTE_ARCH_64
> if (addr >= UINTPTR_MAX)
> return -1;
> #endif
> diff --git a/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c
> b/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c
> index 73d1cdb..590cb56 100644
> --- a/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c
> +++ b/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c
> @@ -324,7 +324,7 @@ eal_hugepage_info_init(void)
> * later they will be sorted */
> hpi->num_pages[0] = get_num_hugepages(dirent->d_name);
>
> -#ifndef RTE_ARCH_X86_64
> +#ifndef RTE_ARCH_64
> /* for 32-bit systems, limit number of hugepages to 1GB per page size */
> hpi->num_pages[0] = RTE_MIN(hpi->num_pages[0],
> RTE_PGSIZE_1G / hpi->hugepage_sz);
> --
> 1.7.10.4
Acked-by: Chao Zhu <chaozhu@linux.vnet.ibm.com>
> > RTE_ARCH_X86_64 can not be used as a way to determine if we are building for
> > 64bits cpus. Instead, RTE_ARCH_64 should be used.
> >
> > Signed-off-by: David Marchand <david.marchand@6wind.com>
>
> Acked-by: Chao Zhu <chaozhu@linux.vnet.ibm.com>
Applied
Thanks
@@ -450,7 +450,7 @@ eal_parse_base_virtaddr(const char *arg)
return -1;
/* make sure we don't exceed 32-bit boundary on 32-bit target */
-#ifndef RTE_ARCH_X86_64
+#ifndef RTE_ARCH_64
if (addr >= UINTPTR_MAX)
return -1;
#endif
@@ -324,7 +324,7 @@ eal_hugepage_info_init(void)
* later they will be sorted */
hpi->num_pages[0] = get_num_hugepages(dirent->d_name);
-#ifndef RTE_ARCH_X86_64
+#ifndef RTE_ARCH_64
/* for 32-bit systems, limit number of hugepages to 1GB per page size */
hpi->num_pages[0] = RTE_MIN(hpi->num_pages[0],
RTE_PGSIZE_1G / hpi->hugepage_sz);