[dpdk-dev] net/enic: increment filter failure counter

Message ID 1468016521-20280-2-git-send-email-johndale@cisco.com (mailing list archive)
State Accepted, archived
Delegated to: Bruce Richardson
Headers

Commit Message

John Daley (johndale) July 8, 2016, 10:22 p.m. UTC
  One instance of a filter add failure was not incrementing the
the fail counter.

Fixes: 4c2c7bf41f5a ("net/enic: fix negative array index write")
Signed-off-by: John Daley <johndale@cisco.com>
---
 drivers/net/enic/enic_clsf.c | 1 +
 1 file changed, 1 insertion(+)
  

Comments

Thomas Monjalon July 15, 2016, 9:26 p.m. UTC | #1
2016-07-08 15:22, John Daley:
> One instance of a filter add failure was not incrementing the
> the fail counter.
> 
> Fixes: 4c2c7bf41f5a ("net/enic: fix negative array index write")
> Signed-off-by: John Daley <johndale@cisco.com>

Applied, thanks
  

Patch

diff --git a/drivers/net/enic/enic_clsf.c b/drivers/net/enic/enic_clsf.c
index 3365176..e6f57be 100644
--- a/drivers/net/enic/enic_clsf.c
+++ b/drivers/net/enic/enic_clsf.c
@@ -218,6 +218,7 @@  int enic_fdir_add_fltr(struct enic *enic, struct rte_eth_fdir_filter *params)
 
 	pos = rte_hash_add_key(enic->fdir.hash, params);
 	if (pos < 0) {
+		enic->fdir.stats.f_add++;
 		dev_err(enic, "Add hash key failed\n");
 		return pos;
 	}