diff mbox

[dpdk-dev] bnxt: Fix a bug in broadcast/multicast setting

Message ID 1467658324-15875-1-git-send-email-ajit.khaparde@broadcom.com (mailing list archive)
State Accepted, archived
Delegated to: Bruce Richardson
Headers

Commit Message

Ajit Khaparde July 4, 2016, 6:52 p.m. UTC 
  Currently we are wrongly setting HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_MCAST
flag in bnxt_hwrm_cfa_l2_set_rx_mask() which is preventing promiscuous
and multicast promiscuous settings from working correctly.
This patch fixes it.

Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
 drivers/net/bnxt/bnxt_hwrm.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Bruce Richardson July 8, 2016, 1:33 p.m. UTC | #1 
On Mon, Jul 04, 2016 at 01:52:04PM -0500, Ajit Khaparde wrote:
> Currently we are wrongly setting HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_MCAST
> flag in bnxt_hwrm_cfa_l2_set_rx_mask() which is preventing promiscuous
> and multicast promiscuous settings from working correctly.
> This patch fixes it.
> 
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>

Fixes: 244bc98b0da7 ("net/bnxt: set L2 Rx mask")

Applied to dpdk-next-net/rel_16_07

/Bruce
diff mbox

Patch

diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
index 5d81a60..2ed4c2f 100644
--- a/drivers/net/bnxt/bnxt_hwrm.c
+++ b/drivers/net/bnxt/bnxt_hwrm.c
@@ -177,8 +177,7 @@  int bnxt_hwrm_cfa_l2_set_rx_mask(struct bnxt *bp, struct bnxt_vnic_info *vnic)
 		mask = HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_PROMISCUOUS;
 	if (vnic->flags & BNXT_VNIC_INFO_ALLMULTI)
 		mask = HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_ALL_MCAST;
-	req.mask = rte_cpu_to_le_32(HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_MCAST |
-				    HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_BCAST |
+	req.mask = rte_cpu_to_le_32(HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_BCAST |
 				    mask);
 
 	rc = bnxt_hwrm_send_message(bp, &req, sizeof(req));