diff mbox

[dpdk-dev] net/thunderx: add missing external library dependency

Message ID 1467225289-12384-1-git-send-email-ferruh.yigit@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Bruce Richardson
Headers

Commit Message

Ferruh Yigit June 29, 2016, 6:34 p.m. UTC 
  To prevent compile error when compiling for shared library:
nicvf_hw.o: In function `nicvf_qsize_regbit':
nicvf_hw.c:(.text+0xe64): undefined reference to `log2'
nicvf_hw.o: In function `nicvf_rss_reta_update':
nicvf_hw.c:(.text+0x19dd): undefined reference to `log2'
nicvf_hw.o: In function `nicvf_rss_reta_query':
nicvf_hw.c:(.text+0x1acb): undefined reference to `log2'

Fixes: e438796617dc ("net/thunderx: add PMD skeleton")
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 drivers/net/thunderx/Makefile | 2 ++
 1 file changed, 2 insertions(+)

Comments

Jerin Jacob June 30, 2016, 3:32 a.m. UTC | #1 
On Wed, Jun 29, 2016 at 07:34:49PM +0100, Ferruh Yigit wrote:
> To prevent compile error when compiling for shared library:
> nicvf_hw.o: In function `nicvf_qsize_regbit':
> nicvf_hw.c:(.text+0xe64): undefined reference to `log2'
> nicvf_hw.o: In function `nicvf_rss_reta_update':
> nicvf_hw.c:(.text+0x19dd): undefined reference to `log2'
> nicvf_hw.o: In function `nicvf_rss_reta_query':
> nicvf_hw.c:(.text+0x1acb): undefined reference to `log2'
> 
> Fixes: e438796617dc ("net/thunderx: add PMD skeleton")
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Thomas Monjalon June 30, 2016, 9:20 a.m. UTC | #2 
2016-06-30 09:02, Jerin Jacob:
> On Wed, Jun 29, 2016 at 07:34:49PM +0100, Ferruh Yigit wrote:
> > To prevent compile error when compiling for shared library:
> > nicvf_hw.o: In function `nicvf_qsize_regbit':
> > nicvf_hw.c:(.text+0xe64): undefined reference to `log2'
> > nicvf_hw.o: In function `nicvf_rss_reta_update':
> > nicvf_hw.c:(.text+0x19dd): undefined reference to `log2'
> > nicvf_hw.o: In function `nicvf_rss_reta_query':
> > nicvf_hw.c:(.text+0x1acb): undefined reference to `log2'
> > 
> > Fixes: e438796617dc ("net/thunderx: add PMD skeleton")
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

Applied, thanks
diff mbox

Patch

diff --git a/drivers/net/thunderx/Makefile b/drivers/net/thunderx/Makefile
index 078237e..8ea6b45 100644
--- a/drivers/net/thunderx/Makefile
+++ b/drivers/net/thunderx/Makefile
@@ -39,6 +39,8 @@  LIB = librte_pmd_thunderx_nicvf.a
 
 CFLAGS += $(WERROR_FLAGS)
 
+LDLIBS += -lm
+
 EXPORT_MAP := rte_pmd_thunderx_nicvf_version.map
 
 LIBABIVER := 1