Message ID | 20201125191908.1867106-1-ferruh.yigit@intel.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 105E7A0545; Wed, 25 Nov 2020 20:19:21 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5975CC95A; Wed, 25 Nov 2020 20:19:19 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 6D124C956; Wed, 25 Nov 2020 20:19:17 +0100 (CET) IronPort-SDR: GDsVTE9DhZB1NZpMdNp+7dzcGeT8rAgacC7/b6XzB/AKv4xJqB82mw58JaEGvPUA2XPIOgKbxj p2FELL3JltYw== X-IronPort-AV: E=McAfee;i="6000,8403,9816"; a="151447603" X-IronPort-AV: E=Sophos;i="5.78,370,1599548400"; d="scan'208";a="151447603" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Nov 2020 11:19:15 -0800 IronPort-SDR: ov4lBZFMxfVvke6nwWTItYgWqXH+6fqbobm02Cr3Ud4Ks2RhC6n922zjt07zEmj4/3/YTAALS4 gB/R0INf9ntw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,370,1599548400"; d="scan'208";a="547413744" Received: from silpixa00399752.ir.intel.com (HELO silpixa00399752.ger.corp.intel.com) ([10.237.222.180]) by orsmga005.jf.intel.com with ESMTP; 25 Nov 2020 11:19:12 -0800 From: Ferruh Yigit <ferruh.yigit@intel.com> To: Thomas Monjalon <thomas@monjalon.net> Cc: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org, techboard@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>, Bruce Richardson <bruce.richardson@intel.com> Date: Wed, 25 Nov 2020 19:19:02 +0000 Message-Id: <20201125191908.1867106-1-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 0/6] update dpdk-setup.sh X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
update dpdk-setup.sh
|
|
Message
Ferruh Yigit
Nov. 25, 2020, 7:19 p.m. UTC
This is an effort to update the dpdk-setup.sh script and keep it one more year until whole functionality of it is replaced. Other option is to remove it completely, please comment. Ferruh Yigit (6): usertools/setup: remove make based build usertools/setup: remove inserting custom kernel modules usertools/setup: remove running built applications usertools/setup: remove hugepage functions usertools/setup: fix loading vfio module usertools/setup: move removal target to 21.11 doc/guides/rel_notes/deprecation.rst | 2 +- usertools/dpdk-setup.sh | 332 ++------------------------- 2 files changed, 15 insertions(+), 319 deletions(-)
Comments
On 25-Nov-20 7:19 PM, Ferruh Yigit wrote: > This is an effort to update the dpdk-setup.sh script and keep it one > more year until whole functionality of it is replaced. > > Other option is to remove it completely, please comment. This script has been largely unmaintained for a long time, so my personal opinion is that i'd rather see it removed. That said, i know for a fact that users (especially non-expert ones) rely on this script, so removing it without providing a replacement is not practical. This patchset IMO is a good first step towards bringing the script up to date, but more work is needed as current usability of the script is atrocious. > > Ferruh Yigit (6): > usertools/setup: remove make based build > usertools/setup: remove inserting custom kernel modules > usertools/setup: remove running built applications > usertools/setup: remove hugepage functions > usertools/setup: fix loading vfio module > usertools/setup: move removal target to 21.11 > > doc/guides/rel_notes/deprecation.rst | 2 +- > usertools/dpdk-setup.sh | 332 ++------------------------- > 2 files changed, 15 insertions(+), 319 deletions(-) >
27/11/2020 14:57, Burakov, Anatoly: > On 25-Nov-20 7:19 PM, Ferruh Yigit wrote: > > This is an effort to update the dpdk-setup.sh script and keep it one > > more year until whole functionality of it is replaced. > > > > Other option is to remove it completely, please comment. > > This script has been largely unmaintained for a long time, so my > personal opinion is that i'd rather see it removed. > > That said, i know for a fact that users (especially non-expert ones) > rely on this script, so removing it without providing a replacement is > not practical. This patchset IMO is a good first step towards bringing > the script up to date, but more work is needed as current usability of > the script is atrocious. I take it as one more argument to remove as planned in 20.11. Non-expert users should think before using this script. If they absolutely want it back they will take it from old versions, or they will complain, which is a kind of contribution, a first step to think about something better.