mbox series

[v21.02,v3,00/10] cppcheck

Message ID 20201119115900.4095566-1-ferruh.yigit@intel.com (mailing list archive)
Headers
Series cppcheck |

Message

Ferruh Yigit Nov. 19, 2020, 11:58 a.m. UTC 
  Fix a few of issues identified by cppcheck.
There are more to address, cppcheck can be run as:
"cppcheck --enable=all --force ."

These are very trivial issues, I think can be postponed to next release.

Ferruh Yigit (10):
  app/procinfo: fix redundant condition
  app/procinfo: fix negative check on unsigned variable
  app/procinfo: remove suspicious sizeof
  app/procinfo: remove useless assignment
  net/pcap: remove local variable shadowing outer one
  net/bonding: remove local variable shadowing outer one
  net/af_xdp: remove useless assignment
  net/bnxt: fix redundant return
  app/crypto-perf: remove always true condition
  net/avp: remove always true condition

 app/proc-info/main.c                      | 16 +++++-----------
 app/test-crypto-perf/main.c               |  4 ++--
 drivers/net/af_xdp/rte_eth_af_xdp.c       |  1 -
 drivers/net/avp/avp_ethdev.c              |  2 +-
 drivers/net/bnxt/tf_core/tf_em_common.c   |  1 -
 drivers/net/bonding/rte_eth_bond_8023ad.c |  6 ++----
 drivers/net/pcap/rte_eth_pcap.c           |  5 ++---
 7 files changed, 12 insertions(+), 23 deletions(-)

Comments

David Marchand Jan. 11, 2021, 9:47 a.m. UTC | #1 
On Thu, Nov 19, 2020 at 12:59 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> Fix a few of issues identified by cppcheck.
> There are more to address, cppcheck can be run as:
> "cppcheck --enable=all --force ."
>
> These are very trivial issues, I think can be postponed to next release.
>
> Ferruh Yigit (10):
>   app/procinfo: fix redundant condition
>   app/procinfo: fix negative check on unsigned variable
>   app/procinfo: remove suspicious sizeof
>   app/procinfo: remove useless assignment
>   net/pcap: remove local variable shadowing outer one
>   net/bonding: remove local variable shadowing outer one
>   net/af_xdp: remove useless assignment
>   net/bnxt: fix redundant return
>   app/crypto-perf: remove always true condition
>   net/avp: remove always true condition

Fixed style issue in the pcap patch, and applied the series.
Thanks.