mbox series

[v4,0/8] fix distributor synchronization issues

Message ID 20200925224209.12173-1-l.wojciechow@partner.samsung.com (mailing list archive)
Headers
Series fix distributor synchronization issues |

Message

Lukasz Wojciechowski Sept. 25, 2020, 10:42 p.m. UTC
  During review and verification of the patch created by Sarosh Arif:
"test_distributor: prevent memory leakages from the pool" I found out
that running distributor unit tests multiple times in a row causes fails.
So I investigated all the issues I found.

There are few synchronization issues that might cause deadlocks
or corrupted data. They are fixed with this set of patches for both tests
and librte_distributor library.

---
v4:
* adjust commit name prefixes app/test -> test/distributor:
* reorder patches
* use NULL oldpkt in rte_distributor_get_pkt() calls in tests

v3:
* add missing acked and tested by statements from v1

v2:
* assign NULL to freed mbufs in distributor test
* fix handshake check on legacy single distributor
     rte_distributor_return_pkt_single()
* add patch 7 passing NULL to legacy API calls if no bufs are returned
* add patch 8 fixing API documentation

Lukasz Wojciechowski (8):
  test/distributor: fix deadlock with freezed worker
  test/distributor: synchronize lcores statistics
  distributor: do not use oldpkt when not needed
  test/distributor: fix freeing mbufs
  test/distributor: collect return mbufs
  distributor: fix missing handshake synchronization
  distributor: fix handshake deadlock
  distributor: align API documentation with code

 app/test/test_distributor.c                   | 117 ++++++++++--------
 lib/librte_distributor/rte_distributor.c      |  27 +++-
 lib/librte_distributor/rte_distributor.h      |  23 ++--
 .../rte_distributor_single.c                  |   4 +
 4 files changed, 102 insertions(+), 69 deletions(-)