mbox series

[v2,0/3] Bug fixes in event crypto adapter test application

Message ID 20200925072841.17578-1-adwivedi@marvell.com (mailing list archive)
Headers
Series Bug fixes in event crypto adapter test application |

Message

Ankur Dwivedi Sept. 25, 2020, 7:28 a.m. UTC 
  This patch series resolves bugs in the event crypto adapter test
application.

v2:
* In the "test/event_crypto_adapter: return error with unsupported mode"
  patch the following changes were done:
  - Skip mismatch of mode and capability for software eventdev.
  - In test_crypto_adapter_conf_op_new_mode() and
    test_crypto_adapter_conf_op_forward_mode(),the local variable
    for holding return of test_crypto_adapter_conf() is removed.
  - Minor change in commit message.

Ankur Dwivedi (3):
  test/event_crypto_adapter: return error with unsupported mode
  test/event_crypto_adapter: fix function arguments
  test/event_crypto_adapter: free resources during exit

 app/test/test_event_crypto_adapter.c | 66 ++++++++++++++++++++--------
 1 file changed, 47 insertions(+), 19 deletions(-)

Comments

Jerin Jacob Oct. 5, 2020, 9:43 a.m. UTC | #1 
On Fri, Sep 25, 2020 at 12:59 PM Ankur Dwivedi <adwivedi@marvell.com> wrote:
>
> This patch series resolves bugs in the event crypto adapter test
> application.
>
> v2:
> * In the "test/event_crypto_adapter: return error with unsupported mode"
>   patch the following changes were done:
>   - Skip mismatch of mode and capability for software eventdev.
>   - In test_crypto_adapter_conf_op_new_mode() and
>     test_crypto_adapter_conf_op_forward_mode(),the local variable
>     for holding return of test_crypto_adapter_conf() is removed.
>   - Minor change in commit message.

@Gujjar, Abhinandan S ,
Could you review the v2?

>
> Ankur Dwivedi (3):
>   test/event_crypto_adapter: return error with unsupported mode
>   test/event_crypto_adapter: fix function arguments
>   test/event_crypto_adapter: free resources during exit
>
>  app/test/test_event_crypto_adapter.c | 66 ++++++++++++++++++++--------
>  1 file changed, 47 insertions(+), 19 deletions(-)
>
> --
> 2.28.0
>
Gujjar, Abhinandan S Oct. 5, 2020, 9:48 a.m. UTC | #2 
Sure Jerin. I will send the response by tomorrow.

Regards
Abhinandan

> -----Original Message-----
> From: Jerin Jacob <jerinjacobk@gmail.com>
> Sent: Monday, October 5, 2020 3:14 PM
> To: Ankur Dwivedi <adwivedi@marvell.com>
> Cc: dpdk-dev <dev@dpdk.org>; Gujjar, Abhinandan S
> <abhinandan.gujjar@intel.com>; Jerin Jacob <jerinj@marvell.com>; Anoob
> Joseph <anoobj@marvell.com>
> Subject: Re: [dpdk-dev] [PATCH v2 0/3] Bug fixes in event crypto adapter test
> application
> 
> On Fri, Sep 25, 2020 at 12:59 PM Ankur Dwivedi <adwivedi@marvell.com>
> wrote:
> >
> > This patch series resolves bugs in the event crypto adapter test
> > application.
> >
> > v2:
> > * In the "test/event_crypto_adapter: return error with unsupported
> mode"
> >   patch the following changes were done:
> >   - Skip mismatch of mode and capability for software eventdev.
> >   - In test_crypto_adapter_conf_op_new_mode() and
> >     test_crypto_adapter_conf_op_forward_mode(),the local variable
> >     for holding return of test_crypto_adapter_conf() is removed.
> >   - Minor change in commit message.
> 
> @Gujjar, Abhinandan S ,
> Could you review the v2?
> 
> >
> > Ankur Dwivedi (3):
> >   test/event_crypto_adapter: return error with unsupported mode
> >   test/event_crypto_adapter: fix function arguments
> >   test/event_crypto_adapter: free resources during exit
> >
> >  app/test/test_event_crypto_adapter.c | 66
> > ++++++++++++++++++++--------
> >  1 file changed, 47 insertions(+), 19 deletions(-)
> >
> > --
> > 2.28.0
> >