[v2,00/25] patchset for bnxt
mbox series

Message ID 20200916042851.32914-1-ajit.khaparde@broadcom.com
Headers show
Series
  • patchset for bnxt
Related show

Message

Ajit Khaparde Sept. 16, 2020, 4:28 a.m. UTC
Some fixes and enhancements in the PMD and TruFlow layers.

v1->v2:
 - rebased to latest
 - updated commit messages

Kishore Padmanabha (14):
  net/bnxt: fix port stop process and cleanup resources
  net/bnxt: fix the drop action flow to support count
  net/bnxt: reject flow offload with invalid MAC
  net/bnxt: reduce debug log messages
  net/bnxt: fix coexistence of ipv4 and ipv6 ingress rules
  net/bnxt: modify default flow rule creation
  net/bnxt: fix the function id used in flow flush
  net/bnxt: refactor VFR port clean up
  net/bnxt: remove VLAN pop action for egress flows
  net/bnxt: increase counter support from 8K to 16K
  net/bnxt: enable VXLAN ipv6 encapsulation
  net/bnxt: enable NAT action with tagged traffic
  net/bnxt: fix out of bound access in bit handling
  net/bnxt: add locks in flow database

Mike Baucom (1):
  net/bnxt: free the EM index on failure

Randy Schacher (1):
  net/bnxt: use direct HWRM message for interface table

Shahaji Bhosle (2):
  net/bnxt: add null pointer check for resource manager
  net/bnxt: update resource settings

Somnath Kotur (6):
  net/bnxt: fix crash in VFR queue select
  net/bnxt: fix VFR cleanup during init failure
  net/bnxt: check and set initial counter ID
  net/bnxt: fix bugs in representor data path
  net/bnxt: fix to check VNIC in shutdown path
  net/bnxt: add separate mutex for FW health check

Sriharsha Basavapatna (1):
  net/bnxt: provide switch info if VFR are configured

 drivers/net/bnxt/bnxt.h                       |   13 +-
 drivers/net/bnxt/bnxt_ethdev.c                |  101 +-
 drivers/net/bnxt/bnxt_filter.c                |   14 +-
 drivers/net/bnxt/bnxt_hwrm.c                  |   13 +-
 drivers/net/bnxt/bnxt_reps.c                  |  162 +-
 drivers/net/bnxt/bnxt_reps.h                  |    8 +
 drivers/net/bnxt/bnxt_rxr.c                   |   27 +-
 drivers/net/bnxt/bnxt_vnic.c                  |    3 +
 drivers/net/bnxt/hsi_struct_def_dpdk.h        |  935 ++-
 drivers/net/bnxt/tf_core/tf_em_internal.c     |    5 +-
 drivers/net/bnxt/tf_core/tf_msg.c             |   58 +-
 drivers/net/bnxt/tf_core/tf_rm.c              |   14 +
 drivers/net/bnxt/tf_ulp/bnxt_ulp.c            |  569 +-
 drivers/net/bnxt/tf_ulp/bnxt_ulp.h            |   34 +-
 drivers/net/bnxt/tf_ulp/bnxt_ulp_flow.c       |   56 +-
 drivers/net/bnxt/tf_ulp/ulp_def_rules.c       |  131 +-
 drivers/net/bnxt/tf_ulp/ulp_fc_mgr.c          |    8 +-
 drivers/net/bnxt/tf_ulp/ulp_fc_mgr.h          |    1 +
 drivers/net/bnxt/tf_ulp/ulp_flow_db.c         |   17 +-
 drivers/net/bnxt/tf_ulp/ulp_flow_db.h         |    4 +-
 drivers/net/bnxt/tf_ulp/ulp_mapper.c          |   52 +-
 drivers/net/bnxt/tf_ulp/ulp_mark_mgr.c        |    6 -
 drivers/net/bnxt/tf_ulp/ulp_port_db.c         |   41 +
 drivers/net/bnxt/tf_ulp/ulp_port_db.h         |   13 +
 drivers/net/bnxt/tf_ulp/ulp_rte_parser.c      |  153 +-
 drivers/net/bnxt/tf_ulp/ulp_rte_parser.h      |    5 +-
 drivers/net/bnxt/tf_ulp/ulp_template_db_act.c |  295 +-
 .../net/bnxt/tf_ulp/ulp_template_db_class.c   | 5531 +++++++++++------
 .../net/bnxt/tf_ulp/ulp_template_db_enum.h    |   66 +-
 .../net/bnxt/tf_ulp/ulp_template_db_field.h   |  767 ++-
 drivers/net/bnxt/tf_ulp/ulp_utils.c           |   43 +-
 drivers/net/bnxt/tf_ulp/ulp_utils.h           |    7 +-
 32 files changed, 5836 insertions(+), 3316 deletions(-)

Comments

Ajit Khaparde Sept. 16, 2020, 4:21 p.m. UTC | #1
On Tue, Sep 15, 2020 at 9:28 PM Ajit Khaparde
<ajit.khaparde@broadcom.com> wrote:
>
> Some fixes and enhancements in the PMD and TruFlow layers.
>
> v1->v2:
>  - rebased to latest
>  - updated commit messages
Applied to dpdk-next-net-brcm.

>
> Kishore Padmanabha (14):
>   net/bnxt: fix port stop process and cleanup resources
>   net/bnxt: fix the drop action flow to support count
>   net/bnxt: reject flow offload with invalid MAC
>   net/bnxt: reduce debug log messages
>   net/bnxt: fix coexistence of ipv4 and ipv6 ingress rules
>   net/bnxt: modify default flow rule creation
>   net/bnxt: fix the function id used in flow flush
>   net/bnxt: refactor VFR port clean up
>   net/bnxt: remove VLAN pop action for egress flows
>   net/bnxt: increase counter support from 8K to 16K
>   net/bnxt: enable VXLAN ipv6 encapsulation
>   net/bnxt: enable NAT action with tagged traffic
>   net/bnxt: fix out of bound access in bit handling
>   net/bnxt: add locks in flow database
>
> Mike Baucom (1):
>   net/bnxt: free the EM index on failure
>
> Randy Schacher (1):
>   net/bnxt: use direct HWRM message for interface table
>
> Shahaji Bhosle (2):
>   net/bnxt: add null pointer check for resource manager
>   net/bnxt: update resource settings
>
> Somnath Kotur (6):
>   net/bnxt: fix crash in VFR queue select
>   net/bnxt: fix VFR cleanup during init failure
>   net/bnxt: check and set initial counter ID
>   net/bnxt: fix bugs in representor data path
>   net/bnxt: fix to check VNIC in shutdown path
>   net/bnxt: add separate mutex for FW health check
>
> Sriharsha Basavapatna (1):
>   net/bnxt: provide switch info if VFR are configured
>
>  drivers/net/bnxt/bnxt.h                       |   13 +-
>  drivers/net/bnxt/bnxt_ethdev.c                |  101 +-
>  drivers/net/bnxt/bnxt_filter.c                |   14 +-
>  drivers/net/bnxt/bnxt_hwrm.c                  |   13 +-
>  drivers/net/bnxt/bnxt_reps.c                  |  162 +-
>  drivers/net/bnxt/bnxt_reps.h                  |    8 +
>  drivers/net/bnxt/bnxt_rxr.c                   |   27 +-
>  drivers/net/bnxt/bnxt_vnic.c                  |    3 +
>  drivers/net/bnxt/hsi_struct_def_dpdk.h        |  935 ++-
>  drivers/net/bnxt/tf_core/tf_em_internal.c     |    5 +-
>  drivers/net/bnxt/tf_core/tf_msg.c             |   58 +-
>  drivers/net/bnxt/tf_core/tf_rm.c              |   14 +
>  drivers/net/bnxt/tf_ulp/bnxt_ulp.c            |  569 +-
>  drivers/net/bnxt/tf_ulp/bnxt_ulp.h            |   34 +-
>  drivers/net/bnxt/tf_ulp/bnxt_ulp_flow.c       |   56 +-
>  drivers/net/bnxt/tf_ulp/ulp_def_rules.c       |  131 +-
>  drivers/net/bnxt/tf_ulp/ulp_fc_mgr.c          |    8 +-
>  drivers/net/bnxt/tf_ulp/ulp_fc_mgr.h          |    1 +
>  drivers/net/bnxt/tf_ulp/ulp_flow_db.c         |   17 +-
>  drivers/net/bnxt/tf_ulp/ulp_flow_db.h         |    4 +-
>  drivers/net/bnxt/tf_ulp/ulp_mapper.c          |   52 +-
>  drivers/net/bnxt/tf_ulp/ulp_mark_mgr.c        |    6 -
>  drivers/net/bnxt/tf_ulp/ulp_port_db.c         |   41 +
>  drivers/net/bnxt/tf_ulp/ulp_port_db.h         |   13 +
>  drivers/net/bnxt/tf_ulp/ulp_rte_parser.c      |  153 +-
>  drivers/net/bnxt/tf_ulp/ulp_rte_parser.h      |    5 +-
>  drivers/net/bnxt/tf_ulp/ulp_template_db_act.c |  295 +-
>  .../net/bnxt/tf_ulp/ulp_template_db_class.c   | 5531 +++++++++++------
>  .../net/bnxt/tf_ulp/ulp_template_db_enum.h    |   66 +-
>  .../net/bnxt/tf_ulp/ulp_template_db_field.h   |  767 ++-
>  drivers/net/bnxt/tf_ulp/ulp_utils.c           |   43 +-
>  drivers/net/bnxt/tf_ulp/ulp_utils.h           |    7 +-
>  32 files changed, 5836 insertions(+), 3316 deletions(-)
>
> --
> 2.21.1 (Apple Git-122.3)
>
Ferruh Yigit Sept. 16, 2020, 11:57 p.m. UTC | #2
On 9/16/2020 5:21 PM, Ajit Khaparde wrote:
> On Tue, Sep 15, 2020 at 9:28 PM Ajit Khaparde
> <ajit.khaparde@broadcom.com> wrote:
>>
>> Some fixes and enhancements in the PMD and TruFlow layers.
>>
>> v1->v2:
>>   - rebased to latest
>>   - updated commit messages
> Applied to dpdk-next-net-brcm.
> 
>>
>> Kishore Padmanabha (14):
>>    net/bnxt: fix port stop process and cleanup resources
>>    net/bnxt: fix the drop action flow to support count
>>    net/bnxt: reject flow offload with invalid MAC
>>    net/bnxt: reduce debug log messages
>>    net/bnxt: fix coexistence of ipv4 and ipv6 ingress rules
>>    net/bnxt: modify default flow rule creation
>>    net/bnxt: fix the function id used in flow flush
>>    net/bnxt: refactor VFR port clean up
>>    net/bnxt: remove VLAN pop action for egress flows
>>    net/bnxt: increase counter support from 8K to 16K
>>    net/bnxt: enable VXLAN ipv6 encapsulation
>>    net/bnxt: enable NAT action with tagged traffic
>>    net/bnxt: fix out of bound access in bit handling
>>    net/bnxt: add locks in flow database
>>
>> Mike Baucom (1):
>>    net/bnxt: free the EM index on failure
>>
>> Randy Schacher (1):
>>    net/bnxt: use direct HWRM message for interface table
>>
>> Shahaji Bhosle (2):
>>    net/bnxt: add null pointer check for resource manager
>>    net/bnxt: update resource settings
>>
>> Somnath Kotur (6):
>>    net/bnxt: fix crash in VFR queue select
>>    net/bnxt: fix VFR cleanup during init failure
>>    net/bnxt: check and set initial counter ID
>>    net/bnxt: fix bugs in representor data path
>>    net/bnxt: fix to check VNIC in shutdown path
>>    net/bnxt: add separate mutex for FW health check
>>
>> Sriharsha Basavapatna (1):
>>    net/bnxt: provide switch info if VFR are configured
>>

Hi Ajit,

I assume the backporting of the majority of the patchset explicitly not 
requested, since two of them has stable tag but rest don't, but I would 
like to confirm.

And I suggest backporting fixes as much as possible, since missing some 
fixes may cause conflict for future fixes and prevent backporting them.
Ajit Khaparde Sept. 17, 2020, 12:13 a.m. UTC | #3
On Wed, Sep 16, 2020 at 4:58 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 9/16/2020 5:21 PM, Ajit Khaparde wrote:
> > On Tue, Sep 15, 2020 at 9:28 PM Ajit Khaparde
> > <ajit.khaparde@broadcom.com> wrote:
> >>
> >> Some fixes and enhancements in the PMD and TruFlow layers.
> >>
> >> v1->v2:
> >>   - rebased to latest
> >>   - updated commit messages
> > Applied to dpdk-next-net-brcm.
> >
> >>
> >> Kishore Padmanabha (14):
> >>    net/bnxt: fix port stop process and cleanup resources
> >>    net/bnxt: fix the drop action flow to support count
> >>    net/bnxt: reject flow offload with invalid MAC
> >>    net/bnxt: reduce debug log messages
> >>    net/bnxt: fix coexistence of ipv4 and ipv6 ingress rules
> >>    net/bnxt: modify default flow rule creation
> >>    net/bnxt: fix the function id used in flow flush
> >>    net/bnxt: refactor VFR port clean up
> >>    net/bnxt: remove VLAN pop action for egress flows
> >>    net/bnxt: increase counter support from 8K to 16K
> >>    net/bnxt: enable VXLAN ipv6 encapsulation
> >>    net/bnxt: enable NAT action with tagged traffic
> >>    net/bnxt: fix out of bound access in bit handling
> >>    net/bnxt: add locks in flow database
> >>
> >> Mike Baucom (1):
> >>    net/bnxt: free the EM index on failure
> >>
> >> Randy Schacher (1):
> >>    net/bnxt: use direct HWRM message for interface table
> >>
> >> Shahaji Bhosle (2):
> >>    net/bnxt: add null pointer check for resource manager
> >>    net/bnxt: update resource settings
> >>
> >> Somnath Kotur (6):
> >>    net/bnxt: fix crash in VFR queue select
> >>    net/bnxt: fix VFR cleanup during init failure
> >>    net/bnxt: check and set initial counter ID
> >>    net/bnxt: fix bugs in representor data path
> >>    net/bnxt: fix to check VNIC in shutdown path
> >>    net/bnxt: add separate mutex for FW health check
> >>
> >> Sriharsha Basavapatna (1):
> >>    net/bnxt: provide switch info if VFR are configured
> >>
>
> Hi Ajit,
>
> I assume the backporting of the majority of the patchset explicitly not
> requested, since two of them has stable tag but rest don't, but I would
> like to confirm.
>
> And I suggest backporting fixes as much as possible, since missing some
> fixes may cause conflict for future fixes and prevent backporting them.
Hi Ferruh,
Most of the fixes are actually for changes made in 20.08
Since it is not an LTS, I think not really porting them should not be a problem.
But if there is any patch which needs to go into earlier LTS releases,
I will add it to the list of backports.

Thanks for checking.
Ajit

>
>
Ferruh Yigit Sept. 17, 2020, 7:39 a.m. UTC | #4
On 9/17/2020 1:13 AM, Ajit Khaparde wrote:
> On Wed, Sep 16, 2020 at 4:58 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>
>> On 9/16/2020 5:21 PM, Ajit Khaparde wrote:
>>> On Tue, Sep 15, 2020 at 9:28 PM Ajit Khaparde
>>> <ajit.khaparde@broadcom.com> wrote:
>>>>
>>>> Some fixes and enhancements in the PMD and TruFlow layers.
>>>>
>>>> v1->v2:
>>>>    - rebased to latest
>>>>    - updated commit messages
>>> Applied to dpdk-next-net-brcm.
>>>
>>>>
>>>> Kishore Padmanabha (14):
>>>>     net/bnxt: fix port stop process and cleanup resources
>>>>     net/bnxt: fix the drop action flow to support count
>>>>     net/bnxt: reject flow offload with invalid MAC
>>>>     net/bnxt: reduce debug log messages
>>>>     net/bnxt: fix coexistence of ipv4 and ipv6 ingress rules
>>>>     net/bnxt: modify default flow rule creation
>>>>     net/bnxt: fix the function id used in flow flush
>>>>     net/bnxt: refactor VFR port clean up
>>>>     net/bnxt: remove VLAN pop action for egress flows
>>>>     net/bnxt: increase counter support from 8K to 16K
>>>>     net/bnxt: enable VXLAN ipv6 encapsulation
>>>>     net/bnxt: enable NAT action with tagged traffic
>>>>     net/bnxt: fix out of bound access in bit handling
>>>>     net/bnxt: add locks in flow database
>>>>
>>>> Mike Baucom (1):
>>>>     net/bnxt: free the EM index on failure
>>>>
>>>> Randy Schacher (1):
>>>>     net/bnxt: use direct HWRM message for interface table
>>>>
>>>> Shahaji Bhosle (2):
>>>>     net/bnxt: add null pointer check for resource manager
>>>>     net/bnxt: update resource settings
>>>>
>>>> Somnath Kotur (6):
>>>>     net/bnxt: fix crash in VFR queue select
>>>>     net/bnxt: fix VFR cleanup during init failure
>>>>     net/bnxt: check and set initial counter ID
>>>>     net/bnxt: fix bugs in representor data path
>>>>     net/bnxt: fix to check VNIC in shutdown path
>>>>     net/bnxt: add separate mutex for FW health check
>>>>
>>>> Sriharsha Basavapatna (1):
>>>>     net/bnxt: provide switch info if VFR are configured
>>>>
>>
>> Hi Ajit,
>>
>> I assume the backporting of the majority of the patchset explicitly not
>> requested, since two of them has stable tag but rest don't, but I would
>> like to confirm.
>>
>> And I suggest backporting fixes as much as possible, since missing some
>> fixes may cause conflict for future fixes and prevent backporting them.
> Hi Ferruh,
> Most of the fixes are actually for changes made in 20.08
> Since it is not an LTS, I think not really porting them should not be a problem.
> But if there is any patch which needs to go into earlier LTS releases,
> I will add it to the list of backports.
> 

This is not just for LTS, if somehow we have 20.08.1, they will matter.
Also this is good for documenting the actual intention of the author 
related backporting the patches.

As far as I can see there is not explicit request to "not" backport 
them, so I will add the missing tags while merging.