From patchwork Thu Sep 10 14:21:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Conor Walsh X-Patchwork-Id: 77148 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E06BCA04B5; Thu, 10 Sep 2020 16:21:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D03B41BFA2; Thu, 10 Sep 2020 16:21:29 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 8690A1BEB3 for ; Thu, 10 Sep 2020 16:21:28 +0200 (CEST) IronPort-SDR: U5hv8boG0SeDVjSFE6rSOH7RTVkADJGqH1KSL/MvA6GUn85DtR8zVDApsz3nJ37vRlkYFvlJ6I CAI2sAgS5axQ== X-IronPort-AV: E=McAfee;i="6000,8403,9739"; a="138054677" X-IronPort-AV: E=Sophos;i="5.76,413,1592895600"; d="scan'208";a="138054677" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Sep 2020 07:21:27 -0700 IronPort-SDR: JfMc4wf3qkPooc2+dTu8UXV0UJuuBhuPnTYstAHH1fRsYtcm+sYb6dWT79am41l9alO03LhbT0 +G6yCI9vdtyQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,413,1592895600"; d="scan'208";a="329346307" Received: from silpixa00400466.ir.intel.com ([10.237.213.195]) by fmsmga004.fm.intel.com with ESMTP; 10 Sep 2020 07:21:25 -0700 From: Conor Walsh To: dev@dpdk.org Cc: david.marchand@redhat.com, ray.kinsella@intel.com, nhorman@tuxdriver.com, aconole@redhat.com, maicolgabriel@hotmail.com, thomas@monjalon.net, bruce.richardson@intel.com, Conor Walsh Date: Thu, 10 Sep 2020 14:21:17 +0000 Message-Id: <20200910142121.3995680-1-conor.walsh@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200910140116.3995345-1-conor.walsh@intel.com> References: <20200910140116.3995345-1-conor.walsh@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2 0/4] abi breakage checks for meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patchset allows developers to check ABI breakages during build time. Currently checking that the DPDK ABI has not changed before up-streaming code is not intuitive. The current method, requires the contributor to use either the test-build.sh and test-meson-build.sh tools, along side some environmental variables to test their changes. Contributors in many cases are either unaware or unable to do this themselves, leading to a potentially serious situation where they are unknowingly up-streaming code that breaks the ABI. These breakages are then caught by Travis, but it is more efficient if this is caught locally before up-streaming. --- v2: Spelling mistake, corrected spelling of environmental Conor Walsh (4): devtools: bug fix for gen-abi.sh devtools: add generation of compressed abi dump archives buildtools: add script to setup abi checks for meson build: add abi breakage checks to meson buildtools/abi-setup.py | 104 ++++++++++++++++++++++++++++++ buildtools/meson.build | 20 ++++++ config/meson.build | 9 +++ devtools/gen-abi-tarball.py | 125 ++++++++++++++++++++++++++++++++++++ devtools/gen-abi.sh | 6 +- drivers/meson.build | 15 +++++ lib/meson.build | 15 +++++ meson_options.txt | 2 + 8 files changed, 291 insertions(+), 5 deletions(-) create mode 100755 buildtools/abi-setup.py create mode 100755 devtools/gen-abi-tarball.py