mbox series

[v3,0/5] fix vector rx burst for PMDs

Message ID 20200909063636.60205-1-jia.guo@intel.com (mailing list archive)
Headers
Series fix vector rx burst for PMDs |

Message

Guo, Jia Sept. 9, 2020, 6:36 a.m. UTC 
  The limitation of burst size in vector rx was removed, since it should
retrieve as much received packets as possible. And also the scattered
receive path should use a wrapper function to achieve the goal of burst
maximizing.

This patch set aims to maximize vector rx burst for for
ixgbe/i40e/ice/iavf/fm10k PMDs, and also do some code cleaning.

v3->v2:
1:move define into header file.
2:delete some useless doc.

v2->v1:
1:add fm10k driver case
2:refine some doc

Jeff Guo (5):
  net/iavf: fix vector rx burst for iavf
  net/ixgbe: fix vector rx burst for ixgbe
  net/i40e: fix vector rx burst for i40e
  net/ice: fix vector rx burst for ice
  net/fm10k: fix vector rx burst for fm10k

 drivers/net/fm10k/fm10k_rxtx_vec.c       |  42 ++++++--
 drivers/net/i40e/i40e_rxtx.h             |   1 +
 drivers/net/i40e/i40e_rxtx_vec_altivec.c |  64 +++++++-----
 drivers/net/i40e/i40e_rxtx_vec_avx2.c    |  29 +++---
 drivers/net/i40e/i40e_rxtx_vec_neon.c    |  58 +++++++----
 drivers/net/i40e/i40e_rxtx_vec_sse.c     |  58 +++++++----
 drivers/net/iavf/iavf_rxtx.h             |   1 +
 drivers/net/iavf/iavf_rxtx_vec_avx2.c    |  78 +++++++--------
 drivers/net/iavf/iavf_rxtx_vec_sse.c     | 119 +++++++++++++++--------
 drivers/net/ice/ice_rxtx.h               |   1 +
 drivers/net/ice/ice_rxtx_vec_avx2.c      |  23 +++--
 drivers/net/ice/ice_rxtx_vec_sse.c       |  56 +++++++----
 drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c  |  77 ++++++++-------
 drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c   |  61 +++++++-----
 14 files changed, 412 insertions(+), 256 deletions(-)

Comments

Wang, Haiyue Sept. 9, 2020, 6:45 a.m. UTC | #1 
> -----Original Message-----
> From: Guo, Jia <jia.guo@intel.com>
> Sent: Wednesday, September 9, 2020 14:37
> To: Yang, Qiming <qiming.yang@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Zhao1, Wei
> <wei.zhao1@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
> Cc: Richardson, Bruce <bruce.richardson@intel.com>; dev@dpdk.org; Guo, Jia <jia.guo@intel.com>; Zhang,
> Helin <helin.zhang@intel.com>; mb@smartsharesystems.com; Yigit, Ferruh <ferruh.yigit@intel.com>; Wang,
> Haiyue <haiyue.wang@intel.com>; stephen@networkplumber.org; barbette@kth.se
> Subject: [PATCH v3 0/5] fix vector rx burst for PMDs
> 
> The limitation of burst size in vector rx was removed, since it should
> retrieve as much received packets as possible. And also the scattered
> receive path should use a wrapper function to achieve the goal of burst
> maximizing.
> 
> This patch set aims to maximize vector rx burst for for
> ixgbe/i40e/ice/iavf/fm10k PMDs, and also do some code cleaning.

IMO, this can be "enhance the vector ...", but not "fix ...".
If "fix", it needs "Fixes:" tags ... ;-)

> 
> --
> 2.20.1
Guo, Jia Sept. 9, 2020, 7:03 a.m. UTC | #2 
Hi, haiyue

> -----Original Message-----
> From: Wang, Haiyue <haiyue.wang@intel.com>
> Sent: Wednesday, September 9, 2020 2:45 PM
> To: Guo, Jia <jia.guo@intel.com>; Yang, Qiming <qiming.yang@intel.com>;
> Xing, Beilei <beilei.xing@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>;
> Zhang, Qi Z <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
> Cc: Richardson, Bruce <bruce.richardson@intel.com>; dev@dpdk.org; Zhang,
> Helin <helin.zhang@intel.com>; mb@smartsharesystems.com; Yigit, Ferruh
> <ferruh.yigit@intel.com>; stephen@networkplumber.org; barbette@kth.se
> Subject: RE: [PATCH v3 0/5] fix vector rx burst for PMDs
> 
> > -----Original Message-----
> > From: Guo, Jia <jia.guo@intel.com>
> > Sent: Wednesday, September 9, 2020 14:37
> > To: Yang, Qiming <qiming.yang@intel.com>; Xing, Beilei
> > <beilei.xing@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>; Zhang, Qi Z
> > <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
> > Cc: Richardson, Bruce <bruce.richardson@intel.com>; dev@dpdk.org; Guo,
> > Jia <jia.guo@intel.com>; Zhang, Helin <helin.zhang@intel.com>;
> > mb@smartsharesystems.com; Yigit, Ferruh <ferruh.yigit@intel.com>;
> > Wang, Haiyue <haiyue.wang@intel.com>; stephen@networkplumber.org;
> > barbette@kth.se
> > Subject: [PATCH v3 0/5] fix vector rx burst for PMDs
> >
> > The limitation of burst size in vector rx was removed, since it should
> > retrieve as much received packets as possible. And also the scattered
> > receive path should use a wrapper function to achieve the goal of
> > burst maximizing.
> >
> > This patch set aims to maximize vector rx burst for for
> > ixgbe/i40e/ice/iavf/fm10k PMDs, and also do some code cleaning.
> 
> IMO, this can be "enhance the vector ...", but not "fix ...".
> If "fix", it needs "Fixes:" tags ... ;-)
> 

Ok, so I will prefer to use "refine the vector rx burst for PMDs", thanks.
> >
> > --
> > 2.20.1
>
Wang, Haiyue Sept. 9, 2020, 7:05 a.m. UTC | #3 
> -----Original Message-----
> From: Guo, Jia <jia.guo@intel.com>
> Sent: Wednesday, September 9, 2020 15:03
> To: Wang, Haiyue <haiyue.wang@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Wu,
> Jingjing <jingjing.wu@intel.com>
> Cc: Richardson, Bruce <bruce.richardson@intel.com>; dev@dpdk.org; Zhang, Helin <helin.zhang@intel.com>;
> mb@smartsharesystems.com; Yigit, Ferruh <ferruh.yigit@intel.com>; stephen@networkplumber.org;
> barbette@kth.se
> Subject: RE: [PATCH v3 0/5] fix vector rx burst for PMDs
> 
> Hi, haiyue
> 
> > -----Original Message-----
> > From: Wang, Haiyue <haiyue.wang@intel.com>
> > Sent: Wednesday, September 9, 2020 2:45 PM
> > To: Guo, Jia <jia.guo@intel.com>; Yang, Qiming <qiming.yang@intel.com>;
> > Xing, Beilei <beilei.xing@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>;
> > Zhang, Qi Z <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
> > Cc: Richardson, Bruce <bruce.richardson@intel.com>; dev@dpdk.org; Zhang,
> > Helin <helin.zhang@intel.com>; mb@smartsharesystems.com; Yigit, Ferruh
> > <ferruh.yigit@intel.com>; stephen@networkplumber.org; barbette@kth.se
> > Subject: RE: [PATCH v3 0/5] fix vector rx burst for PMDs
> >
> > > -----Original Message-----
> > > From: Guo, Jia <jia.guo@intel.com>
> > > Sent: Wednesday, September 9, 2020 14:37
> > > To: Yang, Qiming <qiming.yang@intel.com>; Xing, Beilei
> > > <beilei.xing@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>; Zhang, Qi Z
> > > <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
> > > Cc: Richardson, Bruce <bruce.richardson@intel.com>; dev@dpdk.org; Guo,
> > > Jia <jia.guo@intel.com>; Zhang, Helin <helin.zhang@intel.com>;
> > > mb@smartsharesystems.com; Yigit, Ferruh <ferruh.yigit@intel.com>;
> > > Wang, Haiyue <haiyue.wang@intel.com>; stephen@networkplumber.org;
> > > barbette@kth.se
> > > Subject: [PATCH v3 0/5] fix vector rx burst for PMDs
> > >
> > > The limitation of burst size in vector rx was removed, since it should
> > > retrieve as much received packets as possible. And also the scattered
> > > receive path should use a wrapper function to achieve the goal of
> > > burst maximizing.
> > >
> > > This patch set aims to maximize vector rx burst for for
> > > ixgbe/i40e/ice/iavf/fm10k PMDs, and also do some code cleaning.
> >
> > IMO, this can be "enhance the vector ...", but not "fix ...".
> > If "fix", it needs "Fixes:" tags ... ;-)
> >
> 
> Ok, so I will prefer to use "refine the vector rx burst for PMDs", thanks.

Better than "fix" now.

> > >
> > > --
> > > 2.20.1
> >
>
Morten Brørup Sept. 9, 2020, 7:43 a.m. UTC | #4 
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wang, Haiyue
> Sent: Wednesday, September 9, 2020 9:05 AM
> 
> > From: Guo, Jia <jia.guo@intel.com>
> > Sent: Wednesday, September 9, 2020 15:03
> >
> > Hi, haiyue
> >
> > > From: Wang, Haiyue <haiyue.wang@intel.com>
> > > Sent: Wednesday, September 9, 2020 2:45 PM
> > >
> > > > From: Guo, Jia <jia.guo@intel.com>
> > > > Sent: Wednesday, September 9, 2020 14:37
> > > >
> > > > The limitation of burst size in vector rx was removed, since it
> should
> > > > retrieve as much received packets as possible. And also the
> scattered
> > > > receive path should use a wrapper function to achieve the goal of
> > > > burst maximizing.
> > > >
> > > > This patch set aims to maximize vector rx burst for for
> > > > ixgbe/i40e/ice/iavf/fm10k PMDs, and also do some code cleaning.
> > >
> > > IMO, this can be "enhance the vector ...", but not "fix ...".
> > > If "fix", it needs "Fixes:" tags ... ;-)
> > >
> >
> > Ok, so I will prefer to use "refine the vector rx burst for PMDs",
> thanks.
> 
> Better than "fix" now.
> 

It does fix a bug: https://bugs.dpdk.org/show_bug.cgi?id=516
Wang, Haiyue Sept. 9, 2020, 7:55 a.m. UTC | #5 
> -----Original Message-----
> From: Morten Brørup <mb@smartsharesystems.com>
> Sent: Wednesday, September 9, 2020 15:43
> To: Wang, Haiyue <haiyue.wang@intel.com>; Guo, Jia <jia.guo@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>; Zhang,
> Qi Z <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
> Cc: Richardson, Bruce <bruce.richardson@intel.com>; dev@dpdk.org; Zhang, Helin <helin.zhang@intel.com>;
> Yigit, Ferruh <ferruh.yigit@intel.com>; stephen@networkplumber.org; barbette@kth.se
> Subject: RE: [dpdk-dev] [PATCH v3 0/5] fix vector rx burst for PMDs
> 
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wang, Haiyue
> > Sent: Wednesday, September 9, 2020 9:05 AM
> >
> > > From: Guo, Jia <jia.guo@intel.com>
> > > Sent: Wednesday, September 9, 2020 15:03
> > >
> > > Hi, haiyue
> > >
> > > > From: Wang, Haiyue <haiyue.wang@intel.com>
> > > > Sent: Wednesday, September 9, 2020 2:45 PM
> > > >
> > > > > From: Guo, Jia <jia.guo@intel.com>
> > > > > Sent: Wednesday, September 9, 2020 14:37
> > > > >
> > > > > The limitation of burst size in vector rx was removed, since it
> > should
> > > > > retrieve as much received packets as possible. And also the
> > scattered
> > > > > receive path should use a wrapper function to achieve the goal of
> > > > > burst maximizing.
> > > > >
> > > > > This patch set aims to maximize vector rx burst for for
> > > > > ixgbe/i40e/ice/iavf/fm10k PMDs, and also do some code cleaning.
> > > >
> > > > IMO, this can be "enhance the vector ...", but not "fix ...".
> > > > If "fix", it needs "Fixes:" tags ... ;-)
> > > >
> > >
> > > Ok, so I will prefer to use "refine the vector rx burst for PMDs",
> > thanks.
> >
> > Better than "fix" now.
> >
> 
> It does fix a bug: https://bugs.dpdk.org/show_bug.cgi?id=516

Looks like a backport is needed.
Guo, Jia Sept. 9, 2020, 8:01 a.m. UTC | #6 
> -----Original Message-----
> From: Wang, Haiyue <haiyue.wang@intel.com>
> Sent: Wednesday, September 9, 2020 3:55 PM
> To: Morten Brørup <mb@smartsharesystems.com>; Guo, Jia
> <jia.guo@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
> Cc: Richardson, Bruce <bruce.richardson@intel.com>; dev@dpdk.org; Zhang,
> Helin <helin.zhang@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>;
> stephen@networkplumber.org; barbette@kth.se
> Subject: RE: [dpdk-dev] [PATCH v3 0/5] fix vector rx burst for PMDs
> 
> > -----Original Message-----
> > From: Morten Brørup <mb@smartsharesystems.com>
> > Sent: Wednesday, September 9, 2020 15:43
> > To: Wang, Haiyue <haiyue.wang@intel.com>; Guo, Jia
> > <jia.guo@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Xing,
> > Beilei <beilei.xing@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>;
> > Zhang, Qi Z <qi.z.zhang@intel.com>; Wu, Jingjing
> > <jingjing.wu@intel.com>
> > Cc: Richardson, Bruce <bruce.richardson@intel.com>; dev@dpdk.org;
> > Zhang, Helin <helin.zhang@intel.com>; Yigit, Ferruh
> > <ferruh.yigit@intel.com>; stephen@networkplumber.org;
> barbette@kth.se
> > Subject: RE: [dpdk-dev] [PATCH v3 0/5] fix vector rx burst for PMDs
> >
> > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wang, Haiyue
> > > Sent: Wednesday, September 9, 2020 9:05 AM
> > >
> > > > From: Guo, Jia <jia.guo@intel.com>
> > > > Sent: Wednesday, September 9, 2020 15:03
> > > >
> > > > Hi, haiyue
> > > >
> > > > > From: Wang, Haiyue <haiyue.wang@intel.com>
> > > > > Sent: Wednesday, September 9, 2020 2:45 PM
> > > > >
> > > > > > From: Guo, Jia <jia.guo@intel.com>
> > > > > > Sent: Wednesday, September 9, 2020 14:37
> > > > > >
> > > > > > The limitation of burst size in vector rx was removed, since
> > > > > > it
> > > should
> > > > > > retrieve as much received packets as possible. And also the
> > > scattered
> > > > > > receive path should use a wrapper function to achieve the goal
> > > > > > of burst maximizing.
> > > > > >
> > > > > > This patch set aims to maximize vector rx burst for for
> > > > > > ixgbe/i40e/ice/iavf/fm10k PMDs, and also do some code cleaning.
> > > > >
> > > > > IMO, this can be "enhance the vector ...", but not "fix ...".
> > > > > If "fix", it needs "Fixes:" tags ... ;-)
> > > > >
> > > >
> > > > Ok, so I will prefer to use "refine the vector rx burst for PMDs",
> > > thanks.
> > >
> > > Better than "fix" now.
> > >
> >
> > It does fix a bug: https://bugs.dpdk.org/show_bug.cgi?id=516
> 

Oh, I missing it, so the Fixed tag and bug info could be expect in commit log in next version. Thanks, morten.

> Looks like a backport is needed.
>