| Message ID | 1599128029-2092-1-git-send-email-michaelba@nvidia.com (mailing list archive) |
|---|---|
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C57CFA04DB; Thu, 3 Sep 2020 12:14:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1AD601C0B4; Thu, 3 Sep 2020 12:14:32 +0200 (CEST) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 324961C0AE for <dev@dpdk.org>; Thu, 3 Sep 2020 12:14:30 +0200 (CEST) Received: from Internal Mail-Server by MTLPINE1 (envelope-from michaelba@nvidia.com) with SMTP; 3 Sep 2020 13:14:26 +0300 Received: from nvidia.com (pegasus07.mtr.labs.mlnx [10.210.16.112]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 083AEP8w031645; Thu, 3 Sep 2020 13:14:25 +0300 From: Michael Baum <michaelba@nvidia.com> To: dev@dpdk.org Cc: Matan Azrad <matan@nvidia.com>, Raslan Darawsheh <rasland@nvidia.com>, Viacheslav Ovsiienko <viacheslavo@nvidia.com> Date: Thu, 3 Sep 2020 10:13:31 +0000 Message-Id: <1599128029-2092-1-git-send-email-michaelba@nvidia.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v1 00/18] mlx5 Rx DevX/Verbs separation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
| Series |
mlx5 Rx DevX/Verbs separation
|
|
Message
Michael Baum
Sept. 3, 2020, 10:13 a.m. UTC
v1: Initial version Michael Baum (18): net/mlx5: fix Rx hash queue creation error flow net/mlx5: fix Rx queue state update net/mlx5: fix types differentiation in Rxq create net/mlx5: mitigate Rx queue reference counters net/mlx5: separate Rx queue object creations net/mlx5: separate Rx interrupt handling net/mlx5: share Rx control code net/mlx5: rearrange the creation of RQ and CQ resources net/mlx5: rearrange the creation of WQ and CQ object net/mlx5: separate Rx queue object modification net/mlx5: share Rx queue object modification net/mlx5: separate Rx indirection table object creation net/mlx5: separate Rx hash queue creation net/mlx5: remove indirection table type field net/mlx5: share Rx queue indirection table code net/mlx5: share Rx hash queue code net/mlx5: separate Rx queue drop net/mlx5: share Rx queue drop action code drivers/net/mlx5/Makefile | 1 + drivers/net/mlx5/linux/mlx5_os.c | 10 + drivers/net/mlx5/linux/mlx5_verbs.c | 707 +++++++++++++ drivers/net/mlx5/linux/mlx5_verbs.h | 4 + drivers/net/mlx5/meson.build | 1 + drivers/net/mlx5/mlx5.h | 73 +- drivers/net/mlx5/mlx5_devx.c | 792 +++++++++++++- drivers/net/mlx5/mlx5_flow_dv.c | 20 +- drivers/net/mlx5/mlx5_flow_verbs.c | 35 +- drivers/net/mlx5/mlx5_rxq.c | 1934 ++++++----------------------------- drivers/net/mlx5/mlx5_rxtx.h | 84 +- drivers/net/mlx5/mlx5_trigger.c | 67 +- drivers/net/mlx5/mlx5_vlan.c | 2 +- 13 files changed, 1954 insertions(+), 1776 deletions(-)
Comments
Could you provide a cover letter? Thanks, Tom Le 03/09/2020 à 12:13, Michael Baum a écrit : > v1: > Initial version > > Michael Baum (18): > net/mlx5: fix Rx hash queue creation error flow > net/mlx5: fix Rx queue state update > net/mlx5: fix types differentiation in Rxq create > net/mlx5: mitigate Rx queue reference counters > net/mlx5: separate Rx queue object creations > net/mlx5: separate Rx interrupt handling > net/mlx5: share Rx control code > net/mlx5: rearrange the creation of RQ and CQ resources > net/mlx5: rearrange the creation of WQ and CQ object > net/mlx5: separate Rx queue object modification > net/mlx5: share Rx queue object modification > net/mlx5: separate Rx indirection table object creation > net/mlx5: separate Rx hash queue creation > net/mlx5: remove indirection table type field > net/mlx5: share Rx queue indirection table code > net/mlx5: share Rx hash queue code > net/mlx5: separate Rx queue drop > net/mlx5: share Rx queue drop action code > > drivers/net/mlx5/Makefile | 1 + > drivers/net/mlx5/linux/mlx5_os.c | 10 + > drivers/net/mlx5/linux/mlx5_verbs.c | 707 +++++++++++++ > drivers/net/mlx5/linux/mlx5_verbs.h | 4 + > drivers/net/mlx5/meson.build | 1 + > drivers/net/mlx5/mlx5.h | 73 +- > drivers/net/mlx5/mlx5_devx.c | 792 +++++++++++++- > drivers/net/mlx5/mlx5_flow_dv.c | 20 +- > drivers/net/mlx5/mlx5_flow_verbs.c | 35 +- > drivers/net/mlx5/mlx5_rxq.c | 1934 ++++++----------------------------- > drivers/net/mlx5/mlx5_rxtx.h | 84 +- > drivers/net/mlx5/mlx5_trigger.c | 67 +- > drivers/net/mlx5/mlx5_vlan.c | 2 +- > 13 files changed, 1954 insertions(+), 1776 deletions(-) >
I think the names of the patches describe well enough and there is no need to add a description in the cover-letter. > -----Original Message----- > From: Tom Barbette <barbette@kth.se> > Sent: Thursday, September 3, 2020 5:34 PM > To: Michael Baum <michaelba@nvidia.com>; dev@dpdk.org > Cc: Matan Azrad <matan@nvidia.com>; Raslan Darawsheh > <rasland@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com> > Subject: Re: [dpdk-dev] [PATCH v1 00/18] mlx5 Rx DevX/Verbs separation > > External email: Use caution opening links or attachments > > > Could you provide a cover letter? > > Thanks, > > Tom > > Le 03/09/2020 à 12:13, Michael Baum a écrit : > > v1: > > Initial version > > > > Michael Baum (18): > > net/mlx5: fix Rx hash queue creation error flow > > net/mlx5: fix Rx queue state update > > net/mlx5: fix types differentiation in Rxq create > > net/mlx5: mitigate Rx queue reference counters > > net/mlx5: separate Rx queue object creations > > net/mlx5: separate Rx interrupt handling > > net/mlx5: share Rx control code > > net/mlx5: rearrange the creation of RQ and CQ resources > > net/mlx5: rearrange the creation of WQ and CQ object > > net/mlx5: separate Rx queue object modification > > net/mlx5: share Rx queue object modification > > net/mlx5: separate Rx indirection table object creation > > net/mlx5: separate Rx hash queue creation > > net/mlx5: remove indirection table type field > > net/mlx5: share Rx queue indirection table code > > net/mlx5: share Rx hash queue code > > net/mlx5: separate Rx queue drop > > net/mlx5: share Rx queue drop action code > > > > drivers/net/mlx5/Makefile | 1 + > > drivers/net/mlx5/linux/mlx5_os.c | 10 + > > drivers/net/mlx5/linux/mlx5_verbs.c | 707 +++++++++++++ > > drivers/net/mlx5/linux/mlx5_verbs.h | 4 + > > drivers/net/mlx5/meson.build | 1 + > > drivers/net/mlx5/mlx5.h | 73 +- > > drivers/net/mlx5/mlx5_devx.c | 792 +++++++++++++- > > drivers/net/mlx5/mlx5_flow_dv.c | 20 +- > > drivers/net/mlx5/mlx5_flow_verbs.c | 35 +- > > drivers/net/mlx5/mlx5_rxq.c | 1934 ++++++----------------------------- > > drivers/net/mlx5/mlx5_rxtx.h | 84 +- > > drivers/net/mlx5/mlx5_trigger.c | 67 +- > > drivers/net/mlx5/mlx5_vlan.c | 2 +- > > 13 files changed, 1954 insertions(+), 1776 deletions(-) > >
On Thu, Sep 3, 2020 at 11:00 PM Michael Baum <michaelba@nvidia.com> wrote: > > I think the names of the patches describe well enough and there is no need to add a description in the cover-letter. It gives no hint at the purpose, the impacts... why should we care about this separation?
03/09/2020 22:59, Michael Baum: > I think the names of the patches describe well enough > and there is no need to add a description in the cover-letter. An introduction giving the general idea, explaining the reason for writing these changes, is always appreciable. PS: Please do not top-post. > From: Tom Barbette <barbette@kth.se> > > Could you provide a cover letter? > > > > Thanks, > > > > Tom > > > > Le 03/09/2020 à 12:13, Michael Baum a écrit : > > > v1: > > > Initial version > > > > > > Michael Baum (18): > > > net/mlx5: fix Rx hash queue creation error flow > > > net/mlx5: fix Rx queue state update > > > net/mlx5: fix types differentiation in Rxq create > > > net/mlx5: mitigate Rx queue reference counters > > > net/mlx5: separate Rx queue object creations > > > net/mlx5: separate Rx interrupt handling > > > net/mlx5: share Rx control code > > > net/mlx5: rearrange the creation of RQ and CQ resources > > > net/mlx5: rearrange the creation of WQ and CQ object > > > net/mlx5: separate Rx queue object modification > > > net/mlx5: share Rx queue object modification > > > net/mlx5: separate Rx indirection table object creation > > > net/mlx5: separate Rx hash queue creation > > > net/mlx5: remove indirection table type field > > > net/mlx5: share Rx queue indirection table code > > > net/mlx5: share Rx hash queue code > > > net/mlx5: separate Rx queue drop > > > net/mlx5: share Rx queue drop action code
From: Thomas Monjalon: > 03/09/2020 22:59, Michael Baum: > > I think the names of the patches describe well enough and there is no > > need to add a description in the cover-letter. > > An introduction giving the general idea, explaining the reason for writing > these changes, is always appreciable. > > PS: Please do not top-post. Ok > > > From: Tom Barbette <barbette@kth.se> > > > Could you provide a cover letter? Yes, the series is an arrangement to multi-OS support by net/mlx5 driver so it comes to ease the code management for OS which supports\doesn't support DevX\Verbs operations. > > > > > > Thanks, > > > > > > Tom > > > > > > Le 03/09/2020 à 12:13, Michael Baum a écrit : > > > > v1: > > > > Initial version > > > > > > > > Michael Baum (18): > > > > net/mlx5: fix Rx hash queue creation error flow > > > > net/mlx5: fix Rx queue state update > > > > net/mlx5: fix types differentiation in Rxq create > > > > net/mlx5: mitigate Rx queue reference counters > > > > net/mlx5: separate Rx queue object creations > > > > net/mlx5: separate Rx interrupt handling > > > > net/mlx5: share Rx control code > > > > net/mlx5: rearrange the creation of RQ and CQ resources > > > > net/mlx5: rearrange the creation of WQ and CQ object > > > > net/mlx5: separate Rx queue object modification > > > > net/mlx5: share Rx queue object modification > > > > net/mlx5: separate Rx indirection table object creation > > > > net/mlx5: separate Rx hash queue creation > > > > net/mlx5: remove indirection table type field > > > > net/mlx5: share Rx queue indirection table code > > > > net/mlx5: share Rx hash queue code > > > > net/mlx5: separate Rx queue drop > > > > net/mlx5: share Rx queue drop action code > >
Hi, > -----Original Message----- > From: Michael Baum <michaelba@nvidia.com> > Sent: Thursday, September 3, 2020 1:14 PM > To: dev@dpdk.org > Cc: Matan Azrad <matan@nvidia.com>; Raslan Darawsheh > <rasland@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com> > Subject: [PATCH v1 00/18] mlx5 Rx DevX/Verbs separation > > v1: > Initial version > > Michael Baum (18): > net/mlx5: fix Rx hash queue creation error flow > net/mlx5: fix Rx queue state update > net/mlx5: fix types differentiation in Rxq create > net/mlx5: mitigate Rx queue reference counters > net/mlx5: separate Rx queue object creations > net/mlx5: separate Rx interrupt handling > net/mlx5: share Rx control code > net/mlx5: rearrange the creation of RQ and CQ resources > net/mlx5: rearrange the creation of WQ and CQ object > net/mlx5: separate Rx queue object modification > net/mlx5: share Rx queue object modification > net/mlx5: separate Rx indirection table object creation > net/mlx5: separate Rx hash queue creation > net/mlx5: remove indirection table type field > net/mlx5: share Rx queue indirection table code > net/mlx5: share Rx hash queue code > net/mlx5: separate Rx queue drop > net/mlx5: share Rx queue drop action code > > drivers/net/mlx5/Makefile | 1 + > drivers/net/mlx5/linux/mlx5_os.c | 10 + > drivers/net/mlx5/linux/mlx5_verbs.c | 707 +++++++++++++ > drivers/net/mlx5/linux/mlx5_verbs.h | 4 + > drivers/net/mlx5/meson.build | 1 + > drivers/net/mlx5/mlx5.h | 73 +- > drivers/net/mlx5/mlx5_devx.c | 792 +++++++++++++- > drivers/net/mlx5/mlx5_flow_dv.c | 20 +- > drivers/net/mlx5/mlx5_flow_verbs.c | 35 +- > drivers/net/mlx5/mlx5_rxq.c | 1934 ++++++----------------------------- > drivers/net/mlx5/mlx5_rxtx.h | 84 +- > drivers/net/mlx5/mlx5_trigger.c | 67 +- > drivers/net/mlx5/mlx5_vlan.c | 2 +- > 13 files changed, 1954 insertions(+), 1776 deletions(-) > > -- > 1.8.3.1 Series applied to next-net-mlx, Kindest regards, Raslan Darawsheh