Message ID | 1598961165-20832-1-git-send-email-humin29@huawei.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 05D99A04AC; Tue, 1 Sep 2020 14:00:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EDF161C129; Tue, 1 Sep 2020 13:55:03 +0200 (CEST) Received: from huawei.com (szxga07-in.huawei.com [45.249.212.35]) by dpdk.org (Postfix) with ESMTP id 1E24B1C126 for <dev@dpdk.org>; Tue, 1 Sep 2020 13:55:02 +0200 (CEST) Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 8DE72261FDFD61C645D4; Tue, 1 Sep 2020 19:54:59 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.487.0; Tue, 1 Sep 2020 19:54:58 +0800 From: "Min Hu (Connor)" <humin29@huawei.com> To: <dev@dpdk.org> CC: <ferruh.yigit@intel.com>, <stephen@networkplumber.org>, <bruce.richardson@intel.com>, <jerin.jacob@caviumnetworks.com> Date: Tue, 1 Sep 2020 19:52:41 +0800 Message-ID: <1598961165-20832-1-git-send-email-humin29@huawei.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1598923998-44155-1-git-send-email-humin29@huawei.com> References: <1598923998-44155-1-git-send-email-humin29@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.69.192.56] X-CFilter-Loop: Reflected Subject: [dpdk-dev] [PATCH 0/4] ethdev: change the queue ID type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series | ethdev: change the queue ID type | |
Message
humin (Q)
Sept. 1, 2020, 11:52 a.m. UTC
This series are minor change the queue ID type from uint8_t to uint16_t. Huisong Li (2): ethdev: change data type in TC rxq and TC txq ethdev: fix compiling errors for per-queue statistics Min Hu (Connor) (2): doc: announce modified field in DCB TC queue mapping doc: announce modified field in ethdev API app/test-pmd/cmdline.c | 2 +- app/test-pmd/config.c | 4 ++-- app/test-pmd/testpmd.c | 2 +- app/test-pmd/testpmd.h | 5 +++-- doc/guides/rel_notes/release_20_11.rst | 7 +++++++ drivers/net/igc/igc_ethdev.c | 4 ++-- drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++-- drivers/net/memif/rte_eth_memif.c | 2 +- drivers/net/octeontx2/otx2_ethdev.h | 2 +- drivers/net/octeontx2/otx2_stats.c | 2 +- drivers/net/virtio/virtio_ethdev.c | 4 ++-- lib/librte_ethdev/rte_ethdev.c | 6 +++--- lib/librte_ethdev/rte_ethdev.h | 12 ++++++------ lib/librte_ethdev/rte_ethdev_core.h | 2 +- 14 files changed, 33 insertions(+), 25 deletions(-)
Comments
On 9/1/2020 12:52 PM, Min Hu (Connor) wrote: > This series are minor change the queue ID type from > uint8_t to uint16_t. > > Huisong Li (2): > ethdev: change data type in TC rxq and TC txq > ethdev: fix compiling errors for per-queue statistics > > Min Hu (Connor) (2): > doc: announce modified field in DCB TC queue mapping > doc: announce modified field in ethdev API Hi Min, Huisong, deprecation notices are part of the process and it should be prepared one release before current release, it is good for two things: - requiring three ack ensures ABI/API breakage is really necessary and approved by multiple parties - it notifies the breakage to the users at least one release in advance to give them time to prepare for it. It doesn't really have a benefit to add and remove the deprecation notice in the same release. For the patches above both are ABI breakages and normally requires deprecation notice to be announced from previous release to be able to change them in this release. BUT, both are fixes and and I guess there is nothing controversial to update them, also if they are not fixed in this release they will need to wait for at least a year, so I am for getting them without deprecation notice in place. Unless there is a strong objection to it, lets continue without deprecation notices, and you can drop those patches from the set. > > app/test-pmd/cmdline.c | 2 +- > app/test-pmd/config.c | 4 ++-- > app/test-pmd/testpmd.c | 2 +- > app/test-pmd/testpmd.h | 5 +++-- > doc/guides/rel_notes/release_20_11.rst | 7 +++++++ > drivers/net/igc/igc_ethdev.c | 4 ++-- > drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++-- > drivers/net/memif/rte_eth_memif.c | 2 +- > drivers/net/octeontx2/otx2_ethdev.h | 2 +- > drivers/net/octeontx2/otx2_stats.c | 2 +- > drivers/net/virtio/virtio_ethdev.c | 4 ++-- > lib/librte_ethdev/rte_ethdev.c | 6 +++--- > lib/librte_ethdev/rte_ethdev.h | 12 ++++++------ > lib/librte_ethdev/rte_ethdev_core.h | 2 +- > 14 files changed, 33 insertions(+), 25 deletions(-) >