From patchwork Tue Aug 18 16:28:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fan Zhang X-Patchwork-Id: 75639 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A8AEA0353; Tue, 18 Aug 2020 18:28:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4D34B2BE2; Tue, 18 Aug 2020 18:28:51 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 11B4A2A62 for ; Tue, 18 Aug 2020 18:28:48 +0200 (CEST) IronPort-SDR: sKfTPMFOZ/h9/7NAdn3K+FkkTo3ZA/sONbfGpd/W5XUR0mYskRc0akZZmlTo2IOdPLEqWxxbEv Hp/V8S7UqfEQ== X-IronPort-AV: E=McAfee;i="6000,8403,9716"; a="135011797" X-IronPort-AV: E=Sophos;i="5.76,328,1592895600"; d="scan'208";a="135011797" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Aug 2020 09:28:37 -0700 IronPort-SDR: b+bcJppNXvqLo6YeN0olG70BMlVUGoQ8Vtpn1jPY4/rESe+slWCusKb+kgl/K0S0ufBL+ZwycX om9IjE7tI5PQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,328,1592895600"; d="scan'208";a="320148761" Received: from silpixa00398673.ir.intel.com (HELO silpixa00398673.ger.corp.intel.com) ([10.237.223.136]) by fmsmga004.fm.intel.com with ESMTP; 18 Aug 2020 09:28:36 -0700 From: Fan Zhang To: dev@dpdk.org Cc: akhil.goyal@nxp.com, fiona.trahe@intel.com, ArkadiuszX.Kusztal@intel.com, AdamX.Dybkowski@intel.com, Fan Zhang Date: Tue, 18 Aug 2020 17:28:29 +0100 Message-Id: <20200818162833.20219-1-roy.fan.zhang@intel.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [dpdk-dev] [dpdk-dev v6 0/4] cryptodev: add data-path service APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Direct crypto data-path service are a set of APIs that especially provided for the external libraries/applications who want to take advantage of the rich features provided by cryptodev, but not necessarily depend on cryptodev operations, mempools, or mbufs in the their data-path implementations. The direct crypto data-path service has the following advantages: - Supports raw data pointer and physical addresses as input. - Do not require specific data structure allocated from heap, such as cryptodev operation. - Enqueue in a burst or single operation. The service allow enqueuing in a burst similar to ``rte_cryptodev_enqueue_burst`` operation, or only enqueue one job at a time but maintaining necessary context data locally for next single job enqueue operation. The latter method is especially helpful when the user application's crypto operations are clustered into a burst. Allowing enqueue one operation at a time helps reducing one additional loop and also reduced the cache misses during the double "looping" situation. - Customerizable dequeue count. Instead of dequeue maximum possible operations as same as ``rte_cryptodev_dequeue_burst`` operation, the service allows the user to provide a callback function to decide how many operations to be dequeued. This is especially helpful when the expected dequeue count is hidden inside the opaque data stored during enqueue. The user can provide the callback function to parse the opaque data structure. - Abandon enqueue and dequeue anytime. One of the drawbacks of ``rte_cryptodev_enqueue_burst`` and ``rte_cryptodev_dequeue_burst`` operations are: once an operation is enqueued/dequeued there is no way to undo the operation. The service make the operation abandon possible by creating a local copy of the queue operation data in the service context data. The data will be written back to driver maintained operation data when enqueue or dequeue done function is called. The cryptodev data-path service uses Cryptodev PMDs who supports this feature will have ``RTE_CRYPTODEV_FF_SYM_HW_DIRECT_API`` feature flag presented. To use this feature the function ``rte_cryptodev_get_dp_service_ctx_data_size`` should be called to get the data path service context data size. The user should creates a local buffer at least this size long and initialize it using ``rte_cryptodev_dp_configure_service`` function call. The ``rte_cryptodev_dp_configure_service`` function call initialize or updates the ``struct rte_crypto_dp_service_ctx`` buffer, in which contains the driver specific queue pair data pointer and service context buffer, and a set of function pointers to enqueue and dequeue different algorithms' operations. The ``rte_cryptodev_dp_configure_service`` should be called when: - Before enqueuing or dequeuing starts (set ``is_update`` parameter to 0). - When different cryptodev session, security session, or session-less xform is used (set ``is_update`` parameter to 1). Two different enqueue functions are provided. - ``rte_cryptodev_dp_sym_submit_vec``: submit a burst of operations stored in the ``rte_crypto_sym_vec`` structure. - ``rte_cryptodev_dp_submit_single_job``: submit single operation. Either enqueue functions will not command the crypto device to start processing until ``rte_cryptodev_dp_submit_done`` function is called. Before then the user shall expect the driver only stores the necessory context data in the ``rte_crypto_dp_service_ctx`` buffer for the next enqueue operation. If the user wants to abandon the submitted operations, simply call ``rte_cryptodev_dp_configure_service`` function instead with the parameter ``is_update`` set to 0. The driver will recover the service context data to the previous state. To dequeue the operations the user also have two operations: - ``rte_cryptodev_dp_sym_dequeue``: fully customizable deuqueue operation. The user needs to provide the callback function for the driver to get the dequeue count and perform post processing such as write the status field. - ``rte_cryptodev_dp_sym_dequeue_single_job``: dequeue single job. Same as enqueue, the function ``rte_cryptodev_dp_dequeue_done`` is used to merge user's local service context data with the driver's queue operation data. Also to abandon the dequeue operation (still keep the operations in the queue), the user shall avoid ``rte_cryptodev_dp_dequeue_done`` function call but calling ``rte_cryptodev_dp_configure_service`` function with the parameter ``is_update`` set to 0. There are a few limitations to the data path service: * Only support in-place operations. * APIs are NOT thread-safe. * CANNOT mix the direct API's enqueue with rte_cryptodev_enqueue_burst, or vice versa. v6: - Rebased on top of DPDK 20.08. - Changed to service ctx and added single job submit/dequeue. v5: - Changed to use rte_crypto_sym_vec as input. - Changed to use public APIs instead of use function pointer. v4: - Added missed patch. v3: - Instead of QAT only API, moved the API to cryptodev. - Added cryptodev feature flags. v2: - Used a structure to simplify parameters. - Added unit tests. - Added documentation. Fan Zhang (4): cryptodev: add crypto data-path service APIs crypto/qat: add crypto data-path service API support test/crypto: add unit-test for cryptodev direct APIs doc: add cryptodev service APIs guide app/test/test_cryptodev.c | 354 ++++++- app/test/test_cryptodev.h | 6 + app/test/test_cryptodev_blockcipher.c | 50 +- doc/guides/prog_guide/cryptodev_lib.rst | 90 ++ drivers/common/qat/Makefile | 1 + drivers/crypto/qat/meson.build | 1 + drivers/crypto/qat/qat_sym.h | 13 + drivers/crypto/qat/qat_sym_hw_dp.c | 923 ++++++++++++++++++ drivers/crypto/qat/qat_sym_pmd.c | 9 +- lib/librte_cryptodev/rte_crypto.h | 9 + lib/librte_cryptodev/rte_crypto_sym.h | 44 +- lib/librte_cryptodev/rte_cryptodev.c | 45 + lib/librte_cryptodev/rte_cryptodev.h | 335 ++++++- lib/librte_cryptodev/rte_cryptodev_pmd.h | 47 +- .../rte_cryptodev_version.map | 10 + 15 files changed, 1889 insertions(+), 48 deletions(-) create mode 100644 drivers/crypto/qat/qat_sym_hw_dp.c