From patchwork Mon Aug 17 14:08:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Renata Saiakhova X-Patchwork-Id: 75580 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B1C44A0351; Mon, 17 Aug 2020 16:09:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2596A1C0BC; Mon, 17 Aug 2020 16:09:01 +0200 (CEST) Received: from FRA01-MR2-obe.outbound.protection.outlook.com (mail-eopbgr90092.outbound.protection.outlook.com [40.107.9.92]) by dpdk.org (Postfix) with ESMTP id F257C1C020 for ; Mon, 17 Aug 2020 16:08:59 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JuO+zqX7ETNLYIta53a5kJRrXLyU+P1lh3fM+LtO9DFjkfZVjUTMadep7Xw6GSzfIou58IgVUuoOmHVHY/UfjtZWkiiSkBnYXjbEk3OjWcP3d4/W9ltixPtSgZgqveoB2dOOZFAwDUo2oXPEQcWstxAtRwcZyN8W+oQnc1NYLzGvFdQD2dZXv7Vz4264QbU3mjrs0UsVSzdtkDi6MbnwG0Fs8kJCDbpp2yxUtvWxftjCQcflDn+LmLXn9h38e7KsHzHC0JgqyMBb0YORsNrIUeJzKjXn17cF3EDv65em83cWJuSpnhCWhYRHX3KNYWJgrQvYyUsBxebX5AksUDx39w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cYja3scQbPqtuS1wnc/bXA+RDPVXXoERT/6KXJh68yQ=; b=jLVfa2Q8wXBpp2q1nanozsit/zrkitniUwM3179NxfgPhADtpZ3u6jrrbpEUnUHVqP4JImEwCDuacnJTLKfNb+p7pmL+f1GA7odLuoPUhtLUH9Is6ewldZD00K9g6/j+3ZVwMwZ2glxDUZcdk/0vbd0GxycfptFo42stHZ9jw85dNpcY13mebKm0dclEuAi8HfI03S3tLMzja7Omu32jGRibZuEASE7ym3AvMNbHJmih1sE2ixVSKtc/felWcFFwvhZ5ZLHoCyTAIY2+3Q1+4ql/e9AkHNfD0aXThzyPvWWrLrCPEyGBRadaF+/dplj5cVr3wMNYGGPml9ZaIaabyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ekinops.com; dmarc=pass action=none header.from=ekinops.com; dkim=pass header.d=ekinops.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ekinops.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cYja3scQbPqtuS1wnc/bXA+RDPVXXoERT/6KXJh68yQ=; b=uKchKJJXQUA3fxDoP3pAHpmh937kRaLQg/9rpmaKFhEapCgFQ/o/KUyzy59inN+V2LkP7Pj2F7GZrnHyxC7L9yt5FcpbqG1RNt2xo4FXRqiyy96rVkEO+eWqYWudErm305G9j2THr+rKQ1fmtLj0in4D5shjOV5xboG9L1v5UnU= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=ekinops.com; Received: from MRXP264MB0120.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:1b::10) by MR2P264MB0737.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:2::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.24; Mon, 17 Aug 2020 14:08:59 +0000 Received: from MRXP264MB0120.FRAP264.PROD.OUTLOOK.COM ([fe80::f1e9:2264:9185:a3e6]) by MRXP264MB0120.FRAP264.PROD.OUTLOOK.COM ([fe80::f1e9:2264:9185:a3e6%2]) with mapi id 15.20.3283.028; Mon, 17 Aug 2020 14:08:59 +0000 From: Renata Saiakhova To: Cc: dev@dpdk.org, Renata Saiakhova Date: Mon, 17 Aug 2020 16:08:26 +0200 Message-Id: <20200817140828.9769-1-Renata.Saiakhova@ekinops.com> X-Mailer: git-send-email 2.17.2 X-ClientProxiedBy: AM0PR01CA0119.eurprd01.prod.exchangelabs.com (2603:10a6:208:168::24) To MRXP264MB0120.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:1b::10) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from renataOAB.oneaccess.intra (91.183.184.98) by AM0PR01CA0119.eurprd01.prod.exchangelabs.com (2603:10a6:208:168::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.15 via Frontend Transport; Mon, 17 Aug 2020 14:08:58 +0000 X-Mailer: git-send-email 2.17.2 X-Originating-IP: [91.183.184.98] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 20cd6a40-2a9b-4f4c-db9c-08d842b715fe X-MS-TrafficTypeDiagnostic: MR2P264MB0737: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: k/DtkWoxt/GhSu3R1SHJ3IGsF1BTecCZdU8fjsHEP5rO/jd6S9XXOMeobcxf5id2UTojs+4xhGguVh+BXwxlbFaE0TzEkv9pw3cePuEFk7PDAbOQBpoCUWXIZCbX5Vw9QR+mFT6CpVqAcwl24I1h7kPosLy39k1NSaQzVUyhTVjLZHledPI3lKFKCUHxfcZVEsHo/wweQ9e1KYb3IzUww/VnhQ3n1d3BMg3cF7hRh4oTQ+AhtcUEW3DGPd05L56rOl4bZo1IlVYctpxKcFaJdzUKo9dsQ70zsqoER10qRuy1AanaQ17MkpPoV7jwOWeoPq8PtFK6SpN8gTq6s3piGJv/nOEVFwQod8ca42+l9n3Jk82PkHCiV1MpEomyx2bt X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MRXP264MB0120.FRAP264.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(366004)(136003)(396003)(39850400004)(376002)(346002)(8936002)(52116002)(8676002)(6506007)(6486002)(109986005)(36756003)(478600001)(107886003)(1076003)(5660300002)(6512007)(86362001)(316002)(66556008)(6666004)(66946007)(66476007)(2906002)(956004)(2616005)(4326008)(26005)(83380400001)(186003)(16526019)(266003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: GhgkLMtaFmd+YiCbGC5jXMjLoSX9eWu6+TROb2aouLfHWwCkh0tz2yajHE2STEtoYyucW/tu2pjmUOh3vljLdJ4Kt8qjGEOmlM79YxVBNT/GvbxESd0wbqY9FVILSXqmrk3JYP7ZZLNZeA27E7jy7KYdiUzhgX/aubwUI+rIdNAy14/TqummsN4e+Q/K/RPSPPmJf/mTZIyPPOhdePAgwMnKgVYRFJE/O5fICS8c1mPaHWxm763CoqfejHOaTxPTP1zHVRcM7SC6vCmUPCd13dX0E0vsDZ9x5IRqkLPPg8fpBXDMydQmtk3U5rM+4SAYdvOr59CE5GeEeUv8CvRjuVOiJJK0Uuf76DbyLZz40k9lqPbDWXThqRyB8GQT9+DV0BPW7Y5MsyUYbfbw21RfFoSebNqJrE20sUlmoDm9G+3gqOQINEvSIdJSzswI4qsFmnlYqDP/EIRFuXEsM5sonexTgPY2fxoZcm2i/r7y9t1aYYhHjiUA1jGb25KLxkFMtIcZ9yYnnqBetb16bMrWUBAhKiesvsTWJc0pJT7nhyrnwj0zYmkrp+KZsw/8+k2dkNe3IBreKeEyD2fRcMs/drNMUGhIUB56FdcnDj/QhzrqQzHqAx45g/gZTwKarMVV+TljWoL0lFYN2KfYPTxJOw== X-OriginatorOrg: ekinops.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20cd6a40-2a9b-4f4c-db9c-08d842b715fe X-MS-Exchange-CrossTenant-AuthSource: MRXP264MB0120.FRAP264.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2020 14:08:59.0496 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f57b78a6-c654-4771-a72f-837275f46179 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gyPDoRab3U2glIQkQeXdVrmHGQrf8tMoMpP7UGP+ztR4rtSrVsMdqP7utPr832Qe/ySwH2i3BDztrirso4d+GRYo6mJeC9HDHioS3qc9qKQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MR2P264MB0737 Subject: [dpdk-dev] [PATCH v2 0/1] pci_vfio_disable_notifier(): avoid race with unregister X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" For pci_vfio, while removing the device by rte_dev_remove(), pci_vfio_disable_notifier() will call rte_intr_callback_unregister(), which may return -EAGAIN, if an interrupt source (kernel) has some active callbacks right now. As a result, the callback (req notifier) can be never unregistered, and the corresponding descriptor (vfio_req_intr_handle.fd) can be never closed. The kernel will continuously try to notify the user space using req notifier, but as the device is already removed, in this case it even cannot find a bus for that device, the log is full of messages "EAL: Cannot find bus for device (XX:XX.X)" v1->v2: Use only for pci-vfio in pci_vfio_disable_notifier() Renata Saiakhova (1): librte_eal: rte_intr_callback_unregister_sync() - wrapper around rte_intr_callback_unregister(). drivers/bus/pci/linux/pci_vfio.c | 2 +- lib/librte_eal/freebsd/eal_interrupts.c | 12 ++++++++++++ lib/librte_eal/include/rte_interrupts.h | 25 +++++++++++++++++++++++++ lib/librte_eal/linux/eal_interrupts.c | 12 ++++++++++++ lib/librte_eal/rte_eal_version.map | 1 + 5 files changed, 51 insertions(+), 1 deletion(-)