From patchwork Wed Jul 29 13:36:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Coquelin X-Patchwork-Id: 74997 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D091CA052B; Wed, 29 Jul 2020 15:36:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9F9DCA69; Wed, 29 Jul 2020 15:36:45 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id E7EAA2AB for ; Wed, 29 Jul 2020 15:36:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596029804; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mu6UYn9wkkw4uEm+7lajGJ2rHGC5bhO/9Uvi6mtOG1A=; b=Nbt4NOFt5fl68tCmJHM4eiNP+erf2e3z/9vhSSUlrTERTmE3nrF7iU/SEWf3PA41AmnHHh N6ze3UOZhtvV6xQUDzwuaXcWaG8aamF+ctdEeKFreHEM1AMSViK43CHd+eERP/W9le4RKm srue30fPShVKjDAJZFCOqH91iQVNESo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-30-EuvnY9pKP62wC8m7Nxjnjw-1; Wed, 29 Jul 2020 09:36:40 -0400 X-MC-Unique: EuvnY9pKP62wC8m7Nxjnjw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4960E8017FB; Wed, 29 Jul 2020 13:36:39 +0000 (UTC) Received: from localhost.localdomain (unknown [10.36.110.21]) by smtp.corp.redhat.com (Postfix) with ESMTP id CE70661100; Wed, 29 Jul 2020 13:36:30 +0000 (UTC) From: Maxime Coquelin To: dev@dpdk.org, matan@mellanox.com, chenbo.xia@intel.com, yong.liu@intel.com, yinan.wang@intel.com Cc: thomas@monjalon.net, ferruh.yigit@intel.com, david.marchand@redhat.com, Maxime Coquelin Date: Wed, 29 Jul 2020 15:36:23 +0200 Message-Id: <20200729133626.237098-1-maxime.coquelin@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [dpdk-dev] [PATCH v4 0/3] Fix Vhost regressions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This series aims at fixing the regressions reported by Intel QE. I managed to reproduce the issues, and this series fixes them. The two first patches fix the performance regression. They have been tested by intel QE which confirms the fix. Patch 3 aims at fixing interrupt mode. In this v4, only changes are adding NULL check on the intr handle, to avoid segfault reproduced with using Virtio-user on the other end when quitting testpmd. It also add an error log when a valid kickfd get updated as suggested by David as it should not happen. Minor typos reported by David are also fixed. There are still l3fwd-power flooding errors when leaving, but these were already here in v20.05. This is an issue in the application, not the PMD driver. Thanks to Intel QE team for all the validation work! Maxime Maxime Coquelin (3): vhost: fix guest notification setting net/vhost: fix queue update net/vhost: fix interrupt mode drivers/net/vhost/rte_eth_vhost.c | 109 +++++++++++++++++++++++------- lib/librte_vhost/vhost.c | 24 +++++-- lib/librte_vhost/vhost.h | 5 ++ lib/librte_vhost/vhost_user.c | 11 ++- 4 files changed, 118 insertions(+), 31 deletions(-)