mbox series

[v4,0/3] Fix Vhost regressions

Message ID 20200729133626.237098-1-maxime.coquelin@redhat.com (mailing list archive)
Headers
Series Fix Vhost regressions |

Message

Maxime Coquelin July 29, 2020, 1:36 p.m. UTC 
  This series aims at fixing the regressions reported by Intel QE.
I managed to reproduce the issues, and this series fixes them.

The two first patches fix the performance regression. They have
been tested by intel QE which confirms the fix.

Patch 3 aims at fixing interrupt mode.

In this v4, only changes are adding NULL check on the intr handle,
to avoid segfault reproduced with using Virtio-user on the other end
when quitting testpmd. It also add an error log when a valid kickfd
get updated as suggested by David as it should not happen. Minor typos
reported by David are also fixed.

There are still l3fwd-power flooding errors when leaving, but these
were already here in v20.05. This is an issue in the application,
not the PMD driver.

Thanks to Intel QE team for all the validation work!
Maxime


Maxime Coquelin (3):
  vhost: fix guest notification setting
  net/vhost: fix queue update
  net/vhost: fix interrupt mode

 drivers/net/vhost/rte_eth_vhost.c | 109 +++++++++++++++++++++++-------
 lib/librte_vhost/vhost.c          |  24 +++++--
 lib/librte_vhost/vhost.h          |   5 ++
 lib/librte_vhost/vhost_user.c     |  11 ++-
 4 files changed, 118 insertions(+), 31 deletions(-)

Comments

Maxime Coquelin July 29, 2020, 2:54 p.m. UTC | #1 
On 7/29/20 3:36 PM, Maxime Coquelin wrote:
> This series aims at fixing the regressions reported by Intel QE.
> I managed to reproduce the issues, and this series fixes them.
> 
> The two first patches fix the performance regression. They have
> been tested by intel QE which confirms the fix.
> 
> Patch 3 aims at fixing interrupt mode.
> 
> In this v4, only changes are adding NULL check on the intr handle,
> to avoid segfault reproduced with using Virtio-user on the other end
> when quitting testpmd. It also add an error log when a valid kickfd
> get updated as suggested by David as it should not happen. Minor typos
> reported by David are also fixed.
> 
> There are still l3fwd-power flooding errors when leaving, but these
> were already here in v20.05. This is an issue in the application,
> not the PMD driver.
> 
> Thanks to Intel QE team for all the validation work!
> Maxime
> 
> 
> Maxime Coquelin (3):
>   vhost: fix guest notification setting
>   net/vhost: fix queue update
>   net/vhost: fix interrupt mode
> 
>  drivers/net/vhost/rte_eth_vhost.c | 109 +++++++++++++++++++++++-------
>  lib/librte_vhost/vhost.c          |  24 +++++--
>  lib/librte_vhost/vhost.h          |   5 ++
>  lib/librte_vhost/vhost_user.c     |  11 ++-
>  4 files changed, 118 insertions(+), 31 deletions(-)
> 

Applied to dpdk-next-virtio/master.

Thanks,
Maxime