mbox series

[v2,0/3] Fix Vhost regressions

Message ID 20200728165021.216291-1-maxime.coquelin@redhat.com (mailing list archive)
Headers
Series Fix Vhost regressions |

Message

Maxime Coquelin July 28, 2020, 4:50 p.m. UTC 
  This series aims at fixing the regressions reported by Intel QE.
I managed to reproduce the issues, and this series fixes them.

The two first patches fix the performance regression. They have
been tested by intel QE which confirms the fix.

The third patch fixes the interrupt regression. I tested it OK
with l3fwd-power use-case, but it has not been confirmed by Intel
QE yet. The fix could be further improved in the future by
introducing a dedicated API in rte_epoll library to update epoll
events.

Thanks to Intel QE team for all the validation work!
Maxime

Maxime Coquelin (3):
  vhost: fix guest notification setting
  net/vhost: fix queue update
  net/vhost: fix interrupt mode

 drivers/net/vhost/rte_eth_vhost.c | 61 ++++++++++++++++++++-----------
 lib/librte_vhost/vhost.c          | 24 ++++++++++--
 lib/librte_vhost/vhost.h          |  5 +++
 lib/librte_vhost/vhost_user.c     | 11 ++++--
 4 files changed, 72 insertions(+), 29 deletions(-)

Comments

Wang, Yinan July 29, 2020, 6:08 a.m. UTC | #1 
This patch can fix multi-queue performance drop issue and interrupt issue.Thanks!

BR,
Yinan

> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: 2020?7?29? 0:50
> To: dev@dpdk.org; matan@mellanox.com; Xia, Chenbo
> <chenbo.xia@intel.com>; Liu, Yong <yong.liu@intel.com>; Wang, Yinan
> <yinan.wang@intel.com>
> Cc: thomas@monjalon.net; Yigit, Ferruh <ferruh.yigit@intel.com>;
> david.marchand@redhat.com; Maxime Coquelin
> <maxime.coquelin@redhat.com>
> Subject: [PATCH v2 0/3] Fix Vhost regressions
> 
> This series aims at fixing the regressions reported by Intel QE.
> I managed to reproduce the issues, and this series fixes them.
> 
> The two first patches fix the performance regression. They have
> been tested by intel QE which confirms the fix.
> 
> The third patch fixes the interrupt regression. I tested it OK
> with l3fwd-power use-case, but it has not been confirmed by Intel
> QE yet. The fix could be further improved in the future by
> introducing a dedicated API in rte_epoll library to update epoll
> events.
> 
> Thanks to Intel QE team for all the validation work!
> Maxime
> 
> Maxime Coquelin (3):
>   vhost: fix guest notification setting
>   net/vhost: fix queue update
>   net/vhost: fix interrupt mode
> 
>  drivers/net/vhost/rte_eth_vhost.c | 61 ++++++++++++++++++++-----------
>  lib/librte_vhost/vhost.c          | 24 ++++++++++--
>  lib/librte_vhost/vhost.h          |  5 +++
>  lib/librte_vhost/vhost_user.c     | 11 ++++--
>  4 files changed, 72 insertions(+), 29 deletions(-)
> 
> --
> 2.26.2