From patchwork Fri Jul 24 09:00:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Renata Saiakhova X-Patchwork-Id: 74737 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E3A50A0518; Fri, 24 Jul 2020 11:01:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CD4321C032; Fri, 24 Jul 2020 11:01:16 +0200 (CEST) Received: from FRA01-MR2-obe.outbound.protection.outlook.com (mail-eopbgr90122.outbound.protection.outlook.com [40.107.9.122]) by dpdk.org (Postfix) with ESMTP id B54231C025 for ; Fri, 24 Jul 2020 11:01:15 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EOf8UgqdiGH4q9MR4rwT6qaSI/bU14dA0qd2/plN5huP7zcvG2oXmvdMOqRCxXO8EsQXx15DdBKIlQU1Us1qLNfwCE3TfsrsvfLhrU+kho5c446NojomSB0mkYh3nz/EFqbAzw0lXst+NDrGosElKWd5P6sXsb5eoliezZbiv/ZJFFdDFC+RQZ1nUVrlI9j73ZFG5AvMV1SuXufpnhotoYu/CZpv9vtoo0lldyhZagZH/u8uo7FNppifH7vqwLcsgHNkK/HRHfr99/BDT7fgFLaCiAbPAqeaK7E+BbcWdp9unD8Gswp6luNhSaprPMdXuSxwOZHCAtUSKAU6k3NizA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gIvoCYvMQ299Oq+EVpZTHYLMGI6Mj/AUDSKFTb8zDlA=; b=gMsZBxl8xicEz2bHQhHzdkqdiO9/GlqzEV43lVCTbXjXO1R9DzE29VkhtTllXNU0ogz5OatOFW6UlnKFjP5qlANlT+OVQ8XuSiC5MVR53tcMEQAAZxDZfvCxSEddUoRZTisVraxwdnOe/XIwaGEgnejLwPZk8tqWRy6QaAaeREvlQQPTxBYloPYGapIXOpFXUflJ81wWmHrLkKA2sG1xiowmJOqtE99E0kp7lsdMnMbFrqJdiCcWAwD/vFBS2bmlxdoPczvOvWd2eG/kpTkzoQhYWjpDSst9Z+iOxXPLVMGBrLEZOYYcdfXyiIEw5QaEp7ej5CbQb2KC2Z6lg1SODQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ekinops.com; dmarc=pass action=none header.from=ekinops.com; dkim=pass header.d=ekinops.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ekinops.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gIvoCYvMQ299Oq+EVpZTHYLMGI6Mj/AUDSKFTb8zDlA=; b=PYELOmsz67nJHpCe646qTE5URKkK7HVFlBYq5/trM5U/L4xBKAv4r6j9M1SNRwdWCYNkBQbe2eJ/0uqx5wWDWhrFFOey83EOrOi60BAsssh3xTefI3IVPfZNNGbYHt3m9BAgKOlokCKbcwRXPLGlkk8B9pyEhZ2sUE9Lp98djng= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=ekinops.com; Received: from MRXP264MB0120.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:1b::10) by MRXP264MB0503.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:21::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.22; Fri, 24 Jul 2020 09:01:15 +0000 Received: from MRXP264MB0120.FRAP264.PROD.OUTLOOK.COM ([fe80::b9c3:a77c:6837:2548]) by MRXP264MB0120.FRAP264.PROD.OUTLOOK.COM ([fe80::b9c3:a77c:6837:2548%6]) with mapi id 15.20.3216.024; Fri, 24 Jul 2020 09:01:15 +0000 From: Renata Saiakhova To: Cc: dev@dpdk.org, Renata Saiakhova Date: Fri, 24 Jul 2020 11:00:10 +0200 Message-Id: <20200724090011.17157-1-Renata.Saiakhova@ekinops.com> X-Mailer: git-send-email 2.17.2 X-ClientProxiedBy: AM3PR05CA0117.eurprd05.prod.outlook.com (2603:10a6:207:2::19) To MRXP264MB0120.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:1b::10) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from renataOAB.oneaccess.intra (91.183.184.98) by AM3PR05CA0117.eurprd05.prod.outlook.com (2603:10a6:207:2::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.22 via Frontend Transport; Fri, 24 Jul 2020 09:01:14 +0000 X-Mailer: git-send-email 2.17.2 X-Originating-IP: [91.183.184.98] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3d5fec10-9357-4a06-2537-08d82fb01e9a X-MS-TrafficTypeDiagnostic: MRXP264MB0503: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: p4SR2uyJS3SdRV/3FtgNRzoYllFV7Z8hKIxat0WIqIfRbpnxxnNDeIsCdkRbTAa94++6f/0DSKZ2vBOILa/uPL3QIICxjIa/G+rLEnIY5xeepLxjHtD8fEJNeYCzGN/wDdmdHFLTGA06u6/ZENWfUFBO+ak+3yLpptHX5ZLeA2MJOvfKxCBST3f9ZJmljf3dkAe5FVjYIQQuBHWM2y7gCVnzZ+vMmXrw1q2+URh4m+CS2McmkVRVv/HK4+rSITdoIqrqziqVJBHVaf1nkqSbLdta7zjYXJ+cxP/aj1nYlz3LmoUG1+5QE+sutXz4POAQBwSARfoPKcUdH8rSk+EEE31SopJrKxGwvcQfxX8+qWg4sru6jT9vGGJee//AdtEe X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MRXP264MB0120.FRAP264.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFTY:; SFS:(39850400004)(396003)(346002)(376002)(136003)(366004)(2906002)(186003)(83380400001)(66946007)(16526019)(1076003)(66556008)(6666004)(36756003)(6506007)(4326008)(2616005)(956004)(107886003)(109986005)(26005)(52116002)(66476007)(478600001)(8676002)(316002)(6486002)(8936002)(4744005)(86362001)(6512007)(5660300002)(266003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: Yd5tPKkfkYT/GDUBj+MALhC6ymE8DBWiORq1e9cKaMmg+rLZzrP/rnQUyRN4+mJCQBt9lfY0U/9mUoXO4pixsh5LzS1zR6vEegSCaVffV2Izx31NA1z7l55kt4v8HRkSNOp569yxfWwtmUPeabwLJUByPU54E7ocb3YCnP62iSk38bLGR7FtJ/CO+3iJz036y8Qi7AEO8xzo25yYnATN05R+trNTvjWRDvUyk080Xfcdu0i8Ga7k6sLgicU6fIoNBy+pDTWxU5AkjAskk4vaaqfzdim6mwAsMLrLOIIG6vGIwfyf+qiH2ID260T662dRsAb24X7PPzuaSV9aYXwk5bEm9tE9VgLJ681iZUEU/OwwFWg3oi18Dsa84WrrbBLoA1pK93i4q7E7Qoq6+Vc4zhbDhKZx/+n5x/f8HgWJDTnarDnp9jQg+yvZOPTzLPexx/w6PeOZoQnBVuKmiVfogCvPsPgpo3f19KoC09Hirhw= X-OriginatorOrg: ekinops.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3d5fec10-9357-4a06-2537-08d82fb01e9a X-MS-Exchange-CrossTenant-AuthSource: MRXP264MB0120.FRAP264.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2020 09:01:14.8972 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f57b78a6-c654-4771-a72f-837275f46179 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TmL0/FP5Budd0RgL2f1BcXuwjUBEoYIRogDPaSv0a2lxQheeIm79DyinyNelZjdmvA+3lpEdGUBIQ0/4Y6qpj6o0XGH6eDTsMaCRAKPXNA8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MRXP264MB0503 Subject: [dpdk-dev] [PATCH 0/1] Avoid race with unregister interrupt hanlder if interrupt X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" For pci_vfio, while removing the device by rte_dev_remove(), pci_vfio_disable_notifier() will call rte_intr_callback_unregister(), which may return -EAGAIN, if an interrupt source (kernel) has some active callbacks right now. As a result, the callback (req notifier) can be never unregistered, and the corresponding descriptor (vfio_req_intr_handle.fd) can be never closed. The kernel will continuously try to notify the user space using req notifier, but as the device is already removed, in this case it even cannot find a bus for that device, the log is full of messages "EAL: Cannot find bus for device (XX:XX.X)" Renata Saiakhova (1): librte_eal: wrapper around rte_intr_callback_unregister(). lib/librte_eal/freebsd/eal_interrupts.c | 16 ++++++++++++++-- lib/librte_eal/linux/eal_interrupts.c | 16 ++++++++++++++-- 2 files changed, 28 insertions(+), 4 deletions(-)