mbox series

[v3,0/7] improve DPDK static builds with meson

Message ID 20200630141433.818517-1-bruce.richardson@intel.com (mailing list archive)
Headers
Series improve DPDK static builds with meson |

Message

Bruce Richardson June 30, 2020, 2:14 p.m. UTC 
  This set fixes a number of minor issues with static builds when using
meson, both for linking apps/examples as part of a meson build itself or
when using pkg-config subsequently.

Following this patchset, all DPDK static builds should be linking with
--whole-archive to ensure all lib and driver constructors are included,
and the use of pkg-config for doing static builds is simplified. The
downside is that for correctness we need two .pc files for DPDK rather
than just one.

v3: rebased to latest on main branch

v2: improved log messages for a number of patches, and clearly marked
    internal-only pkg-config file as such

Bruce Richardson (7):
  build: always link-whole DPDK static libraries
  build: remove unnecessary variable
  devtools/test-meson-builds.sh: add pkg-config static builds
  build: move pkg-config creation to separate file
  build/pkg-config: output driver libs first for static build
  build/pkg-config: improve static linking flags
  build/pkg-config: prevent overlinking

 app/meson.build                               |  2 +-
 app/test/meson.build                          |  2 +-
 buildtools/pkg-config/meson.build             | 44 +++++++++++++++++++
 .../pkg-config/set-static-linker-flags.py     | 38 ++++++++++++++++
 devtools/test-meson-builds.sh                 |  2 +-
 doc/guides/prog_guide/build-sdk-meson.rst     |  2 +-
 drivers/meson.build                           |  2 +-
 examples/bbdev_app/Makefile                   |  2 +-
 examples/bond/Makefile                        |  2 +-
 examples/cmdline/Makefile                     |  2 +-
 examples/distributor/Makefile                 |  2 +-
 examples/eventdev_pipeline/Makefile           |  2 +-
 examples/fips_validation/Makefile             |  2 +-
 examples/flow_classify/Makefile               |  2 +-
 examples/flow_filtering/Makefile              |  2 +-
 examples/helloworld/Makefile                  |  2 +-
 examples/ioat/Makefile                        |  2 +-
 examples/ip_fragmentation/Makefile            |  2 +-
 examples/ip_pipeline/Makefile                 |  2 +-
 examples/ip_reassembly/Makefile               |  2 +-
 examples/ipsec-secgw/Makefile                 |  2 +-
 examples/ipv4_multicast/Makefile              |  2 +-
 examples/kni/Makefile                         |  2 +-
 examples/l2fwd-cat/Makefile                   |  2 +-
 examples/l2fwd-crypto/Makefile                |  2 +-
 examples/l2fwd-event/Makefile                 |  2 +-
 examples/l2fwd-jobstats/Makefile              |  2 +-
 examples/l2fwd-keepalive/Makefile             |  2 +-
 examples/l2fwd/Makefile                       |  2 +-
 examples/l3fwd-acl/Makefile                   |  2 +-
 examples/l3fwd-power/Makefile                 |  2 +-
 examples/l3fwd/Makefile                       |  2 +-
 examples/link_status_interrupt/Makefile       |  2 +-
 examples/meson.build                          |  6 +--
 examples/ntb/Makefile                         |  2 +-
 examples/packet_ordering/Makefile             |  2 +-
 examples/ptpclient/Makefile                   |  2 +-
 examples/qos_meter/Makefile                   |  2 +-
 examples/qos_sched/Makefile                   |  2 +-
 examples/rxtx_callbacks/Makefile              |  2 +-
 examples/service_cores/Makefile               |  2 +-
 examples/skeleton/Makefile                    |  2 +-
 examples/tep_termination/Makefile             |  2 +-
 examples/timer/Makefile                       |  2 +-
 examples/vdpa/Makefile                        |  2 +-
 examples/vhost/Makefile                       |  2 +-
 examples/vhost_blk/Makefile                   |  2 +-
 examples/vhost_crypto/Makefile                |  2 +-
 examples/vmdq/Makefile                        |  2 +-
 examples/vmdq_dcb/Makefile                    |  2 +-
 lib/meson.build                               |  2 +-
 meson.build                                   | 26 +----------
 52 files changed, 135 insertions(+), 75 deletions(-)
 create mode 100644 buildtools/pkg-config/meson.build
 create mode 100644 buildtools/pkg-config/set-static-linker-flags.py

Comments

Thomas Monjalon July 1, 2020, 5:33 p.m. UTC | #1 
30/06/2020 16:14, Bruce Richardson:
> This set fixes a number of minor issues with static builds when using
> meson, both for linking apps/examples as part of a meson build itself or
> when using pkg-config subsequently.
> 
> Following this patchset, all DPDK static builds should be linking with
> --whole-archive to ensure all lib and driver constructors are included,
> and the use of pkg-config for doing static builds is simplified. The
> downside is that for correctness we need two .pc files for DPDK rather
> than just one.
> 
> v3: rebased to latest on main branch
> 
> v2: improved log messages for a number of patches, and clearly marked
>     internal-only pkg-config file as such
> 
> Bruce Richardson (7):
>   build: always link-whole DPDK static libraries
>   build: remove unnecessary variable
>   devtools/test-meson-builds.sh: add pkg-config static builds
>   build: move pkg-config creation to separate file
>   build/pkg-config: output driver libs first for static build
>   build/pkg-config: improve static linking flags
>   build/pkg-config: prevent overlinking

Applied with changes discussed in the thread, thanks