From patchwork Fri Jun 5 22:57:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 70888 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1EE3AA0350; Sat, 6 Jun 2020 00:58:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 233271D510; Sat, 6 Jun 2020 00:58:24 +0200 (CEST) Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by dpdk.org (Postfix) with ESMTP id 6318E1D447 for ; Sat, 6 Jun 2020 00:58:22 +0200 (CEST) Received: by mail-pl1-f173.google.com with SMTP id v24so4264655plo.6 for ; Fri, 05 Jun 2020 15:58:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=M3i58O5TIWp9X67M1/7l2adGa1nc5hGYJPzYQbyLGE8=; b=yuVhQqhYNlW6K0FiRdoDulvyp9hTbnvyM+Cted+cCgxeBue/+J+tdlhuMuxqzxaaxn e7fe3TSteuHZ1EWm1lWz6NwhyYeXbhRG2rNooV3HhIJe+u2nXRo+JZ4HXQBb0dPZaeoS DCwDD/ZTPu6wbV3dQ1xg/85VXqvj33NYPfaCRxXHVxXkOHnFrhbzWGjcs2BRP42f+S6e eexWc3R0CGmSkxdm0bARy9ma6Z8DEytdqoDwpTwM3/S0j3VDSvlKa4sPRwk+M1SVm35+ Cv3udl9AvnD6oC1GXxxi1yUHzMNuwoJ5tdbhb20gLGPdmMvGcVD7KwGJ+CquBTflasGY dHmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=M3i58O5TIWp9X67M1/7l2adGa1nc5hGYJPzYQbyLGE8=; b=Ap+MBqrZCEXjo+1+/1f7caXKe8joFZzmY3Fe8t9xZzSslFDiqv/icn7AnyTg+I6iq6 ECPcyUy8jr/5/d1d+L8NOWBoEnjAV9AzODJDDBuueVnLkXkozoo5sxVkDmO7BqBZxf3f cuWyZnA6YMp4illJD1awdfvWN5+dOk53cvYM+iisCrrr5esWO/4/2HdmQWjZFvRcg0xN SbUNd961/Vn1mZb0KaSW+Fa2F8IvS32gurxR14UdFqh0Zr4NE2nQkcryVw/vO2ANUq4q O+q4fevfAftdzBudvPTh+8SfE+XMNGlLZ8dAORq9ifEE30DAYnZTgyEqJZ8naHtEQ+XB VFlg== X-Gm-Message-State: AOAM533poWx7+FlE04ASx0NKpPSqiPtIf+OmLx0fMJsOVbWZjeO6JD0b fqMXdwrftwwLHSiZ+7IL6c2k9vkyuUk= X-Google-Smtp-Source: ABdhPJz/kFbNE2Avhd9OyQPrs0yaM3o7HYy/4ekPJu6SgufwR6TgParTivsyOIFK20M6NJsfMatI2w== X-Received: by 2002:a17:90b:110d:: with SMTP id gi13mr5523462pjb.173.1591397900468; Fri, 05 Jun 2020 15:58:20 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id j186sm543121pfb.220.2020.06.05.15.58.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jun 2020 15:58:19 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Fri, 5 Jun 2020 15:57:45 -0700 Message-Id: <20200605225811.26342-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200604210200.25405-1-stephen@networkplumber.org> References: <20200604210200.25405-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [RFC v2 00/26] Change references to master/slave to X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This set of patches changes the API and conventions around referring to DPDK lcores. The first patch changes rte_get_master_lcore_id and related calls. The rest fix the DPDK to use the new naming. The last patch marks the old names as deprecated. My preferred option would be to do the rest of the patches now, and hold the last one until 20.11 Buried in the documentation set are a couple of patches where we were using incorrect naming around primary/secondary process. This will could/should be flagged as an API policy violation since new API is jumping the queue of EXPERIMENTAL. But we can vote on the exception. Stephen Hemminger (26): eal: rename terms used for DPDK lcores kni: fix reference to master/slave process bbdev: rename master to initial lcore librte_power: change reference to rte_master_lcore drivers: replace master/slave terminolgy examples/distrutor: rename master to initial examples/bond: replace references to master lcore examples/ethtool-app: replace references to slave with worker examples/ip_pipeline: replace references to master_lcore examples/qos_{meter/sched}: replace references to master lcore examples/l3fwd: replace references to master lcore examples/l2fwd: replace references to master lcore examples/multi_process: replace references to master lcore examples/performance-thread: replace reference to master lcore examples/ptpclient: replace references to master lcore examples/ipcsec-secgw: replace references to master lcore examples: replace reference to master lcore app/test-pmd: change references to master/slave test-eventdev: replace references to slave with worker lcores app/test: repalce refernces to master/slave doc: fix incorrect reference to master process doc: update references to master/slave lcore in samples doc: replace master lcore terminology app/pdump: replace references to master/slave lcore app/test-XXX: replace reference to master/slave eal: mark old naming as deprecated app/pdump/main.c | 2 +- app/test-acl/main.c | 2 +- app/test-bbdev/test_bbdev_perf.c | 16 +-- app/test-compress-perf/main.c | 8 +- app/test-crypto-perf/main.c | 14 +-- app/test-eventdev/evt_options.c | 2 +- app/test-eventdev/test_order_common.c | 12 +- app/test-eventdev/test_perf_common.c | 16 +-- app/test-eventdev/test_pipeline_common.c | 8 +- app/test-pipeline/main.c | 4 +- app/test-pmd/config.c | 4 +- app/test-pmd/parameters.c | 2 +- app/test-pmd/softnicfwd.c | 2 +- app/test-pmd/testpmd.c | 4 +- app/test-sad/main.c | 4 +- app/test/autotest_test_funcs.py | 2 +- app/test/test.c | 2 +- app/test/test_atomic.c | 26 ++--- app/test/test_barrier.c | 2 +- app/test/test_cryptodev.c | 16 +-- app/test/test_distributor.c | 8 +- app/test/test_distributor_perf.c | 10 +- app/test/test_eal_flags.c | 32 +++--- app/test/test_efd.c | 2 +- app/test/test_efd_perf.c | 2 +- app/test/test_func_reentrancy.c | 20 ++-- app/test/test_hash_multiwriter.c | 4 +- app/test/test_hash_readwrite.c | 38 +++---- app/test/test_kni.c | 16 +-- app/test/test_malloc.c | 12 +- app/test/test_mbuf.c | 36 +++--- app/test/test_mcslock.c | 28 ++--- app/test/test_mempool_perf.c | 10 +- app/test/test_mp_secondary.c | 2 +- app/test/test_pdump.c | 2 +- app/test/test_per_lcore.c | 14 +-- app/test/test_pmd_perf.c | 20 ++-- app/test/test_rcu_qsbr.c | 2 +- app/test/test_rcu_qsbr_perf.c | 2 +- app/test/test_ring_perf.c | 14 +-- app/test/test_ring_stress_impl.h | 10 +- app/test/test_rwlock.c | 28 ++--- app/test/test_service_cores.c | 10 +- app/test/test_spinlock.c | 34 +++--- app/test/test_stack.c | 2 +- app/test/test_stack_perf.c | 6 +- app/test/test_ticketlock.c | 36 +++--- app/test/test_timer.c | 106 +++++++++--------- app/test/test_timer_racecond.c | 27 ++--- app/test/test_timer_secondary.c | 2 +- app/test/test_trace_perf.c | 4 +- doc/guides/howto/debug_troubleshoot.rst | 2 +- doc/guides/linux_gsg/eal_args.include.rst | 4 +- doc/guides/nics/bnxt.rst | 2 +- .../thread_safety_dpdk_functions.rst | 4 +- doc/guides/sample_app_ug/hello_world.rst | 4 +- doc/guides/sample_app_ug/ioat.rst | 2 +- doc/guides/sample_app_ug/l3_forward_graph.rst | 6 +- doc/guides/sample_app_ug/multi_process.rst | 4 +- .../sample_app_ug/performance_thread.rst | 2 +- doc/guides/sample_app_ug/qos_scheduler.rst | 2 +- doc/guides/sample_app_ug/timer.rst | 6 +- drivers/bus/dpaa/dpaa_bus.c | 2 +- drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 6 +- drivers/net/bnxt/bnxt_ring.c | 4 +- drivers/net/qede/base/bcm_osal.c | 4 +- drivers/net/softnic/rte_eth_softnic_thread.c | 4 +- examples/bbdev_app/main.c | 14 +-- examples/bond/main.c | 8 +- examples/distributor/main.c | 10 +- examples/ethtool/ethtool-app/main.c | 10 +- examples/eventdev_pipeline/main.c | 2 +- examples/flow_classify/flow_classify.c | 2 +- examples/helloworld/main.c | 6 +- examples/ioat/ioatfwd.c | 6 +- examples/ip_fragmentation/main.c | 4 +- examples/ip_pipeline/main.c | 2 +- examples/ip_pipeline/thread.c | 16 +-- examples/ip_reassembly/main.c | 4 +- examples/ipsec-secgw/event_helper.c | 6 +- examples/ipsec-secgw/ipsec-secgw.c | 4 +- examples/ipv4_multicast/main.c | 4 +- examples/kni/main.c | 7 +- examples/l2fwd-cat/l2fwd-cat.c | 2 +- examples/l2fwd-crypto/main.c | 8 +- examples/l2fwd-event/l2fwd_event_generic.c | 2 +- .../l2fwd-event/l2fwd_event_internal_port.c | 2 +- examples/l2fwd-event/l2fwd_poll.c | 2 +- examples/l2fwd-event/main.c | 2 +- examples/l2fwd-jobstats/main.c | 4 +- examples/l2fwd-keepalive/main.c | 6 +- examples/l2fwd/main.c | 8 +- examples/l3fwd-acl/main.c | 4 +- examples/l3fwd-graph/main.c | 14 +-- examples/l3fwd-power/main.c | 20 ++-- examples/l3fwd/main.c | 2 +- examples/link_status_interrupt/main.c | 8 +- .../client_server_mp/mp_server/main.c | 10 +- examples/multi_process/simple_mp/main.c | 6 +- examples/multi_process/symmetric_mp/main.c | 2 +- examples/ntb/ntb_fwd.c | 14 +-- examples/packet_ordering/main.c | 22 ++-- .../performance-thread/l3fwd-thread/main.c | 12 +- .../performance-thread/pthread_shim/main.c | 4 +- examples/ptpclient/ptpclient.c | 2 +- examples/qos_meter/main.c | 4 +- examples/qos_sched/args.c | 22 ++-- examples/qos_sched/cmdline.c | 2 +- examples/qos_sched/main.c | 2 +- examples/rxtx_callbacks/main.c | 2 +- examples/server_node_efd/server/main.c | 10 +- examples/skeleton/basicfwd.c | 2 +- examples/tep_termination/main.c | 12 +- examples/timer/main.c | 8 +- examples/vhost/main.c | 10 +- examples/vmdq/main.c | 4 +- examples/vmdq_dcb/main.c | 6 +- lib/librte_eal/common/eal_common_launch.c | 36 +++--- lib/librte_eal/common/eal_common_lcore.c | 11 +- lib/librte_eal/common/eal_common_options.c | 62 +++++----- lib/librte_eal/common/eal_options.h | 4 +- lib/librte_eal/common/eal_private.h | 6 +- lib/librte_eal/common/eal_thread.h | 6 +- lib/librte_eal/common/rte_random.c | 2 +- lib/librte_eal/common/rte_service.c | 2 +- lib/librte_eal/freebsd/eal.c | 24 ++-- lib/librte_eal/freebsd/eal_thread.c | 24 ++-- lib/librte_eal/include/rte_eal.h | 4 +- lib/librte_eal/include/rte_eal_trace.h | 4 +- lib/librte_eal/include/rte_launch.h | 62 +++++----- lib/librte_eal/include/rte_lcore.h | 31 +++-- lib/librte_eal/linux/eal.c | 24 ++-- lib/librte_eal/linux/eal_memory.c | 20 ++-- lib/librte_eal/linux/eal_thread.c | 24 ++-- lib/librte_eal/rte_eal_version.map | 1 + lib/librte_eal/windows/eal.c | 14 +-- lib/librte_eal/windows/eal_thread.c | 22 ++-- lib/librte_kni/rte_kni.h | 2 +- lib/librte_power/rte_power_empty_poll.c | 2 +- 139 files changed, 753 insertions(+), 724 deletions(-)