[0/3] Add interrupt-only mode to l3fwd-power
mbox series

Message ID cover.1590656906.git.anatoly.burakov@intel.com
Headers show
Series
  • Add interrupt-only mode to l3fwd-power
Related show

Message

Burakov, Anatoly May 28, 2020, 9:13 a.m. UTC
Since 20.05, l3fwd-power has become much more stringent about
whether it allows initialization without initializing the
librte_power library with it. This means that while previously
the app could have been used to test RX interrupts functionality
even if the app itself was in a half-working state, it is now
no longer possible to do so.

To address this use case, we're adding an interrupt-only mode
that does not rely on librte_power or telemetry. This enables
using l3fwd-power in environments where librte_power is not
expected to work (such as inside a VM or on non-IA
architectures). The RX/TX path is basically copy paste from
legacy RX/TX path but with librte_power bits taken out.

There seem to be two opposing schools of thought on whether we
should have more or less examples. This patchset goes in the
"less" direction where we add a new mode to an existing app,
rather than creating a new one like it could be argued it
deserves.

Anatoly Burakov (3):
  l3fwd-power: disable interrupts by default
  l3fwd-power: only allow supported power library envs
  l3fwd-power: add interrupt-only mode

 examples/l3fwd-power/main.c | 234 +++++++++++++++++++++++++++++++++---
 1 file changed, 217 insertions(+), 17 deletions(-)

Comments

Yinan Wang June 8, 2020, 1:24 a.m. UTC | #1
Tested-by: Wang, Yinan <yinan.wang@intel.com>

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Anatoly Burakov
> Sent: 2020年5月28日 17:14
> To: dev@dpdk.org
> Cc: Hunt, David <david.hunt@intel.com>; Ma, Liang J <liang.j.ma@intel.com>;
> Pattan, Reshma <reshma.pattan@intel.com>
> Subject: [dpdk-dev] [PATCH 0/3] Add interrupt-only mode to l3fwd-power
> 
> Since 20.05, l3fwd-power has become much more stringent about whether it
> allows initialization without initializing the librte_power library with it. This
> means that while previously the app could have been used to test RX interrupts
> functionality even if the app itself was in a half-working state, it is now no
> longer possible to do so.
> 
> To address this use case, we're adding an interrupt-only mode that does not rely
> on librte_power or telemetry. This enables using l3fwd-power in environments
> where librte_power is not expected to work (such as inside a VM or on non-IA
> architectures). The RX/TX path is basically copy paste from legacy RX/TX path
> but with librte_power bits taken out.
> 
> There seem to be two opposing schools of thought on whether we should have
> more or less examples. This patchset goes in the "less" direction where we add a
> new mode to an existing app, rather than creating a new one like it could be
> argued it deserves.
> 
> Anatoly Burakov (3):
>   l3fwd-power: disable interrupts by default
>   l3fwd-power: only allow supported power library envs
>   l3fwd-power: add interrupt-only mode
> 
>  examples/l3fwd-power/main.c | 234 +++++++++++++++++++++++++++++++++--
> -
>  1 file changed, 217 insertions(+), 17 deletions(-)
> 
> --
> 2.17.1