[20.08,0/9] adding support for python 3 only.
mbox series

Message ID 20200522132320.26373-1-louise.kilheeney@intel.com
Headers show
Series
  • adding support for python 3 only.
Related show

Message

Louise Kilheeney May 22, 2020, 1:23 p.m. UTC
This patch set converts all python scripts in the project to use
python3 only. This is due to python2 being EOL in January 2020.

One script not tested: ./config/arm/armv8_machine.py

Louise Kilheeney (9):
  app/test-bbdev: support python3 only
  usertools/dpdk-devbind: support python3 only
  usertools/dpdk-telemetry-client: support python3 only
  usertools/dpdk-pmdinfo: support python3 only
  usertools/cpu_layout: support python3 only
  app/test-cmdline: support python3 only
  app/test: support python3 only
  devtools: support python3 only
  config/arm: support python3 only

 app/test-bbdev/test-bbdev.py          |  7 +++----
 app/test-cmdline/cmdline_test.py      |  3 +--
 app/test-cmdline/cmdline_test_data.py |  1 +
 app/test/autotest.py                  |  3 +--
 app/test/autotest_data.py             |  1 +
 app/test/autotest_runner.py           | 14 +++++++-------
 app/test/autotest_test_funcs.py       |  1 +
 config/arm/armv8_machine.py           |  2 +-
 devtools/update_version_map_abi.py    |  3 +--
 mk/rte.sdktest.mk                     |  6 +++---
 usertools/cpu_layout.py               |  9 ++-------
 usertools/dpdk-devbind.py             |  3 +--
 usertools/dpdk-pmdinfo.py             |  4 +---
 usertools/dpdk-telemetry-client.py    | 16 ++++------------
 14 files changed, 28 insertions(+), 45 deletions(-)

Comments

Robin Jarry May 25, 2020, 7:27 a.m. UTC | #1
Hi Louise,

2020-05-22, Louise Kilheeney:
> This patch set converts all python scripts in the project to use
> python3 only. This is due to python2 being EOL in January 2020.
> 
> One script not tested: ./config/arm/armv8_machine.py
> 
> Louise Kilheeney (9):
>   app/test-bbdev: support python3 only
>   usertools/dpdk-devbind: support python3 only
>   usertools/dpdk-telemetry-client: support python3 only
>   usertools/dpdk-pmdinfo: support python3 only
>   usertools/cpu_layout: support python3 only
>   app/test-cmdline: support python3 only
>   app/test: support python3 only
>   devtools: support python3 only
>   config/arm: support python3 only

How did you test your changes?

Also, I had understood that python 2 support would not be dropped before
20.11: http://mails.dpdk.org/archives/dev/2020-February/157793.html

Did I miss something?
Bruce Richardson May 25, 2020, 9:51 a.m. UTC | #2
On Mon, May 25, 2020 at 09:27:17AM +0200, Robin Jarry wrote:
> Hi Louise,
> 
> 2020-05-22, Louise Kilheeney:
> > This patch set converts all python scripts in the project to use
> > python3 only. This is due to python2 being EOL in January 2020.
> > 
> > One script not tested: ./config/arm/armv8_machine.py
> > 
> > Louise Kilheeney (9):
> >   app/test-bbdev: support python3 only
> >   usertools/dpdk-devbind: support python3 only
> >   usertools/dpdk-telemetry-client: support python3 only
> >   usertools/dpdk-pmdinfo: support python3 only
> >   usertools/cpu_layout: support python3 only
> >   app/test-cmdline: support python3 only
> >   app/test: support python3 only
> >   devtools: support python3 only
> >   config/arm: support python3 only
> 
> How did you test your changes?
> 
> Also, I had understood that python 2 support would not be dropped before
> 20.11: http://mails.dpdk.org/archives/dev/2020-February/157793.html
> 
> Did I miss something?
> 
The 20.11 was just a suggestion from me, but I'm not sure it was ever
definitively agreed upon. I'd be ok with removing python2 support in either
20.08 or deferring to 20.11. I don't think the patches would be different
no matter what release it being targetted. :-)
Is there a particular concern around removing python2 support? I thought
all linux distros now have python3, and many are stopping installing
python2 by default also.
Robin Jarry May 25, 2020, 10:29 a.m. UTC | #3
2020-05-25, Bruce Richardson:
> The 20.11 was just a suggestion from me, but I'm not sure it was ever
> definitively agreed upon. I'd be ok with removing python2 support in either
> 20.08 or deferring to 20.11. I don't think the patches would be different
> no matter what release it being targetted. :-)
> Is there a particular concern around removing python2 support? I thought
> all linux distros now have python3, and many are stopping installing
> python2 by default also.

Absolutely no concern around getting rid of Python 2 support :-)

Thanks for the clarification.
Louise Kilheeney May 25, 2020, 10:56 a.m. UTC | #4
I tested all scripts by running each of them manually, if you have any input into what tests you thinks would be good to run please do let me know.  

Louise Kilheeney

> -----Original Message-----
> From: Robin Jarry <robin.jarry@6wind.com>
> Sent: Monday 25 May 2020 08:27
> To: Kilheeney, Louise <louise.kilheeney@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 20.08 0/9] adding support for python 3 only.
> 
> Hi Louise,
> 
> 2020-05-22, Louise Kilheeney:
> > This patch set converts all python scripts in the project to use
> > python3 only. This is due to python2 being EOL in January 2020.
> >
> > One script not tested: ./config/arm/armv8_machine.py
> >
> > Louise Kilheeney (9):
> >   app/test-bbdev: support python3 only
> >   usertools/dpdk-devbind: support python3 only
> >   usertools/dpdk-telemetry-client: support python3 only
> >   usertools/dpdk-pmdinfo: support python3 only
> >   usertools/cpu_layout: support python3 only
> >   app/test-cmdline: support python3 only
> >   app/test: support python3 only
> >   devtools: support python3 only
> >   config/arm: support python3 only
> 
> How did you test your changes?
> 
> Also, I had understood that python 2 support would not be dropped before
> 20.11: http://mails.dpdk.org/archives/dev/2020-February/157793.html
> 
> Did I miss something?
> 
> --
> Robin
Robin Jarry May 25, 2020, 11:06 a.m. UTC | #5
2020-05-25, Kilheeney, Louise:
> I tested all scripts by running each of them manually, if you have any
> input into what tests you thinks would be good to run please do let me
> know.

This should be enough to debunk the most obvious problems. Thanks.