[0/5] misc updates for hns3 PMD driver
mbox series

Message ID 1590139278-11046-1-git-send-email-xavier.huwei@huawei.com
Headers show
Series
  • misc updates for hns3 PMD driver
Related show

Message

Wei Hu (Xavier) May 22, 2020, 9:21 a.m. UTC
This series are improvement and bugfixes for hns3 PMD driver.

Chengchang Tang (2):
  net/hns3: replace PF vport id zero with private macro
  net/hns3: fix promiscuous config not clear for PF on uninit

Lijun Ou (2):
  net/hns3: add RSS hash offload to port Rx configuration
  net/hns3: fix key length when configuring RSS

Wei Hu (Xavier) (1):
  net/hns3: fix preparing sending packets less than 60 bytes

 drivers/net/hns3/hns3_ethdev.c    | 102 ++++++++++++++++++++++++--------------
 drivers/net/hns3/hns3_ethdev.h    |   3 ++
 drivers/net/hns3/hns3_ethdev_vf.c |   1 +
 drivers/net/hns3/hns3_flow.c      |   8 +++
 drivers/net/hns3/hns3_rxtx.c      |   6 ---
 5 files changed, 78 insertions(+), 42 deletions(-)

Comments

Ferruh Yigit May 22, 2020, 11:20 a.m. UTC | #1
On 5/22/2020 10:21 AM, Wei Hu (Xavier) wrote:
> This series are improvement and bugfixes for hns3 PMD driver.

Hi Xavier,

We are planning to have the -rc4 this weekend and the release on Tuesday. So we
are literally a few days away from the release.

It is definitely not good idea to change the code this close to the release,
that is why we are saying -rc4 for the critical defects only.

I will postpone this series to the next release, fyi.

> 
> Chengchang Tang (2):
>   net/hns3: replace PF vport id zero with private macro
>   net/hns3: fix promiscuous config not clear for PF on uninit
> 
> Lijun Ou (2):
>   net/hns3: add RSS hash offload to port Rx configuration
>   net/hns3: fix key length when configuring RSS
> 
> Wei Hu (Xavier) (1):
>   net/hns3: fix preparing sending packets less than 60 bytes
> 
>  drivers/net/hns3/hns3_ethdev.c    | 102 ++++++++++++++++++++++++--------------
>  drivers/net/hns3/hns3_ethdev.h    |   3 ++
>  drivers/net/hns3/hns3_ethdev_vf.c |   1 +
>  drivers/net/hns3/hns3_flow.c      |   8 +++
>  drivers/net/hns3/hns3_rxtx.c      |   6 ---
>  5 files changed, 78 insertions(+), 42 deletions(-)
>
Wei Hu (Xavier) May 23, 2020, 1:33 a.m. UTC | #2
On 2020/5/22 19:20, Ferruh Yigit wrote:
> On 5/22/2020 10:21 AM, Wei Hu (Xavier) wrote:
>> This series are improvement and bugfixes for hns3 PMD driver.
> Hi Xavier,
>
> We are planning to have the -rc4 this weekend and the release on Tuesday. So we
> are literally a few days away from the release.
>
> It is definitely not good idea to change the code this close to the release,
> that is why we are saying -rc4 for the critical defects only.
>
> I will postpone this series to the next release, fyi.
Hi, Ferruh Yigit
   I got it.  I will adjust the frequency of sending patches to the 
community in future.
   Thank you.

   Regards
Xavier
>> Chengchang Tang (2):
>>    net/hns3: replace PF vport id zero with private macro
>>    net/hns3: fix promiscuous config not clear for PF on uninit
>>
>> Lijun Ou (2):
>>    net/hns3: add RSS hash offload to port Rx configuration
>>    net/hns3: fix key length when configuring RSS
>>
>> Wei Hu (Xavier) (1):
>>    net/hns3: fix preparing sending packets less than 60 bytes
>>
>>   drivers/net/hns3/hns3_ethdev.c    | 102 ++++++++++++++++++++++++--------------
>>   drivers/net/hns3/hns3_ethdev.h    |   3 ++
>>   drivers/net/hns3/hns3_ethdev_vf.c |   1 +
>>   drivers/net/hns3/hns3_flow.c      |   8 +++
>>   drivers/net/hns3/hns3_rxtx.c      |   6 ---
>>   5 files changed, 78 insertions(+), 42 deletions(-)
>>
>
Ferruh Yigit May 27, 2020, 3:36 p.m. UTC | #3
On 5/22/2020 10:21 AM, Wei Hu (Xavier) wrote:
> This series are improvement and bugfixes for hns3 PMD driver.
> 
> Chengchang Tang (2):
>   net/hns3: replace PF vport id zero with private macro
>   net/hns3: fix promiscuous config not clear for PF on uninit
> 
> Lijun Ou (2):
>   net/hns3: add RSS hash offload to port Rx configuration
>   net/hns3: fix key length when configuring RSS
> 
> Wei Hu (Xavier) (1):
>   net/hns3: fix preparing sending packets less than 60 bytes
> 

Series applied to dpdk-next-net/master, thanks.

A minor modification done [1] to fix 32-bit build error [2].


[1]
diff --git a/drivers/net/hns3/hns3_flow.c b/drivers/net/hns3/hns3_flow.c
index e3c239286a..c7851b235c 100644
--- a/drivers/net/hns3/hns3_flow.c
+++ b/drivers/net/hns3/hns3_flow.c
@@ -1478,7 +1478,7 @@ hns3_config_rss_filter(struct rte_eth_dev *dev,
        if (rss_flow_conf.key_len &&
            rss_flow_conf.key_len > RTE_DIM(rss_info->key)) {
                hns3_err(hw,
-                       "input hash key(%u) greater than supported len(%lu)",
+                       "input hash key(%u) greater than supported len(%zu)",
                        rss_flow_conf.key_len, RTE_DIM(rss_info->key));
                return -EINVAL;
        }



[2]
In file included from .../drivers/net/hns3/hns3_flow.c:12:
.../drivers/net/hns3/hns3_flow.c: In function ‘hns3_config_rss_filter’:
.../drivers/net/hns3/hns3_logs.h:16:38: error: format ‘%lu’ expects argument of
type ‘long unsigned int’, but argument 7 has type ‘unsigned int’ [-Werror=format=]
   16 |  rte_log(level, hns3_logtype_driver, "%s %s(): " fmt, \
      |                                      ^~~~~~~~~~~
.../drivers/net/hns3/hns3_logs.h:20:2: note: in expansion of macro ‘PMD_DRV_LOG_RAW’
   20 |  PMD_DRV_LOG_RAW(hw, RTE_LOG_ERR, fmt "\n", ## args)
      |  ^~~~~~~~~~~~~~~
.../drivers/net/hns3/hns3_flow.c:1480:3: note: in expansion of macro ‘hns3_err’
 1480 |   hns3_err(hw,
      |   ^~~~~~~~
.../drivers/net/hns3/hns3_flow.c:1481:53: note: format string is defined here
 1481 |    "input hash key(%u) greater than supported len(%lu)",
      |                                                   ~~^
      |                                                     |
      |                                                     long unsigned int
      |                                                   %u
cc1: all warnings being treated as errors
Wei Hu (Xavier) May 28, 2020, 1:35 a.m. UTC | #4
Hi, Ferruh Yigit


On 2020/5/27 23:36, Ferruh Yigit wrote:
> On 5/22/2020 10:21 AM, Wei Hu (Xavier) wrote:
>> This series are improvement and bugfixes for hns3 PMD driver.
>>
>> Chengchang Tang (2):
>>    net/hns3: replace PF vport id zero with private macro
>>    net/hns3: fix promiscuous config not clear for PF on uninit
>>
>> Lijun Ou (2):
>>    net/hns3: add RSS hash offload to port Rx configuration
>>    net/hns3: fix key length when configuring RSS
>>
>> Wei Hu (Xavier) (1):
>>    net/hns3: fix preparing sending packets less than 60 bytes
>>
> Series applied to dpdk-next-net/master, thanks.
>
> A minor modification done [1] to fix 32-bit build error [2].
>
>
> [1]
> diff --git a/drivers/net/hns3/hns3_flow.c b/drivers/net/hns3/hns3_flow.c
> index e3c239286a..c7851b235c 100644
> --- a/drivers/net/hns3/hns3_flow.c
> +++ b/drivers/net/hns3/hns3_flow.c
> @@ -1478,7 +1478,7 @@ hns3_config_rss_filter(struct rte_eth_dev *dev,
>          if (rss_flow_conf.key_len &&
>              rss_flow_conf.key_len > RTE_DIM(rss_info->key)) {
>                  hns3_err(hw,
> -                       "input hash key(%u) greater than supported len(%lu)",
> +                       "input hash key(%u) greater than supported len(%zu)",
>                          rss_flow_conf.key_len, RTE_DIM(rss_info->key));
>                  return -EINVAL;
>          }
>
>
>
> [2]
> In file included from .../drivers/net/hns3/hns3_flow.c:12:
> .../drivers/net/hns3/hns3_flow.c: In function ‘hns3_config_rss_filter’:
> .../drivers/net/hns3/hns3_logs.h:16:38: error: format ‘%lu’ expects argument of
> type ‘long unsigned int’, but argument 7 has type ‘unsigned int’ [-Werror=format=]
>     16 |  rte_log(level, hns3_logtype_driver, "%s %s(): " fmt, \
>        |                                      ^~~~~~~~~~~
> .../drivers/net/hns3/hns3_logs.h:20:2: note: in expansion of macro ‘PMD_DRV_LOG_RAW’
>     20 |  PMD_DRV_LOG_RAW(hw, RTE_LOG_ERR, fmt "\n", ## args)
>        |  ^~~~~~~~~~~~~~~
> .../drivers/net/hns3/hns3_flow.c:1480:3: note: in expansion of macro ‘hns3_err’
>   1480 |   hns3_err(hw,
>        |   ^~~~~~~~
> .../drivers/net/hns3/hns3_flow.c:1481:53: note: format string is defined here
>   1481 |    "input hash key(%u) greater than supported len(%lu)",
>        |                                                   ~~^
>        |                                                     |
>        |                                                     long unsigned int
>        |                                                   %u
> cc1: all warnings being treated as errors
>
>
   Thank you very much!
Xavier