From patchwork Fri Apr 17 16:42:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Ga=C3=ABtan_Rivet?= X-Patchwork-Id: 68802 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4D1D2A0597; Fri, 17 Apr 2020 18:42:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9267B1EA6A; Fri, 17 Apr 2020 18:42:19 +0200 (CEST) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by dpdk.org (Postfix) with ESMTP id EF75B1EA1A for ; Fri, 17 Apr 2020 18:42:17 +0200 (CEST) X-Originating-IP: 86.246.31.132 Received: from inocybe.home (lfbn-idf2-1-566-132.w86-246.abo.wanadoo.fr [86.246.31.132]) (Authenticated sender: grive@u256.net) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 6EEAA1BF205 for ; Fri, 17 Apr 2020 16:42:16 +0000 (UTC) From: Gaetan Rivet To: dev@dpdk.org Date: Fri, 17 Apr 2020 18:42:05 +0200 Message-Id: X-Mailer: git-send-email 2.26.0 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v1 0/2] bonding: fix port id check and PCI addr cmp X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Found these two bugs while reading the bonding code. The first bug is mostly usability: if a user gives an incorrect port id as a slave, it will error-out later. The error will simply be less clear. I'm partially responsible for the second one. I don't see why we did not wrote it properly at the time: the comment about lacking the proper rte_bus_pci impl was already not correct anymore when the check on the kdrv was removed. The necessary functions were already available I think. Gaetan Rivet (2): bonding: fix port id validity check on parsing bonding: fix PCI address comparison on non-pci ports drivers/net/bonding/rte_eth_bond_args.c | 63 +++++++++++-------------- 1 file changed, 27 insertions(+), 36 deletions(-)