Message ID | 20200129172621.28565-1-david.marchand@redhat.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A526FA052F; Wed, 29 Jan 2020 18:27:04 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 067E31C036; Wed, 29 Jan 2020 18:26:56 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 61BDD1C024 for <dev@dpdk.org>; Wed, 29 Jan 2020 18:26:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580318813; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xo5SpcVPg683aeZKCp6OYGiI/orE6a/+Yd2gm2iCRSU=; b=Vm+VHxhG/0PKy/+SJDc2BmvIXh5RbBpgnxpWV0wWXlksrI3j5VWD2+j8H9KKboREgaLx6A C8xDaUMgoxsoADeed4DkJtedIhWQpspUW6u/qbNxH1hnc/lncgOdGYp5eD4tFHunCMxoUO xjIk36vPXNn7/kBECtYF9pDQcooV1OU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-237-nOCYOt0uPuagvIgDGSO2WA-1; Wed, 29 Jan 2020 12:26:33 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 181641882CE4; Wed, 29 Jan 2020 17:26:31 +0000 (UTC) Received: from dmarchan.remote.csb (ovpn-204-128.brq.redhat.com [10.40.204.128]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3DBFC84BC9; Wed, 29 Jan 2020 17:26:27 +0000 (UTC) From: David Marchand <david.marchand@redhat.com> To: dev@dpdk.org Cc: thomas@monjalon.net, bruce.richardson@intel.com, kevin.laatz@intel.com, aconole@redhat.com, nhorman@tuxdriver.com, akhil.goyal@nxp.com, anoobj@marvell.com Date: Wed, 29 Jan 2020 18:26:17 +0100 Message-Id: <20200129172621.28565-1-david.marchand@redhat.com> In-Reply-To: <20191220152058.10739-1-david.marchand@redhat.com> References: <20191220152058.10739-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: nOCYOt0uPuagvIgDGSO2WA-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-dev] [PATCH v2 0/4] add ABI checks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series | add ABI checks | |
Message
David Marchand
Jan. 29, 2020, 5:26 p.m. UTC
Here is the current state of the ABI checks. libabigail has some issues when mixing dump and so files compiled with clang [1], so for now, all checks are done on dumps only. libabigail 1.0-rc3 in Xenial reported issues that disappear with the version 1.2 in Bionic. To avoid getting warnings on internal types like [2], the checks now make use of the public headers part of a dpdk installation (patch 2 and 3 to prepare for this). Some internal rte_hash headers were installed by meson, so patch 1 fixes this. The most important point, abidiff complains on the rc1 cryptodev changes: - Chacha20-Poly1305 AEAD support, - ECPM and ECDSA support A suppression rule has been put on the internal type rte_cryptodev_ops. But other changes are an ABI breakage afaiu. I put suppression rules on them so that we can run the checks, but some action must be taken for 20.02 if my analysis is confirmed. Special thanks to Dodji the libabigail maintainer for helping on this topic. 1: https://sourceware.org/bugzilla/show_bug.cgi?id=25409 2: http://inbox.dpdk.org/dev/CAJFAV8yFKoDZROX9Mkyp7pDMvXw3e7mHwxjfrcjD5ZoFB2tZ8w@mail.gmail.com/
Comments
On Wed, 2020-01-29 at 18:26 +0100, David Marchand wrote: > Here is the current state of the ABI checks. > > libabigail has some issues when mixing dump and so files compiled > with > clang [1], so for now, all checks are done on dumps only. > libabigail 1.0-rc3 in Xenial reported issues that disappear with the > version 1.2 in Bionic. > > To avoid getting warnings on internal types like [2], the checks now > make > use of the public headers part of a dpdk installation (patch 2 and 3 > to > prepare for this). > > Some internal rte_hash headers were installed by meson, so patch 1 > fixes > this. > > The most important point, abidiff complains on the rc1 cryptodev > changes: > - Chacha20-Poly1305 AEAD support, > - ECPM and ECDSA support > > A suppression rule has been put on the internal type > rte_cryptodev_ops. > But other changes are an ABI breakage afaiu. I put suppression rules > on > them so that we can run the checks, but some action must be taken for > 20.02 if my analysis is confirmed. > > Special thanks to Dodji the libabigail maintainer for helping on this > topic. > > 1: > https://sourceware.org/bugzilla/show_bug.cgi?id=25409 > > 2: > http://inbox.dpdk.org/dev/CAJFAV8yFKoDZROX9Mkyp7pDMvXw3e7mHwxjfrcjD5ZoFB2tZ8w@mail.gmail.com/ > > > -- > David Marchand > > David Marchand (4): > hash: fix meson headers packaging > build: split build helper > build: test meson installation > add ABI checks > > .ci/linux-build.sh | 29 ++++++++- > .travis.yml | 20 +++++- > MAINTAINERS | 2 + > devtools/check-abi.sh | 59 +++++++++++++++++ > devtools/dpdk.abignore | 20 ++++++ > devtools/gen-abi.sh | 26 ++++++++ > devtools/test-build.sh | 45 ++++++++++++- > devtools/test-meson-builds.sh | 98 ++++++++++++++++++++++----- > -- > devtools/test-null.sh | 1 + > doc/guides/contributing/patches.rst | 13 ++++ > lib/librte_hash/meson.build | 5 +- > 11 files changed, 286 insertions(+), 32 deletions(-) > create mode 100755 devtools/check-abi.sh > create mode 100644 devtools/dpdk.abignore > create mode 100755 devtools/gen-abi.sh > Series-acked-by: Luca Boccassi <bluca@debian.org>