[v2,0/5] net/mlx: assert cleanup in mlx drivers
mbox series

Message ID 1579803629-152938-1-git-send-email-akozyrev@mellanox.com
Headers show
Series
  • net/mlx: assert cleanup in mlx drivers
Related show

Message

Alexander Kozyrev Jan. 23, 2020, 6:20 p.m. UTC
The Mellanox PMD uses the NDEBUG definition to control built-in debug
features including the asserting one. The DPDK uses a bit different
approach and provides RTE_ASSERT macro and appropriate global
configuration option: CONFIG_RTE_ENABLE_ASSERT.
The patch set introduces the MLX_ASSERT macros that allows to follow
the DPDK approach in a unified fashion and, at the same time,
provides the opportunity to turn on Mellanox PMD assert feature with
dedicated local configuration options: CONFIG_RTE_LIBRTE_MLX_DEBUG.
Note that the direct configuration MLX_DEBUG is clearer than
double negation "ifndef NDEBUG" used before.
This patch set triggers another false positive warning with ICC.
To spare future development efforts we disable the treatments of
compilation warnings as errors in ICC config. GCC stays as a guard.

Signed-off-by: Alexander Kozyrev <akozyrev@mellanox.com>
---
v1: http://patches.dpdk.org/cover/65082/
v2: Corrects typos and make commit messages more accurate.
Fixes broken compilation due to an undefined function in debug mode.

Alexander Kozyrev (5):
  mk/icc: disable treatment of warnings as errors
  net/mlx4: use mlx4 debug flag instead of NDEBUG
  net/mlx4: introduce the mlx4 version of the assert
  net/mlx5: use mlx5 debug flag instead of NDEBUG
  net/mlx5: introduce the mlx5 version of the assert

 drivers/net/mlx4/Makefile                |   4 +-
 drivers/net/mlx4/meson.build             |   4 +-
 drivers/net/mlx4/mlx4.c                  |  29 ++--
 drivers/net/mlx4/mlx4_ethdev.c           |   5 +-
 drivers/net/mlx4/mlx4_flow.c             |  34 ++--
 drivers/net/mlx4/mlx4_intr.c             |   3 +-
 drivers/net/mlx4/mlx4_mp.c               |  25 ++-
 drivers/net/mlx4/mlx4_mr.c               |  74 ++++----
 drivers/net/mlx4/mlx4_rxq.c              |  53 +++---
 drivers/net/mlx4/mlx4_rxtx.c             |  29 ++--
 drivers/net/mlx4/mlx4_txq.c              |  17 +-
 drivers/net/mlx4/mlx4_utils.c            |   3 +-
 drivers/net/mlx4/mlx4_utils.h            |  15 +-
 drivers/net/mlx5/Makefile                |   4 +-
 drivers/net/mlx5/meson.build             |   4 +-
 drivers/net/mlx5/mlx5.c                  |  83 +++++----
 drivers/net/mlx5/mlx5_devx_cmds.c        |   4 +-
 drivers/net/mlx5/mlx5_ethdev.c           |  69 ++++----
 drivers/net/mlx5/mlx5_flow.c             |  69 ++++----
 drivers/net/mlx5/mlx5_flow_dv.c          |  97 ++++++-----
 drivers/net/mlx5/mlx5_flow_meter.c       |  12 +-
 drivers/net/mlx5/mlx5_flow_verbs.c       |   4 +-
 drivers/net/mlx5/mlx5_mac.c              |   5 +-
 drivers/net/mlx5/mlx5_mp.c               |  29 ++--
 drivers/net/mlx5/mlx5_mr.c               |  71 ++++----
 drivers/net/mlx5/mlx5_nl.c               |  26 +--
 drivers/net/mlx5/mlx5_prm.h              |   3 +-
 drivers/net/mlx5/mlx5_rss.c              |   3 +-
 drivers/net/mlx5/mlx5_rxq.c              |  41 +++--
 drivers/net/mlx5/mlx5_rxtx.c             | 289 ++++++++++++++++---------------
 drivers/net/mlx5/mlx5_rxtx.h             |   6 +-
 drivers/net/mlx5/mlx5_rxtx_vec.c         |   1 -
 drivers/net/mlx5/mlx5_rxtx_vec.h         |   7 +-
 drivers/net/mlx5/mlx5_rxtx_vec_altivec.h |  11 +-
 drivers/net/mlx5/mlx5_rxtx_vec_neon.h    |  11 +-
 drivers/net/mlx5/mlx5_rxtx_vec_sse.h     |  11 +-
 drivers/net/mlx5/mlx5_socket.c           |   4 +-
 drivers/net/mlx5/mlx5_stats.c            |   2 +-
 drivers/net/mlx5/mlx5_txq.c              |  59 ++++---
 drivers/net/mlx5/mlx5_utils.c            |   8 +-
 drivers/net/mlx5/mlx5_utils.h            |  36 ++--
 drivers/net/mlx5/mlx5_vlan.c             |   7 +-
 mk/toolchain/icc/rte.vars.mk             |   4 -
 43 files changed, 632 insertions(+), 643 deletions(-)