From patchwork Fri Jan 17 14:46:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Dybkowski, AdamX" X-Patchwork-Id: 64844 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9B613A051A; Fri, 17 Jan 2020 15:46:56 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CAB7A1AFF; Fri, 17 Jan 2020 15:46:55 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 9482C235 for ; Fri, 17 Jan 2020 15:46:54 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jan 2020 06:46:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,330,1574150400"; d="scan'208";a="306252901" Received: from adamdybx-mobl.ger.corp.intel.com (HELO addy-VirtualBox.imu.intel.com) ([10.103.102.201]) by orsmga001.jf.intel.com with ESMTP; 17 Jan 2020 06:46:52 -0800 From: Adam Dybkowski To: dev@dpdk.org, fiona.trahe@intel.com, akhil.goyal@nxp.com Cc: Adam Dybkowski Date: Fri, 17 Jan 2020 15:46:48 +0100 Message-Id: <20200117144651.26804-1-adamx.dybkowski@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200116124232.22282-1-adamx.dybkowski@intel.com> References: <20200116124232.22282-1-adamx.dybkowski@intel.com> Subject: [dpdk-dev] [PATCH v6 0/3] Refactor crypto unit tests. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch set is a first step to refactor the overly complex symmetric crypto unit tests. It merges many separate arrays of the tests for these PMDs: null, aesni_mb, aesni_gcm, openssl, qat, sw_snow3g, sw_kasumi, sw_zuc into one big array that's then used when running unit tests on these PMDs. Individual test functions check the capabilities and execute the rest of the test or skip (return -ENOTSUP) based on the particular test requirements - e.g. test if PMD supports ZUC algo or even a particular key length in few cases. Few edge cases required to check the PMD itself (e.g. run on QAT only, or skip on AES NI / AES GCM). It's the first step of bigger refactoring. Maintainers of other PMDs are encouraged to add their PMD unit tests also into this big central array and remove individual test macro arrays. This patch doesn't address next refactoring steps to be done in the future: geting rid of many small (usually 1-2 line) test functions, created separately for every test case; and simplifying many bigger functions that currently do similar things but work on different test vector structures. A simple script to check if symmetric crypto unit tests work properly on multiple PMDs at once, update the PMDs list to your needs: for PMD in null aesni_mb aesni_gcm openssl qat scheduler sw_snow3g sw_kasumi sw_zuc do echo +++++ $PMD +++++ echo cryptodev_${PMD}_autotest | build/app/test -c7 -n1 --log-level=7 | grep ' Tests [Failed|Passed]' done --- v2: * Update the cover letter, regenerate the patch file. v3: * Break very large commit into four smaller commits, easier to review. * Show in the cover letter how to run unit tests on multiple PMDs at once. v4: * Rebase. v5: * Fix a test failing on SW ZUC PMD. v6: * Rebase again, squash first two commits to allow building individual patches. Adam Dybkowski (3): test/crypto: refactor unit tests test/crypto: add capability checks test/crypto: refactor unit tests into one combined array app/test/test_cryptodev.c | 15975 +++++++++---------- app/test/test_cryptodev_blockcipher.c | 2 +- app/test/test_cryptodev_des_test_vectors.h | 6 +- 3 files changed, 7335 insertions(+), 8648 deletions(-)