Message ID | 1578567380-26994-1-git-send-email-viacheslavo@mellanox.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 12F75A046B; Thu, 9 Jan 2020 11:56:31 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 55E3A1DC37; Thu, 9 Jan 2020 11:56:30 +0100 (CET) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 460B92B98 for <dev@dpdk.org>; Thu, 9 Jan 2020 11:56:28 +0100 (CET) Received: from Internal Mail-Server by MTLPINE1 (envelope-from viacheslavo@mellanox.com) with ESMTPS (AES256-SHA encrypted); 9 Jan 2020 12:56:25 +0200 Received: from pegasus11.mtr.labs.mlnx (pegasus11.mtr.labs.mlnx [10.210.16.104]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 009AuPTq032290; Thu, 9 Jan 2020 12:56:25 +0200 Received: from pegasus11.mtr.labs.mlnx (localhost [127.0.0.1]) by pegasus11.mtr.labs.mlnx (8.14.7/8.14.7) with ESMTP id 009AuPgZ027544; Thu, 9 Jan 2020 10:56:25 GMT Received: (from viacheslavo@localhost) by pegasus11.mtr.labs.mlnx (8.14.7/8.14.7/Submit) id 009AuORD027543; Thu, 9 Jan 2020 10:56:24 GMT X-Authentication-Warning: pegasus11.mtr.labs.mlnx: viacheslavo set sender to viacheslavo@mellanox.com using -f From: Viacheslav Ovsiienko <viacheslavo@mellanox.com> To: dev@dpdk.org Cc: matan@mellanox.com, rasland@mellanox.com, orika@mellanox.com Date: Thu, 9 Jan 2020 10:56:16 +0000 Message-Id: <1578567380-26994-1-git-send-email-viacheslavo@mellanox.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1578500161-20156-1-git-send-email-viacheslavo@mellanox.com> References: <1578500161-20156-1-git-send-email-viacheslavo@mellanox.com> Subject: [dpdk-dev] [PATCH v2 0/4] net/mlx5: remove Tx descriptor reserved field usage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
net/mlx5: remove Tx descriptor reserved field usage
|
|
Message
Slava Ovsiienko
Jan. 9, 2020, 10:56 a.m. UTC
The current Tx datapath implementation in mlx5 PMD uses the
16-bit reserved field within transmit descriptor to store
the indices of the elts array keeping the mbuf pointers to be
freed on transmit completion. On completion PMD fetches the
descriptor index, then fetches the elts array index from
reserved field and frees the mbufs.
The new ConnectX-6DX NIC might use this reserved descriptor
field and existing implementation might not work in intended way.
To resolve this issue the dedicated buffer is introduced to
store indices to instead of descriptor field.
Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
Viacheslav Ovsiienko (4):
net/mlx5: move Tx complete request routine
net/mlx5: update Tx error handling routine
net/mlx5: add free on completion queue
net/mlx5: engage free on completion queue
drivers/net/mlx5/mlx5_rxtx.c | 153 ++++++++++++++++++++-----------------------
drivers/net/mlx5/mlx5_rxtx.h | 13 ++--
drivers/net/mlx5/mlx5_txq.c | 19 +++++-
3 files changed, 94 insertions(+), 91 deletions(-)
--
v1: http://patches.dpdk.org/cover/64293/
v2: resolve minor compilation per patch issues
1.8.3.1
Comments
Hi, Series applied on next-net-mlx, Kindest regards, Raslan Darawsheh > -----Original Message----- > From: Viacheslav Ovsiienko <viacheslavo@mellanox.com> > Sent: Thursday, January 9, 2020 12:56 PM > To: dev@dpdk.org > Cc: Matan Azrad <matan@mellanox.com>; Raslan Darawsheh > <rasland@mellanox.com>; Ori Kam <orika@mellanox.com> > Subject: [PATCH v2 0/4] net/mlx5: remove Tx descriptor reserved field usage > > The current Tx datapath implementation in mlx5 PMD uses the 16-bit > reserved field within transmit descriptor to store the indices of the elts array > keeping the mbuf pointers to be freed on transmit completion. On > completion PMD fetches the descriptor index, then fetches the elts array > index from reserved field and frees the mbufs. > > The new ConnectX-6DX NIC might use this reserved descriptor field and > existing implementation might not work in intended way. > To resolve this issue the dedicated buffer is introduced to store indices to > instead of descriptor field. > > Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com> > > Viacheslav Ovsiienko (4): > net/mlx5: move Tx complete request routine > net/mlx5: update Tx error handling routine > net/mlx5: add free on completion queue > net/mlx5: engage free on completion queue > > drivers/net/mlx5/mlx5_rxtx.c | 153 ++++++++++++++++++++----------------- > ------ > drivers/net/mlx5/mlx5_rxtx.h | 13 ++-- drivers/net/mlx5/mlx5_txq.c | 19 > +++++- > 3 files changed, 94 insertions(+), 91 deletions(-) > > -- > v1: > https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatch > es.dpdk.org%2Fcover%2F64293%2F&data=02%7C01%7Crasland%40mell > anox.com%7C56986b5d3d3c46f2725b08d794f297e6%7Ca652971c7d2e4d9ba6 > a4d149256f461b%7C0%7C0%7C637141641963098885&sdata=RP4VgjCQlp > oJc5J38aajK9Rr8twtJ4d%2FSVP2JxM5C98%3D&reserved=0 > v2: resolve minor compilation per patch issues > > 1.8.3.1
Hi, This series will be removed from next-net-mlx, will apply V3 instead. Kindest regards, Raslan Darawsheh > -----Original Message----- > From: Viacheslav Ovsiienko <viacheslavo@mellanox.com> > Sent: Thursday, January 9, 2020 12:56 PM > To: dev@dpdk.org > Cc: Matan Azrad <matan@mellanox.com>; Raslan Darawsheh > <rasland@mellanox.com>; Ori Kam <orika@mellanox.com> > Subject: [PATCH v2 0/4] net/mlx5: remove Tx descriptor reserved field usage > > The current Tx datapath implementation in mlx5 PMD uses the 16-bit > reserved field within transmit descriptor to store the indices of the elts array > keeping the mbuf pointers to be freed on transmit completion. On > completion PMD fetches the descriptor index, then fetches the elts array > index from reserved field and frees the mbufs. > > The new ConnectX-6DX NIC might use this reserved descriptor field and > existing implementation might not work in intended way. > To resolve this issue the dedicated buffer is introduced to store indices to > instead of descriptor field. > > Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com> > > Viacheslav Ovsiienko (4): > net/mlx5: move Tx complete request routine > net/mlx5: update Tx error handling routine > net/mlx5: add free on completion queue > net/mlx5: engage free on completion queue > > drivers/net/mlx5/mlx5_rxtx.c | 153 ++++++++++++++++++++----------------- > ------ > drivers/net/mlx5/mlx5_rxtx.h | 13 ++-- drivers/net/mlx5/mlx5_txq.c | 19 > +++++- > 3 files changed, 94 insertions(+), 91 deletions(-) > > -- > v1: > https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatch > es.dpdk.org%2Fcover%2F64293%2F&data=02%7C01%7Crasland%40mell > anox.com%7C56986b5d3d3c46f2725b08d794f297e6%7Ca652971c7d2e4d9ba6 > a4d149256f461b%7C0%7C0%7C637141641963098885&sdata=RP4VgjCQlp > oJc5J38aajK9Rr8twtJ4d%2FSVP2JxM5C98%3D&reserved=0 > v2: resolve minor compilation per patch issues > > 1.8.3.1