From patchwork Thu Dec 12 14:09:41 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Dybkowski, AdamX" X-Patchwork-Id: 63791 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6CB44A04F5; Thu, 12 Dec 2019 15:10:19 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0FD5D1BE8A; Thu, 12 Dec 2019 15:10:19 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 9E1582BD3 for ; Thu, 12 Dec 2019 15:10:16 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Dec 2019 06:10:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,306,1571727600"; d="scan'208";a="225937261" Received: from adamdybx-mobl.ger.corp.intel.com (HELO localhost.localdomain) ([10.104.12.174]) by orsmga002.jf.intel.com with ESMTP; 12 Dec 2019 06:10:11 -0800 From: Adam Dybkowski To: dev@dpdk.org, fiona.trahe@intel.com, akhil.goyal@nxp.com Cc: ravi1.kumar@amd.com, ruifeng.wang@arm.com, anoobj@marvell.com, roy.fan.zhang@intel.com, declan.doherty@intel.com, pablo.de.lara.guarch@intel.com, tdu@semihalf.com, rnagadheeraj@marvell.com, adwivedi@marvell.com, g.singh@nxp.com, jianjay.zhou@huawei.com, Adam Dybkowski Date: Thu, 12 Dec 2019 15:09:41 +0100 Message-Id: <20191212140942.8210-1-adamx.dybkowski@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191211161015.9845-2-adamx.dybkowski@intel.com> References: <20191211161015.9845-2-adamx.dybkowski@intel.com> Subject: [dpdk-dev] [PATCH v2 0/1] Refactor crypto unit tests. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch is a first step to refactor the overly complex symmetric crypto unit tests. It merges many separate arrays of the tests for these PMDs: null, aesni_mb, aesni_gcm, openssl, qat, sw_snow3g, sw_kasumi, sw_zuc into one big array that's then used when running unit tests on these PMDs. Individual test functions check the capabilities and execute the rest of the test or skip (return -ENOTSUP) based on the particular test requirements - e.g. test if PMD supports ZUC algo or even a particular key length in few cases. Few edge cases required to check the PMD itself (e.g. run on QAT only, or skip on AES NI / AES GCM). It's the first step of bigger refactoring. Maintainers of other PMDs are encouraged to add their PMD unit tests also into this big central array and remove individual test macro arrays. This patch doesn't address next refactoring steps to be done in the future: geting rid of many small (usually 1-2 line) test functions, created separately for every test case; and simplifying many bigger functions that currently do similar things but work on different test vector structures. This patch depends on the series http://patches.dpdk.org/project/dpdk/list/?series=7792 that must be applied first. --- v2: * Update the cover letter, regenerate the patch file. Adam Dybkowski (1): test/crypto: refactor unit tests into one combined array app/test/test_cryptodev.c | 16113 +++++++++---------- app/test/test_cryptodev_blockcipher.c | 2 +- app/test/test_cryptodev_des_test_vectors.h | 6 +- 3 files changed, 7430 insertions(+), 8691 deletions(-)