Message ID | 20191008211220.31586-1-honnappa.nagarahalli@arm.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 39E381C0DB; Tue, 8 Oct 2019 23:12:36 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by dpdk.org (Postfix) with ESMTP id 99A221C0D2; Tue, 8 Oct 2019 23:12:34 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E4B9728; Tue, 8 Oct 2019 14:12:33 -0700 (PDT) Received: from qc2400f-1.austin.arm.com (qc2400f-1.austin.arm.com [10.118.12.34]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DC9A53F68E; Tue, 8 Oct 2019 14:12:33 -0700 (PDT) From: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com> To: honnappa.nagarahalli@arm.com, david.marchand@redhat.com, konstantin.ananyev@intel.com Cc: dev@dpdk.org, ruifeng.wang@arm.com, stable@dpdk.org, nd@arm.com Date: Tue, 8 Oct 2019 16:12:13 -0500 Message-Id: <20191008211220.31586-1-honnappa.nagarahalli@arm.com> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH 0/7] typo, doc, simple fixes and some optimizations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
typo, doc, simple fixes and some optimizations
|
|
Message
Honnappa Nagarahalli
Oct. 8, 2019, 9:12 p.m. UTC
Few typo fixes, some corrections to the documentation and simple fixes to the test cases. The last 2 commits contain simple optimizations with good amount of performance improvements. v2: All instances of size_t fixed (Ruifeng) Honnappa Nagarahalli (7): doc/rcu: fix typos doc/rcu: correct the limitation on number of threads doc/rcu: add information about storing token and resource test/rcu: use size_t instead of int test/rcu: use correct nomenclature while printing results lib/rcu: add least acknowledged token optimization lib/rcu: update QS only when there are updates from writer app/test/test_rcu_qsbr.c | 4 +-- app/test/test_rcu_qsbr_perf.c | 27 ++++++++++------- doc/guides/prog_guide/rcu_lib.rst | 36 ++++++++++++---------- lib/librte_rcu/rte_rcu_qsbr.c | 4 +++ lib/librte_rcu/rte_rcu_qsbr.h | 50 +++++++++++++++++++++++++++++-- 5 files changed, 89 insertions(+), 32 deletions(-)
Comments
On Tue, Oct 8, 2019 at 11:12 PM Honnappa Nagarahalli <honnappa.nagarahalli@arm.com> wrote: > > Few typo fixes, some corrections to the documentation and simple fixes to > the test cases. > > The last 2 commits contain simple optimizations with good amount of > performance improvements. Do you have numbers to illustrate? > > v2: > All instances of size_t fixed (Ruifeng) > > Honnappa Nagarahalli (7): > doc/rcu: fix typos > doc/rcu: correct the limitation on number of threads > doc/rcu: add information about storing token and resource > test/rcu: use size_t instead of int > test/rcu: use correct nomenclature while printing results > lib/rcu: add least acknowledged token optimization > lib/rcu: update QS only when there are updates from writer Series applied, thanks. -- David Marchand
<snip> > > On Tue, Oct 8, 2019 at 11:12 PM Honnappa Nagarahalli > <honnappa.nagarahalli@arm.com> wrote: > > > > Few typo fixes, some corrections to the documentation and simple fixes > > to the test cases. > > > > The last 2 commits contain simple optimizations with good amount of > > performance improvements. > > Do you have numbers to illustrate? Thanks David. I do not have the numbers for 'least acknowledged token' optimization. The performance test case to test that requires a different design in the performance test cases with additional code. This additional code is nothing but the rte_rcu_qsbr_defer_xxx APIs I am working on. I will be able to publish the numbers with and without this optimization. I have the performance numbers for the last patch. Without the patch: =============== Total RCU updates = 11205362514 Cycles per 1000 updates: 587 Total RCU checks = 20000000 Cycles per 1000 checks: 29946 Perf Test: 12 Readers Total RCU updates = 1200000000 Cycles per 1000 updates: 425 Perf test: 12 Writers ('wait' in qsbr_check == false) Total RCU checks = 240000000 Cycles per 1000 checks: 319 <<<<<<<<<============== (see the improvement below) Perf test: 1 writer, 12 readers, 1 QSBR variable, 1 QSBR Query, Blocking QSBR Check Following numbers include calls to rte_hash functions Cycles per 1 update(online/update/offline): 5857 Cycles per 1 check(start, check): 5889 Perf test: 1 writer, 12 readers, 1 QSBR variable, 1 QSBR Query, Non-Blocking QSBR check Following numbers include calls to rte_hash functions Cycles per 1 update(online/update/offline): 5859 Cycles per 1 check(start, check): 5891 With patch: ========== Total RCU updates = 11075332503 Cycles per 1000 updates: 601 Total RCU checks = 20000000 Cycles per 1000 checks: 30265 Perf Test: 12 Readers Total RCU updates = 1200000000 Cycles per 1000 updates: 425 Perf test: 12 Writers ('wait' in qsbr_check == false) Total RCU checks = 240000000 Cycles per 1000 checks: 79 <<<<================== (Improvement) Perf test: 1 writer, 12 readers, 1 QSBR variable, 1 QSBR Query, Blocking QSBR Check Following numbers include calls to rte_hash functions Cycles per 1 update(online/update/offline): 5847 Cycles per 1 check(start, check): 5897 Perf test: 1 writer, 12 readers, 1 QSBR variable, 1 QSBR Query, Non-Blocking QSBR check Following numbers include calls to rte_hash functions Cycles per 1 update(online/update/offline): 5851 Cycles per 1 check(start, check): 5894 > > > > > v2: > > All instances of size_t fixed (Ruifeng) > > > > Honnappa Nagarahalli (7): > > doc/rcu: fix typos > > doc/rcu: correct the limitation on number of threads > > doc/rcu: add information about storing token and resource > > test/rcu: use size_t instead of int > > test/rcu: use correct nomenclature while printing results > > lib/rcu: add least acknowledged token optimization > > lib/rcu: update QS only when there are updates from writer > > Series applied, thanks. > > > -- > David Marchand