[v2,0/4] synchronise meson warnings with make
mbox series

Message ID 20191007143013.16252-1-bruce.richardson@intel.com
Headers show
Series
  • synchronise meson warnings with make
Related show

Message

Bruce Richardson Oct. 7, 2019, 2:30 p.m. UTC
The warnings used when building DPDK with make were stricter than those
used with meson, so this patchset aligns the two as far as is possible,
while also adding in -Wextra as a general compile flag.

The one difference is that with "make" we allow different flags for GCC
and clang, while with meson we are (for now) keeping them common.
Therefore we drop the -Wcast-align flag as is generates too many
false positive warnings on clang, and we globally use the
Wno-missing-field-initializers flag for the same reason.

v2: fix path to ifpga driver in patch 2, since it has moved in the repo

Bruce Richardson (4):
  build: allow compile with stricter fallthrough warnings
  raw/ifpga: remove unneeded compiler flags
  build: enable extra warnings for meson build
  drivers: remove duplicated compiler flags

 config/meson.build                     | 24 +++++++++++++++++++++---
 drivers/bus/dpaa/meson.build           |  3 +++
 drivers/event/dsw/meson.build          |  3 +++
 drivers/net/bonding/rte_eth_bond_pmd.c |  3 ++-
 drivers/net/dpaa/meson.build           |  4 ++++
 drivers/net/fm10k/base/meson.build     |  3 ++-
 drivers/net/i40e/base/meson.build      |  3 ++-
 drivers/net/mlx4/meson.build           |  1 -
 drivers/net/mlx5/meson.build           |  1 -
 drivers/net/sfc/meson.build            |  2 --
 drivers/net/vdev_netvsc/meson.build    |  2 --
 drivers/raw/ifpga/base/meson.build     | 11 -----------
 lib/librte_cmdline/cmdline_parse_num.c |  2 +-
 13 files changed, 38 insertions(+), 24 deletions(-)

Comments

Thomas Monjalon Oct. 23, 2019, 9:53 p.m. UTC | #1
07/10/2019 16:30, Bruce Richardson:
> The warnings used when building DPDK with make were stricter than those
> used with meson, so this patchset aligns the two as far as is possible,
> while also adding in -Wextra as a general compile flag.
> 
> The one difference is that with "make" we allow different flags for GCC
> and clang, while with meson we are (for now) keeping them common.
> Therefore we drop the -Wcast-align flag as is generates too many
> false positive warnings on clang, and we globally use the
> Wno-missing-field-initializers flag for the same reason.
> 
> v2: fix path to ifpga driver in patch 2, since it has moved in the repo
> 
> Bruce Richardson (4):
>   build: allow compile with stricter fallthrough warnings
>   raw/ifpga: remove unneeded compiler flags
>   build: enable extra warnings for meson build
>   drivers: remove duplicated compiler flags

Applied, thanks