mbox series

[v2,0/5] fix dereference after null check coverity

Message ID 1565047254-66826-1-git-send-email-xiao.zhang@intel.com (mailing list archive)
Headers
Series fix dereference after null check coverity |

Message

Xiao Zhang Aug. 5, 2019, 11:20 p.m. UTC 
  This patch tries to fix (dereference after null check) coverity issue.
The address of first segmented packets for ice, iavf, i40e fm10k and ixgbe
was not set correctly during reassembling packets which led to this issue.

Coverity issue: 343452
Coverity issue: 343407
Fixes: c68a52b8 ("net/ice: support vector SSE in Rx")
Coverity issue: 343447
Fixes: 319c421f ("net/avf: enable SSE Rx Tx")
Coverity issue: 343422 Coverity issue: 343403
Fixes: ca74903b ("net/i40e: extract non-x86 specific code from vector driver")
Coverity issue: 343416
Fixes: fe65e1e1 ("fm10k: add vector scatter Rx")
Coverity issue: 13245
Fixes: 8a44c15a ("net/ixgbe: extract non-x86 specific code from vector driver")
Cc: stable@dpdk.org

v2 Add cover letter and move the fix after invalidation check

Xiao Zhang (5):
  net/ixgbe: fix dereference after null check coverity
  net/ice: fix dereference after null check coverity
  net/i40e: fix dereference after null check coverity
  net/iavf: fix dereference after null check coverity
  net/fm10k: fix dereference after null check coverity

 drivers/net/fm10k/fm10k_rxtx_vec.c     | 1 +
 drivers/net/i40e/i40e_rxtx_vec_avx2.c  | 1 +
 drivers/net/i40e/i40e_rxtx_vec_sse.c   | 1 +
 drivers/net/iavf/iavf_rxtx_vec_sse.c   | 1 +
 drivers/net/ice/ice_rxtx_vec_avx2.c    | 1 +
 drivers/net/ice/ice_rxtx_vec_sse.c     | 1 +
 drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c | 1 +
 7 files changed, 7 insertions(+)

Comments

Xiaolong Ye Aug. 5, 2019, 3:46 p.m. UTC | #1 
On 08/06, Xiao Zhang wrote:
>This patch tries to fix (dereference after null check) coverity issue.
>The address of first segmented packets for ice, iavf, i40e fm10k and ixgbe
>was not set correctly during reassembling packets which led to this issue.
>
>Coverity issue: 343452
>Coverity issue: 343407
>Fixes: c68a52b8 ("net/ice: support vector SSE in Rx")
>Coverity issue: 343447
>Fixes: 319c421f ("net/avf: enable SSE Rx Tx")
>Coverity issue: 343422 Coverity issue: 343403
>Fixes: ca74903b ("net/i40e: extract non-x86 specific code from vector driver")
>Coverity issue: 343416
>Fixes: fe65e1e1 ("fm10k: add vector scatter Rx")
>Coverity issue: 13245
>Fixes: 8a44c15a ("net/ixgbe: extract non-x86 specific code from vector driver")
>Cc: stable@dpdk.org
>
>v2 Add cover letter and move the fix after invalidation check
>
>Xiao Zhang (5):
>  net/ixgbe: fix dereference after null check coverity
>  net/ice: fix dereference after null check coverity
>  net/i40e: fix dereference after null check coverity
>  net/iavf: fix dereference after null check coverity
>  net/fm10k: fix dereference after null check coverity
>
> drivers/net/fm10k/fm10k_rxtx_vec.c     | 1 +
> drivers/net/i40e/i40e_rxtx_vec_avx2.c  | 1 +
> drivers/net/i40e/i40e_rxtx_vec_sse.c   | 1 +
> drivers/net/iavf/iavf_rxtx_vec_sse.c   | 1 +
> drivers/net/ice/ice_rxtx_vec_avx2.c    | 1 +
> drivers/net/ice/ice_rxtx_vec_sse.c     | 1 +
> drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c | 1 +
> 7 files changed, 7 insertions(+)
>
>-- 
>2.7.4
>

For the series:
Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>
Qi Zhang Aug. 6, 2019, 11:30 a.m. UTC | #2 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ye Xiaolong
> Sent: Monday, August 5, 2019 11:46 PM
> To: Zhang, Xiao <xiao.zhang@intel.com>
> Cc: dev@dpdk.org; Yang, Qiming <qiming.yang@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>; stable@dpdk.org
> Subject: Re: [dpdk-dev] [v2 0/5] fix dereference after null check coverity
> 
> On 08/06, Xiao Zhang wrote:
> >This patch tries to fix (dereference after null check) coverity issue.
> >The address of first segmented packets for ice, iavf, i40e fm10k and
> >ixgbe was not set correctly during reassembling packets which led to this
> issue.
> >
> >Coverity issue: 343452
> >Coverity issue: 343407
> >Fixes: c68a52b8 ("net/ice: support vector SSE in Rx") Coverity issue:
> >343447
> >Fixes: 319c421f ("net/avf: enable SSE Rx Tx") Coverity issue: 343422
> >Coverity issue: 343403
> >Fixes: ca74903b ("net/i40e: extract non-x86 specific code from vector
> >driver") Coverity issue: 343416
> >Fixes: fe65e1e1 ("fm10k: add vector scatter Rx") Coverity issue: 13245
> >Fixes: 8a44c15a ("net/ixgbe: extract non-x86 specific code from vector
> >driver")

Fix tag size should be 12

> >Cc: stable@dpdk.org
> >
> >v2 Add cover letter and move the fix after invalidation check
> >
> >Xiao Zhang (5):
> >  net/ixgbe: fix dereference after null check coverity
> >  net/ice: fix dereference after null check coverity
> >  net/i40e: fix dereference after null check coverity
> >  net/iavf: fix dereference after null check coverity
> >  net/fm10k: fix dereference after null check coverity
> >
> > drivers/net/fm10k/fm10k_rxtx_vec.c     | 1 +
> > drivers/net/i40e/i40e_rxtx_vec_avx2.c  | 1 +
> > drivers/net/i40e/i40e_rxtx_vec_sse.c   | 1 +
> > drivers/net/iavf/iavf_rxtx_vec_sse.c   | 1 +
> > drivers/net/ice/ice_rxtx_vec_avx2.c    | 1 +
> > drivers/net/ice/ice_rxtx_vec_sse.c     | 1 +
> > drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c | 1 +
> > 7 files changed, 7 insertions(+)
> >
> >--
> >2.7.4
> >
> 
> For the series:
> Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>

Applied to dpdk-next-net-intel with fix tag fix

Thanks
Qi
Xiaolong Ye Aug. 6, 2019, 2:01 p.m. UTC | #3 
Hi, Xiao

On 08/06, Zhang, Qi Z wrote:
>
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ye Xiaolong
>> Sent: Monday, August 5, 2019 11:46 PM
>> To: Zhang, Xiao <xiao.zhang@intel.com>
>> Cc: dev@dpdk.org; Yang, Qiming <qiming.yang@intel.com>; Xing, Beilei
>> <beilei.xing@intel.com>; stable@dpdk.org
>> Subject: Re: [dpdk-dev] [v2 0/5] fix dereference after null check coverity
>> 
>> On 08/06, Xiao Zhang wrote:
>> >This patch tries to fix (dereference after null check) coverity issue.
>> >The address of first segmented packets for ice, iavf, i40e fm10k and
>> >ixgbe was not set correctly during reassembling packets which led to this
>> issue.
>> >
>> >Coverity issue: 343452
>> >Coverity issue: 343407
>> >Fixes: c68a52b8 ("net/ice: support vector SSE in Rx") Coverity issue:
>> >343447
>> >Fixes: 319c421f ("net/avf: enable SSE Rx Tx") Coverity issue: 343422
>> >Coverity issue: 343403
>> >Fixes: ca74903b ("net/i40e: extract non-x86 specific code from vector
>> >driver") Coverity issue: 343416
>> >Fixes: fe65e1e1 ("fm10k: add vector scatter Rx") Coverity issue: 13245
>> >Fixes: 8a44c15a ("net/ixgbe: extract non-x86 specific code from vector
>> >driver")
>
>Fix tag size should be 12

You can add below alias section to you git config file to create proper fix tag conveniently.

[alias]
        fixline = log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %ae'


Thanks,
Xiaolong
Xiao Zhang Aug. 6, 2019, 2:13 p.m. UTC | #4 
Got it. Thanks Xiaolong and Qi.

> -----Original Message-----
> From: Ye, Xiaolong
> Sent: Tuesday, August 6, 2019 10:01 PM
> To: Zhang, Xiao <xiao.zhang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; Yang, Qiming <qiming.yang@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>; stable@dpdk.org
> Subject: Re: [dpdk-dev] [v2 0/5] fix dereference after null check coverity
> 
> Hi, Xiao
> 
> On 08/06, Zhang, Qi Z wrote:
> >
> >
> >> -----Original Message-----
> >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ye Xiaolong
> >> Sent: Monday, August 5, 2019 11:46 PM
> >> To: Zhang, Xiao <xiao.zhang@intel.com>
> >> Cc: dev@dpdk.org; Yang, Qiming <qiming.yang@intel.com>; Xing, Beilei
> >> <beilei.xing@intel.com>; stable@dpdk.org
> >> Subject: Re: [dpdk-dev] [v2 0/5] fix dereference after null check
> >> coverity
> >>
> >> On 08/06, Xiao Zhang wrote:
> >> >This patch tries to fix (dereference after null check) coverity issue.
> >> >The address of first segmented packets for ice, iavf, i40e fm10k and
> >> >ixgbe was not set correctly during reassembling packets which led to
> >> >this
> >> issue.
> >> >
> >> >Coverity issue: 343452
> >> >Coverity issue: 343407
> >> >Fixes: c68a52b8 ("net/ice: support vector SSE in Rx") Coverity issue:
> >> >343447
> >> >Fixes: 319c421f ("net/avf: enable SSE Rx Tx") Coverity issue: 343422
> >> >Coverity issue: 343403
> >> >Fixes: ca74903b ("net/i40e: extract non-x86 specific code from
> >> >vector
> >> >driver") Coverity issue: 343416
> >> >Fixes: fe65e1e1 ("fm10k: add vector scatter Rx") Coverity issue:
> >> >13245
> >> >Fixes: 8a44c15a ("net/ixgbe: extract non-x86 specific code from
> >> >vector
> >> >driver")
> >
> >Fix tag size should be 12
> 
> You can add below alias section to you git config file to create proper fix tag
> conveniently.
> 
> [alias]
>         fixline = log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %ae'
> 
> 
> Thanks,
> Xiaolong