mbox series

[v6,0/8] net/ether: enhancements and optimizations

Message ID 20190702165017.3802-1-stephen@networkplumber.org (mailing list archive)
Headers
Series net/ether: enhancements and optimizations |

Message

Stephen Hemminger July 2, 2019, 4:50 p.m. UTC 
  This is a collection of patches around the ethernet address
manipulation routines in librte_net/rte_ether.

v6
   add librte_net to axgbe and memif Makefile
v5
   reword commit messages to workaround check-log complaints
v4
   fix meson build
   reword commit messages
   add bonding and tespmd patches
v3 
   rebase to use rte_ether prefix
   drop aligning ethernet headers for now.

Bruce Richardson (1):
  net/ether: mark ethernet addresses as being 2-byte aligned

Stephen Hemminger (7):
  net/rte_ether: deinline non-critical functions
  net/ether: add function to convert string to ethernet address
  ethdev: use new ethernet parsing function
  net/ether: use bitops to speedup comparison
  cmdline: use new ethernet address parser
  net/bonding: use new ethernet address parser
  app/testpmd: use new ethernet address parser

 app/test-pmd/cmdline_flow.c                  |  5 +-
 app/test-pmd/config.c                        | 10 +--
 app/test-pmd/parameters.c                    | 15 +---
 drivers/net/axgbe/Makefile                   |  2 +-
 drivers/net/bonding/Makefile                 |  2 +-
 drivers/net/bonding/meson.build              |  2 +-
 drivers/net/bonding/rte_eth_bond_args.c      |  6 +-
 drivers/net/memif/Makefile                   |  2 +-
 lib/Makefile                                 |  3 +-
 lib/librte_cmdline/Makefile                  |  3 +-
 lib/librte_cmdline/cmdline_parse_etheraddr.c | 71 +++---------------
 lib/librte_cmdline/meson.build               |  6 +-
 lib/librte_ethdev/Makefile                   |  2 +-
 lib/librte_ethdev/meson.build                |  2 +-
 lib/librte_ethdev/rte_class_eth.c            |  9 +--
 lib/librte_net/Makefile                      |  1 +
 lib/librte_net/meson.build                   |  2 +-
 lib/librte_net/rte_ether.c                   | 76 ++++++++++++++++++++
 lib/librte_net/rte_ether.h                   | 59 +++++++--------
 lib/librte_net/rte_net_version.map           |  8 +++
 lib/meson.build                              |  2 +-
 21 files changed, 144 insertions(+), 144 deletions(-)
 create mode 100644 lib/librte_net/rte_ether.c

Comments

Thomas Monjalon July 2, 2019, 9:37 p.m. UTC | #1 
> Stephen Hemminger (7):
>   net/rte_ether: deinline non-critical functions
>   net/ether: add function to convert string to ethernet address
>   ethdev: use new ethernet parsing function
>   net/ether: use bitops to speedup comparison
>   cmdline: use new ethernet address parser
>   net/bonding: use new ethernet address parser
>   app/testpmd: use new ethernet address parser

There are other MAC parsing code:
	drivers/net/failsafe/failsafe_args.c - fs_get_mac_addr_arg()
	drivers/net/memif/rte_eth_memif.c - memif_set_mac()
	drivers/net/vdev_netvsc/vdev_netvsc.c - vdev_netvsc_netvsc_probe()
	drivers/net/virtio/virtio_user/virtio_user_dev.c - parse_mac()
Should they be replaced?
Stephen Hemminger July 2, 2019, 10:03 p.m. UTC | #2 
On Tue, 02 Jul 2019 23:37:29 +0200
Thomas Monjalon <thomas@monjalon.net> wrote:

> > Stephen Hemminger (7):
> >   net/rte_ether: deinline non-critical functions
> >   net/ether: add function to convert string to ethernet address
> >   ethdev: use new ethernet parsing function
> >   net/ether: use bitops to speedup comparison
> >   cmdline: use new ethernet address parser
> >   net/bonding: use new ethernet address parser
> >   app/testpmd: use new ethernet address parser  
> 
> There are other MAC parsing code:
> 	drivers/net/failsafe/failsafe_args.c - fs_get_mac_addr_arg()
> 	drivers/net/memif/rte_eth_memif.c - memif_set_mac()
> 	drivers/net/vdev_netvsc/vdev_netvsc.c - vdev_netvsc_netvsc_probe()
> 	drivers/net/virtio/virtio_user/virtio_user_dev.c - parse_mac()
> Should they be replaced?
> 
> 

Sure, I can add these to v7