[0/3] some update on CVL shared code
mbox series

Message ID 20190626023025.7039-1-leyi.rong@intel.com
Headers show
Series
  • some update on CVL shared code
Related show

Message

Rong, Leyi June 26, 2019, 2:30 a.m. UTC
Main changes:
1. Add support for IPv6 based switch filters
2. Add support for ethertype switch filters
3. fix inner L2 offset in GRE dummy packet

Leyi Rong (3):
  net/ice/base: add support for IPv6 based switch filters
  net/ice/base: add support for ethertype switch filters
  net/ice/base: fix inner L2 offset in GRE dummy packet

 drivers/net/ice/base/ice_protocol_type.h |  22 +++--
 drivers/net/ice/base/ice_switch.c        | 117 +++++++++++++++++++++--
 2 files changed, 123 insertions(+), 16 deletions(-)

Comments

Yang, Qiming June 26, 2019, 5:29 a.m. UTC | #1
Hi, Leyi
Seems still have compile issue. Like,
/tmp/SUSE15-64_K4.12.14_Clang5.0.1/x86_64-native-linuxapp-clang/251e3d92c8954331a686b2e9a9b73e2a/dpdk/drivers/net/ice/base/ice_switch.c:4636:18: error: comparison of constant 16 with expression of type 'enum ice_protocol_type' is always true [-Werror,-Wtautological-constant-out-of-range-compare]
                    rule->type < ARRAY_SIZE(ice_prot_ext)) {
                    ~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Qiming
> -----Original Message-----
> From: Rong, Leyi
> Sent: Wednesday, June 26, 2019 10:30 AM
> To: Ye, Xiaolong <xiaolong.ye@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>
> Cc: dev@dpdk.org; Rong, Leyi <leyi.rong@intel.com>
> Subject: [PATCH 0/3] some update on CVL shared code
> 
> Main changes:
> 1. Add support for IPv6 based switch filters 2. Add support for ethertype
> switch filters 3. fix inner L2 offset in GRE dummy packet
> 
> Leyi Rong (3):
>   net/ice/base: add support for IPv6 based switch filters
>   net/ice/base: add support for ethertype switch filters
>   net/ice/base: fix inner L2 offset in GRE dummy packet
> 
>  drivers/net/ice/base/ice_protocol_type.h |  22 +++--
>  drivers/net/ice/base/ice_switch.c        | 117 +++++++++++++++++++++--
>  2 files changed, 123 insertions(+), 16 deletions(-)
> 
> --
> 2.17.1
Zhao1, Wei June 26, 2019, 9:36 a.m. UTC | #2
Hi, Qiming

  I do not have any error in building these patch, is it related to OS version?


> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yang, Qiming
> Sent: Wednesday, June 26, 2019 1:30 PM
> To: Rong, Leyi <leyi.rong@intel.com>; Ye, Xiaolong <xiaolong.ye@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 0/3] some update on CVL shared code
> 
> Hi, Leyi
> Seems still have compile issue. Like,
> /tmp/SUSE15-64_K4.12.14_Clang5.0.1/x86_64-native-linuxapp-
> clang/251e3d92c8954331a686b2e9a9b73e2a/dpdk/drivers/net/ice/base/ice_s
> witch.c:4636:18: error: comparison of constant 16 with expression of type
> 'enum ice_protocol_type' is always true [-Werror,-Wtautological-constant-out-
> of-range-compare]
>                     rule->type < ARRAY_SIZE(ice_prot_ext)) {
>                     ~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~
> 1 error generated.
> 
> Qiming
> > -----Original Message-----
> > From: Rong, Leyi
> > Sent: Wednesday, June 26, 2019 10:30 AM
> > To: Ye, Xiaolong <xiaolong.ye@intel.com>; Yang, Qiming
> > <qiming.yang@intel.com>
> > Cc: dev@dpdk.org; Rong, Leyi <leyi.rong@intel.com>
> > Subject: [PATCH 0/3] some update on CVL shared code
> >
> > Main changes:
> > 1. Add support for IPv6 based switch filters 2. Add support for
> > ethertype switch filters 3. fix inner L2 offset in GRE dummy packet
> >
> > Leyi Rong (3):
> >   net/ice/base: add support for IPv6 based switch filters
> >   net/ice/base: add support for ethertype switch filters
> >   net/ice/base: fix inner L2 offset in GRE dummy packet
> >
> >  drivers/net/ice/base/ice_protocol_type.h |  22 +++--
> >  drivers/net/ice/base/ice_switch.c        | 117 +++++++++++++++++++++--
> >  2 files changed, 123 insertions(+), 16 deletions(-)
> >
> > --
> > 2.17.1
Yang, Qiming June 27, 2019, 2:05 a.m. UTC | #3
Please saw the compile error in community. Not x86_64 gcc.

> -----Original Message-----
> From: Zhao1, Wei
> Sent: Wednesday, June 26, 2019 5:36 PM
> To: Yang, Qiming <qiming.yang@intel.com>; Rong, Leyi
> <leyi.rong@intel.com>; Ye, Xiaolong <xiaolong.ye@intel.com>
> Cc: dev@dpdk.org
> Subject: RE: [PATCH 0/3] some update on CVL shared code
> 
> Hi, Qiming
> 
>   I do not have any error in building these patch, is it related to OS version?
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yang, Qiming
> > Sent: Wednesday, June 26, 2019 1:30 PM
> > To: Rong, Leyi <leyi.rong@intel.com>; Ye, Xiaolong
> > <xiaolong.ye@intel.com>
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH 0/3] some update on CVL shared code
> >
> > Hi, Leyi
> > Seems still have compile issue. Like,
> > /tmp/SUSE15-64_K4.12.14_Clang5.0.1/x86_64-native-linuxapp-
> >
> clang/251e3d92c8954331a686b2e9a9b73e2a/dpdk/drivers/net/ice/base/ice_
> s
> > witch.c:4636:18: error: comparison of constant 16 with expression of
> > type 'enum ice_protocol_type' is always true
> > [-Werror,-Wtautological-constant-out-
> > of-range-compare]
> >                     rule->type < ARRAY_SIZE(ice_prot_ext)) {
> >                     ~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~
> > 1 error generated.
> >
> > Qiming
> > > -----Original Message-----
> > > From: Rong, Leyi
> > > Sent: Wednesday, June 26, 2019 10:30 AM
> > > To: Ye, Xiaolong <xiaolong.ye@intel.com>; Yang, Qiming
> > > <qiming.yang@intel.com>
> > > Cc: dev@dpdk.org; Rong, Leyi <leyi.rong@intel.com>
> > > Subject: [PATCH 0/3] some update on CVL shared code
> > >
> > > Main changes:
> > > 1. Add support for IPv6 based switch filters 2. Add support for
> > > ethertype switch filters 3. fix inner L2 offset in GRE dummy packet
> > >
> > > Leyi Rong (3):
> > >   net/ice/base: add support for IPv6 based switch filters
> > >   net/ice/base: add support for ethertype switch filters
> > >   net/ice/base: fix inner L2 offset in GRE dummy packet
> > >
> > >  drivers/net/ice/base/ice_protocol_type.h |  22 +++--
> > >  drivers/net/ice/base/ice_switch.c        | 117 +++++++++++++++++++++--
> > >  2 files changed, 123 insertions(+), 16 deletions(-)
> > >
> > > --
> > > 2.17.1