[v7,0/3] Enable rte_flow API in ice driver
mbox series

Message ID 20190625064815.3337-1-qiming.yang@intel.com
Headers show
Series
  • Enable rte_flow API in ice driver
Related show

Message

Yang, Qiming June 25, 2019, 6:48 a.m. UTC
This patch set enables the backend of rte_flow, and the generic
filter related functions in ice driver. Supported flows include
ipv4, tcpv4, udpv4, ipv6, tcpv6, udpv6, tunnel, etc. This patch
set depends on shared code update.

---
v2 changes:
 - added UDP tunnel port support.
 - fixed compile issue.
 - added document update.
v3 changes:
 - removed redundancy parser.
 - added License.
 - added VXLAN and NVGRE item support.
v4 changes:
 - fixed some typos.
v5 changes:
 - fixed checkpatch issues.
v6 changes:
 - fixed one uninitialize issue.
v7 changes:
 - fixed queue action validation.

Qiming Yang (2):
  net/ice: add generic flow API
  net/ice: add UDP tunnel port support

wei zhao (1):
  net/ice: enable switch filter

 drivers/net/ice/Makefile            |   2 +
 drivers/net/ice/ice_ethdev.c        | 116 ++++++
 drivers/net/ice/ice_ethdev.h        |  12 +
 drivers/net/ice/ice_generic_flow.c  | 696 ++++++++++++++++++++++++++++++++++++
 drivers/net/ice/ice_generic_flow.h  | 614 +++++++++++++++++++++++++++++++
 drivers/net/ice/ice_switch_filter.c | 512 ++++++++++++++++++++++++++
 drivers/net/ice/ice_switch_filter.h |  24 ++
 drivers/net/ice/meson.build         |   4 +-
 8 files changed, 1979 insertions(+), 1 deletion(-)
 create mode 100644 drivers/net/ice/ice_generic_flow.c
 create mode 100644 drivers/net/ice/ice_generic_flow.h
 create mode 100644 drivers/net/ice/ice_switch_filter.c
 create mode 100644 drivers/net/ice/ice_switch_filter.h

Comments

Aaron Conole June 25, 2019, 2:58 p.m. UTC | #1
Qiming Yang <qiming.yang@intel.com> writes:

> This patch set enables the backend of rte_flow, and the generic
> filter related functions in ice driver. Supported flows include
> ipv4, tcpv4, udpv4, ipv6, tcpv6, udpv6, tunnel, etc. This patch
> set depends on shared code update.
>
> ---
> v2 changes:
>  - added UDP tunnel port support.
>  - fixed compile issue.
>  - added document update.
> v3 changes:
>  - removed redundancy parser.
>  - added License.
>  - added VXLAN and NVGRE item support.
> v4 changes:
>  - fixed some typos.
> v5 changes:
>  - fixed checkpatch issues.
> v6 changes:
>  - fixed one uninitialize issue.
> v7 changes:
>  - fixed queue action validation.

Seems there is still compliation problems - is some dependency not
correctly updated?

https://travis-ci.com/ovsrobot/dpdk/jobs/210680563

> Qiming Yang (2):
>   net/ice: add generic flow API
>   net/ice: add UDP tunnel port support
>
> wei zhao (1):
>   net/ice: enable switch filter
>
>  drivers/net/ice/Makefile            |   2 +
>  drivers/net/ice/ice_ethdev.c        | 116 ++++++
>  drivers/net/ice/ice_ethdev.h        |  12 +
>  drivers/net/ice/ice_generic_flow.c  | 696 ++++++++++++++++++++++++++++++++++++
>  drivers/net/ice/ice_generic_flow.h  | 614 +++++++++++++++++++++++++++++++
>  drivers/net/ice/ice_switch_filter.c | 512 ++++++++++++++++++++++++++
>  drivers/net/ice/ice_switch_filter.h |  24 ++
>  drivers/net/ice/meson.build         |   4 +-
>  8 files changed, 1979 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/net/ice/ice_generic_flow.c
>  create mode 100644 drivers/net/ice/ice_generic_flow.h
>  create mode 100644 drivers/net/ice/ice_switch_filter.c
>  create mode 100644 drivers/net/ice/ice_switch_filter.h
Yang, Qiming June 26, 2019, 1:52 a.m. UTC | #2
Hi,
It seems these error induced by lack of some base code which are merged in dpdk-next-net-intel branch.
It's not this patch set's issue.

Qiming
-----Original Message-----
From: Aaron Conole [mailto:aconole@redhat.com] 
Sent: Tuesday, June 25, 2019 10:58 PM
To: Yang, Qiming <qiming.yang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v7 0/3] Enable rte_flow API in ice driver

Qiming Yang <qiming.yang@intel.com> writes:

> This patch set enables the backend of rte_flow, and the generic filter 
> related functions in ice driver. Supported flows include ipv4, tcpv4, 
> udpv4, ipv6, tcpv6, udpv6, tunnel, etc. This patch set depends on 
> shared code update.
>
> ---
> v2 changes:
>  - added UDP tunnel port support.
>  - fixed compile issue.
>  - added document update.
> v3 changes:
>  - removed redundancy parser.
>  - added License.
>  - added VXLAN and NVGRE item support.
> v4 changes:
>  - fixed some typos.
> v5 changes:
>  - fixed checkpatch issues.
> v6 changes:
>  - fixed one uninitialize issue.
> v7 changes:
>  - fixed queue action validation.

Seems there is still compliation problems - is some dependency not correctly updated?

https://travis-ci.com/ovsrobot/dpdk/jobs/210680563

> Qiming Yang (2):
>   net/ice: add generic flow API
>   net/ice: add UDP tunnel port support
>
> wei zhao (1):
>   net/ice: enable switch filter
>
>  drivers/net/ice/Makefile            |   2 +
>  drivers/net/ice/ice_ethdev.c        | 116 ++++++
>  drivers/net/ice/ice_ethdev.h        |  12 +
>  drivers/net/ice/ice_generic_flow.c  | 696 
> ++++++++++++++++++++++++++++++++++++
>  drivers/net/ice/ice_generic_flow.h  | 614 
> +++++++++++++++++++++++++++++++  drivers/net/ice/ice_switch_filter.c | 
> 512 ++++++++++++++++++++++++++  drivers/net/ice/ice_switch_filter.h |  24 ++
>  drivers/net/ice/meson.build         |   4 +-
>  8 files changed, 1979 insertions(+), 1 deletion(-)  create mode 
> 100644 drivers/net/ice/ice_generic_flow.c
>  create mode 100644 drivers/net/ice/ice_generic_flow.h
>  create mode 100644 drivers/net/ice/ice_switch_filter.c
>  create mode 100644 drivers/net/ice/ice_switch_filter.h
Ferruh Yigit June 26, 2019, 7:42 a.m. UTC | #3
On 6/26/2019 2:52 AM, Yang, Qiming wrote:
> Hi,
> It seems these error induced by lack of some base code which are merged in dpdk-next-net-intel branch.
> It's not this patch set's issue.

If there is a dependency to another patchset, can you please put this
information into cover letter?

> 
> Qiming
> -----Original Message-----
> From: Aaron Conole [mailto:aconole@redhat.com] 
> Sent: Tuesday, June 25, 2019 10:58 PM
> To: Yang, Qiming <qiming.yang@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v7 0/3] Enable rte_flow API in ice driver
> 
> Qiming Yang <qiming.yang@intel.com> writes:
> 
>> This patch set enables the backend of rte_flow, and the generic filter 
>> related functions in ice driver. Supported flows include ipv4, tcpv4, 
>> udpv4, ipv6, tcpv6, udpv6, tunnel, etc. This patch set depends on 
>> shared code update.
>>
>> ---
>> v2 changes:
>>  - added UDP tunnel port support.
>>  - fixed compile issue.
>>  - added document update.
>> v3 changes:
>>  - removed redundancy parser.
>>  - added License.
>>  - added VXLAN and NVGRE item support.
>> v4 changes:
>>  - fixed some typos.
>> v5 changes:
>>  - fixed checkpatch issues.
>> v6 changes:
>>  - fixed one uninitialize issue.
>> v7 changes:
>>  - fixed queue action validation.
> 
> Seems there is still compliation problems - is some dependency not correctly updated?
> 
> https://travis-ci.com/ovsrobot/dpdk/jobs/210680563
> 
>> Qiming Yang (2):
>>   net/ice: add generic flow API
>>   net/ice: add UDP tunnel port support
>>
>> wei zhao (1):
>>   net/ice: enable switch filter
>>
>>  drivers/net/ice/Makefile            |   2 +
>>  drivers/net/ice/ice_ethdev.c        | 116 ++++++
>>  drivers/net/ice/ice_ethdev.h        |  12 +
>>  drivers/net/ice/ice_generic_flow.c  | 696 
>> ++++++++++++++++++++++++++++++++++++
>>  drivers/net/ice/ice_generic_flow.h  | 614 
>> +++++++++++++++++++++++++++++++  drivers/net/ice/ice_switch_filter.c | 
>> 512 ++++++++++++++++++++++++++  drivers/net/ice/ice_switch_filter.h |  24 ++
>>  drivers/net/ice/meson.build         |   4 +-
>>  8 files changed, 1979 insertions(+), 1 deletion(-)  create mode 
>> 100644 drivers/net/ice/ice_generic_flow.c
>>  create mode 100644 drivers/net/ice/ice_generic_flow.h
>>  create mode 100644 drivers/net/ice/ice_switch_filter.c
>>  create mode 100644 drivers/net/ice/ice_switch_filter.h
Yang, Qiming June 26, 2019, 8:26 a.m. UTC | #4
Sure, I'll add the information in cover letter. 

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Wednesday, June 26, 2019 3:43 PM
> To: Yang, Qiming <qiming.yang@intel.com>; Aaron Conole
> <aconole@redhat.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v7 0/3] Enable rte_flow API in ice driver
> 
> On 6/26/2019 2:52 AM, Yang, Qiming wrote:
> > Hi,
> > It seems these error induced by lack of some base code which are merged
> in dpdk-next-net-intel branch.
> > It's not this patch set's issue.
> 
> If there is a dependency to another patchset, can you please put this
> information into cover letter?
> 
> >
> > Qiming
> > -----Original Message-----
> > From: Aaron Conole [mailto:aconole@redhat.com]
> > Sent: Tuesday, June 25, 2019 10:58 PM
> > To: Yang, Qiming <qiming.yang@intel.com>
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH v7 0/3] Enable rte_flow API in ice
> > driver
> >
> > Qiming Yang <qiming.yang@intel.com> writes:
> >
> >> This patch set enables the backend of rte_flow, and the generic
> >> filter related functions in ice driver. Supported flows include ipv4,
> >> tcpv4, udpv4, ipv6, tcpv6, udpv6, tunnel, etc. This patch set depends
> >> on shared code update.
> >>
> >> ---
> >> v2 changes:
> >>  - added UDP tunnel port support.
> >>  - fixed compile issue.
> >>  - added document update.
> >> v3 changes:
> >>  - removed redundancy parser.
> >>  - added License.
> >>  - added VXLAN and NVGRE item support.
> >> v4 changes:
> >>  - fixed some typos.
> >> v5 changes:
> >>  - fixed checkpatch issues.
> >> v6 changes:
> >>  - fixed one uninitialize issue.
> >> v7 changes:
> >>  - fixed queue action validation.
> >
> > Seems there is still compliation problems - is some dependency not
> correctly updated?
> >
> > https://travis-ci.com/ovsrobot/dpdk/jobs/210680563
> >
> >> Qiming Yang (2):
> >>   net/ice: add generic flow API
> >>   net/ice: add UDP tunnel port support
> >>
> >> wei zhao (1):
> >>   net/ice: enable switch filter
> >>
> >>  drivers/net/ice/Makefile            |   2 +
> >>  drivers/net/ice/ice_ethdev.c        | 116 ++++++
> >>  drivers/net/ice/ice_ethdev.h        |  12 +
> >>  drivers/net/ice/ice_generic_flow.c  | 696
> >> ++++++++++++++++++++++++++++++++++++
> >>  drivers/net/ice/ice_generic_flow.h  | 614
> >> +++++++++++++++++++++++++++++++  drivers/net/ice/ice_switch_filter.c
> >> +++++++++++++++++++++++++++++++ |
> >> 512 ++++++++++++++++++++++++++  drivers/net/ice/ice_switch_filter.h |
> 24 ++
> >>  drivers/net/ice/meson.build         |   4 +-
> >>  8 files changed, 1979 insertions(+), 1 deletion(-)  create mode
> >> 100644 drivers/net/ice/ice_generic_flow.c
> >>  create mode 100644 drivers/net/ice/ice_generic_flow.h
> >>  create mode 100644 drivers/net/ice/ice_switch_filter.c
> >>  create mode 100644 drivers/net/ice/ice_switch_filter.h
Xiaolong Ye June 26, 2019, 3:52 p.m. UTC | #5
Hi, Qiming

On 06/25, Qiming Yang wrote:
>This patch set enables the backend of rte_flow, and the generic
>filter related functions in ice driver. Supported flows include
>ipv4, tcpv4, udpv4, ipv6, tcpv6, udpv6, tunnel, etc. This patch
>set depends on shared code update.

Please also add doc and release notes for this patchset.

Thanks,
Xiaolong
>
>---
>v2 changes:
> - added UDP tunnel port support.
> - fixed compile issue.
> - added document update.
>v3 changes:
> - removed redundancy parser.
> - added License.
> - added VXLAN and NVGRE item support.
>v4 changes:
> - fixed some typos.
>v5 changes:
> - fixed checkpatch issues.
>v6 changes:
> - fixed one uninitialize issue.
>v7 changes:
> - fixed queue action validation.
>
>Qiming Yang (2):
>  net/ice: add generic flow API
>  net/ice: add UDP tunnel port support
>
>wei zhao (1):
>  net/ice: enable switch filter
>
> drivers/net/ice/Makefile            |   2 +
> drivers/net/ice/ice_ethdev.c        | 116 ++++++
> drivers/net/ice/ice_ethdev.h        |  12 +
> drivers/net/ice/ice_generic_flow.c  | 696 ++++++++++++++++++++++++++++++++++++
> drivers/net/ice/ice_generic_flow.h  | 614 +++++++++++++++++++++++++++++++
> drivers/net/ice/ice_switch_filter.c | 512 ++++++++++++++++++++++++++
> drivers/net/ice/ice_switch_filter.h |  24 ++
> drivers/net/ice/meson.build         |   4 +-
> 8 files changed, 1979 insertions(+), 1 deletion(-)
> create mode 100644 drivers/net/ice/ice_generic_flow.c
> create mode 100644 drivers/net/ice/ice_generic_flow.h
> create mode 100644 drivers/net/ice/ice_switch_filter.c
> create mode 100644 drivers/net/ice/ice_switch_filter.h
>
>-- 
>2.9.5
>